Re: + blackfin-on-chip-rtc-controller-driver.patch added to -mm tree

2007-03-01 Thread Mike Frysinger
On 3/1/07, David Brownell <[EMAIL PROTECTED]> wrote: Look again, but at 2.6.21-rc2 instead ... ISTR that fix went into RC1, but that one's been fixed in various trees (like handhelds.org) for some time. this driver was originally written against 2.6.19.x as we havent gotten the Blackfin arch

Re: + blackfin-on-chip-rtc-controller-driver.patch added to -mm tree

2007-03-01 Thread David Brownell
On Thursday 01 March 2007 11:06 am, Mike Frysinger wrote: > > The set_alarm() method needs to enable the alarm irq if the > > "enabled" flag is set, and the read_alarm() method needs to > > report whether the alarm is enabled. > > from reading other drivers and the documentation, That

Re: + blackfin-on-chip-rtc-controller-driver.patch added to -mm tree

2007-03-01 Thread Alessandro Zummo
On Thu, 1 Mar 2007 14:06:49 -0500 "Mike Frysinger" <[EMAIL PROTECTED]> wrote: > > It's unclear why you > > chose to report "pending" (irq issued but not yet acked) since > > that's uselessly transient state on non-polled hardwre. (That > > flag definition came from EFI, a polled firmware RTC.) >

Re: + blackfin-on-chip-rtc-controller-driver.patch added to -mm tree

2007-03-01 Thread Mike Frysinger
On 3/1/07, David Brownell <[EMAIL PROTECTED]> wrote: Bryan, it'd be nice to see a followup patch addressing those comments from Paul Mundt, especially about that code which will spin-forever-under-spinlock. That spin should probably drop the lock then msleep(1) then restore it before retest...

Re: + blackfin-on-chip-rtc-controller-driver.patch added to -mm tree

2007-03-01 Thread Mike Frysinger
On 3/1/07, David Brownell [EMAIL PROTECTED] wrote: Bryan, it'd be nice to see a followup patch addressing those comments from Paul Mundt, especially about that code which will spin-forever-under-spinlock. That spin should probably drop the lock then msleep(1) then restore it before retest...

Re: + blackfin-on-chip-rtc-controller-driver.patch added to -mm tree

2007-03-01 Thread Alessandro Zummo
On Thu, 1 Mar 2007 14:06:49 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: It's unclear why you chose to report pending (irq issued but not yet acked) since that's uselessly transient state on non-polled hardwre. (That flag definition came from EFI, a polled firmware RTC.) because

Re: + blackfin-on-chip-rtc-controller-driver.patch added to -mm tree

2007-03-01 Thread David Brownell
On Thursday 01 March 2007 11:06 am, Mike Frysinger wrote: The set_alarm() method needs to enable the alarm irq if the enabled flag is set, and the read_alarm() method needs to report whether the alarm is enabled. from reading other drivers and the documentation, That particular call

Re: + blackfin-on-chip-rtc-controller-driver.patch added to -mm tree

2007-03-01 Thread Mike Frysinger
On 3/1/07, David Brownell [EMAIL PROTECTED] wrote: Look again, but at 2.6.21-rc2 instead ... ISTR that fix went into RC1, but that one's been fixed in various trees (like handhelds.org) for some time. this driver was originally written against 2.6.19.x as we havent gotten the Blackfin arch