Re: + fix-procfs-task-exe-symlink.patch added to -mm tree

2008-01-30 Thread Matt Helsley
On Wed, 2008-01-30 at 14:06 +0300, Oleg Nesterov wrote: > Err, I was double wrong. It _is_ trivial to set ->exe_file before exec_mmap(), > > flush_old_exec: > > + get_file(bprm->file); > + set_mm_exe_file(bprm->mm, bprm->file); > retval = exec_mmap(

Re: + fix-procfs-task-exe-symlink.patch added to -mm tree

2008-01-30 Thread Oleg Nesterov
On 01/29, Matt Helsley wrote: > > On Tue, 2008-01-29 at 14:36 +0300, Oleg Nesterov wrote: > > > > This patch has a lot of complications because it tries to preserve the > > current behaviour: we release the bprm->file when all VM_EXECTUABLE vmas > > are unmapped. Q: is this so important/useful? I

Re: + fix-procfs-task-exe-symlink.patch added to -mm tree

2008-01-29 Thread Matt Helsley
On Tue, 2008-01-29 at 14:36 +0300, Oleg Nesterov wrote: > s/mm-commits/lkml/ > > On 01/28, Matt Helsley wrote: > > > > On Sun, 2008-01-27 at 19:25 +0300, Oleg Nesterov wrote: > > > > > > Why? Linux doesn't allow sys_mmap(MAP_EXECUTABLE), so any VM_EXECUTABLE > > > vma > > > should refer to the s

Re: + fix-procfs-task-exe-symlink.patch added to -mm tree

2008-01-29 Thread Oleg Nesterov
s/mm-commits/lkml/ On 01/28, Matt Helsley wrote: > > On Sun, 2008-01-27 at 19:25 +0300, Oleg Nesterov wrote: > > > > Why? Linux doesn't allow sys_mmap(MAP_EXECUTABLE), so any VM_EXECUTABLE vma > > should refer to the same bprm->file which was mapped by elf_map(), no? > > You're right. So in this c