Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-05 Thread Heinz J. Mauelshagen
On Thu, Apr 05, 2001 at 05:54:30PM +0200, Jens Axboe wrote: > On Thu, Apr 05 2001, Heinz J. Mauelshagen wrote: > > > Where? Calling buffer_IO_error would be ok, but there are no such calls > > > in 2.4.3. I just stated elsewhere that submit_bh should probably be > > > clearing the dirty bit, not

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-05 Thread Jens Axboe
On Thu, Apr 05 2001, Heinz J. Mauelshagen wrote: > > Where? Calling buffer_IO_error would be ok, but there are no such calls > > in 2.4.3. I just stated elsewhere that submit_bh should probably be > > clearing the dirty bit, not ll_rw_block, in which case the b_end_io > > is fine. But

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-05 Thread Heinz J. Mauelshagen
On Thu, Apr 05, 2001 at 05:37:31PM +0200, Jens Axboe wrote: > On Thu, Apr 05 2001, Heinz J. Mauelshagen wrote: > > > Irks, another one. lvm_make_request_fn also needs to call b_end_io > > > if a map fails. > > > > This is wrong. > > > > In case of an io error we do already call

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-05 Thread Jens Axboe
On Thu, Apr 05 2001, Heinz J. Mauelshagen wrote: > > Irks, another one. lvm_make_request_fn also needs to call b_end_io > > if a map fails. > > This is wrong. > > In case of an io error we do already call buffer_IO_error() on 2.4 in > lvm_map(). Where? Calling buffer_IO_error would be ok, but

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-05 Thread Heinz J. Mauelshagen
Jens, thanks for the b_dev hint you provided. On Thu, Apr 05, 2001 at 04:49:42PM +0200, Jens Axboe wrote: > On Thu, Apr 05 2001, Jens Axboe wrote: > > To the LVM folks: you can't use b_dev or b_blocknr inside your > > make_request_fn, it destroys stacking drivers such as loop. And > > is just

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-05 Thread Jens Axboe
On Thu, Apr 05 2001, Jens Axboe wrote: > To the LVM folks: you can't use b_dev or b_blocknr inside your > make_request_fn, it destroys stacking drivers such as loop. And > is just plain wrong in the general case too. Irks, another one. lvm_make_request_fn also needs to call b_end_io if a map

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-05 Thread Jens Axboe
On Thu, Apr 05 2001, Jens Axboe wrote: > On Wed, Apr 04 2001, Herbert Valerio Riedel wrote: > > > > fyi, loop devices over lvm LV's dont work for me... > > > > I've tested with 2.4.3final (and some other 2.4.3 derivates) and two > > lvm'ized partitions with a size of about 1gig each; mke2fs > >

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-05 Thread Jens Axboe
On Thu, Apr 05 2001, Jens Axboe wrote: On Wed, Apr 04 2001, Herbert Valerio Riedel wrote: fyi, loop devices over lvm LV's dont work for me... I've tested with 2.4.3final (and some other 2.4.3 derivates) and two lvm'ized partitions with a size of about 1gig each; mke2fs just goes

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-05 Thread Jens Axboe
On Thu, Apr 05 2001, Jens Axboe wrote: To the LVM folks: you can't use b_dev or b_blocknr inside your make_request_fn, it destroys stacking drivers such as loop. And is just plain wrong in the general case too. Irks, another one. lvm_make_request_fn also needs to call b_end_io if a map fails.

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-05 Thread Heinz J. Mauelshagen
Jens, thanks for the b_dev hint you provided. On Thu, Apr 05, 2001 at 04:49:42PM +0200, Jens Axboe wrote: On Thu, Apr 05 2001, Jens Axboe wrote: To the LVM folks: you can't use b_dev or b_blocknr inside your make_request_fn, it destroys stacking drivers such as loop. And is just plain

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-05 Thread Jens Axboe
On Thu, Apr 05 2001, Heinz J. Mauelshagen wrote: Irks, another one. lvm_make_request_fn also needs to call b_end_io if a map fails. This is wrong. In case of an io error we do already call buffer_IO_error() on 2.4 in lvm_map(). Where? Calling buffer_IO_error would be ok, but there are

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-05 Thread Heinz J. Mauelshagen
On Thu, Apr 05, 2001 at 05:37:31PM +0200, Jens Axboe wrote: On Thu, Apr 05 2001, Heinz J. Mauelshagen wrote: Irks, another one. lvm_make_request_fn also needs to call b_end_io if a map fails. This is wrong. In case of an io error we do already call buffer_IO_error() on 2.4 in

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-05 Thread Jens Axboe
On Thu, Apr 05 2001, Heinz J. Mauelshagen wrote: Where? Calling buffer_IO_error would be ok, but there are no such calls in 2.4.3. I just stated elsewhere that submit_bh should probably be clearing the dirty bit, not ll_rw_block, in which case the b_end_io is fine. But buffer_IO_error is

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-05 Thread Heinz J. Mauelshagen
On Thu, Apr 05, 2001 at 05:54:30PM +0200, Jens Axboe wrote: On Thu, Apr 05 2001, Heinz J. Mauelshagen wrote: Where? Calling buffer_IO_error would be ok, but there are no such calls in 2.4.3. I just stated elsewhere that submit_bh should probably be clearing the dirty bit, not

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-04 Thread Jens Axboe
On Wed, Apr 04 2001, Herbert Valerio Riedel wrote: > > fyi, loop devices over lvm LV's dont work for me... > > I've tested with 2.4.3final (and some other 2.4.3 derivates) and two > lvm'ized partitions with a size of about 1gig each; mke2fs > just goes into D-state and stays there when applying

/dev/loop0 over lvm... leading to d-state :-(

2001-04-04 Thread Herbert Valerio Riedel
fyi, loop devices over lvm LV's dont work for me... I've tested with 2.4.3final (and some other 2.4.3 derivates) and two lvm'ized partitions with a size of about 1gig each; mke2fs just goes into D-state and stays there when applying it to /dev/loop0, running it directly on the LV-device

/dev/loop0 over lvm... leading to d-state :-(

2001-04-04 Thread Herbert Valerio Riedel
fyi, loop devices over lvm LV's dont work for me... I've tested with 2.4.3final (and some other 2.4.3 derivates) and two lvm'ized partitions with a size of about 1gig each; mke2fs just goes into D-state and stays there when applying it to /dev/loop0, running it directly on the LV-device

Re: /dev/loop0 over lvm... leading to d-state :-(

2001-04-04 Thread Jens Axboe
On Wed, Apr 04 2001, Herbert Valerio Riedel wrote: fyi, loop devices over lvm LV's dont work for me... I've tested with 2.4.3final (and some other 2.4.3 derivates) and two lvm'ized partitions with a size of about 1gig each; mke2fs just goes into D-state and stays there when applying it to