Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-21 Thread Michal Hocko
On Fri 18-09-20 08:32:13, Vijay Balakrishna wrote: > > > On 9/17/2020 10:45 PM, Michal Hocko wrote: > > On Thu 17-09-20 11:03:56, Vijay Balakrishna wrote: > > [...] > > > > > The auto tuned value is incorrect post hotplug memory operation, in > > > > > our use > > > > > case memoy hot add

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-18 Thread Vijay Balakrishna
On 9/17/2020 10:45 PM, Michal Hocko wrote: On Thu 17-09-20 11:03:56, Vijay Balakrishna wrote: [...] The auto tuned value is incorrect post hotplug memory operation, in our use case memoy hot add occurs very early during boot. Define incorrect. What are the actual values? Have you tried to

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-17 Thread Michal Hocko
On Thu 17-09-20 11:03:56, Vijay Balakrishna wrote: [...] > > > The auto tuned value is incorrect post hotplug memory operation, in our > > > use > > > case memoy hot add occurs very early during boot. > > Define incorrect. What are the actual values? Have you tried to increase > > the value

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-17 Thread Vijay Balakrishna
On 9/17/2020 5:12 AM, Michal Hocko wrote: On Wed 16-09-20 11:28:40, Vijay Balakrishna wrote: [...] OOM splat below. I see we had kmem leak detection turned on here. We haven't run stress with kmem leak detection since uncovereing low min_free_kbytes. During investigation we wanted to make

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-17 Thread Michal Hocko
On Wed 16-09-20 11:28:40, Vijay Balakrishna wrote: [...] > OOM splat below. I see we had kmem leak detection turned on here. We > haven't run stress with kmem leak detection since uncovereing low > min_free_kbytes. During investigation we wanted to make sure there is no > kmem leaks, we didn't

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-16 Thread Vijay Balakrishna
On 9/15/2020 11:53 PM, Michal Hocko wrote: On Tue 15-09-20 08:48:08, Vijay Balakrishna wrote: On 9/15/2020 1:18 AM, Michal Hocko wrote: On Mon 14-09-20 09:57:02, Vijay Balakrishna wrote: On 9/14/2020 7:33 AM, Michal Hocko wrote: On Thu 10-09-20 13:47:39, Vijay Balakrishna wrote: When

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-16 Thread Michal Hocko
On Tue 15-09-20 08:48:08, Vijay Balakrishna wrote: > > > On 9/15/2020 1:18 AM, Michal Hocko wrote: > > On Mon 14-09-20 09:57:02, Vijay Balakrishna wrote: > > > > > > > > > On 9/14/2020 7:33 AM, Michal Hocko wrote: > > > > On Thu 10-09-20 13:47:39, Vijay Balakrishna wrote: > > > > > When memory

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-15 Thread Vijay Balakrishna
On 9/15/2020 1:18 AM, Michal Hocko wrote: On Mon 14-09-20 09:57:02, Vijay Balakrishna wrote: On 9/14/2020 7:33 AM, Michal Hocko wrote: On Thu 10-09-20 13:47:39, Vijay Balakrishna wrote: When memory is hotplug added or removed the min_free_kbytes must be recalculated based on what is

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-15 Thread Pavel Tatashin
On Thu, Sep 10, 2020 at 4:47 PM Vijay Balakrishna wrote: > > When memory is hotplug added or removed the min_free_kbytes must be > recalculated based on what is expected by khugepaged. Currently > after hotplug, min_free_kbytes will be set to a lower default and higher > default set when THP

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-15 Thread Michal Hocko
On Mon 14-09-20 09:57:02, Vijay Balakrishna wrote: > > > On 9/14/2020 7:33 AM, Michal Hocko wrote: > > On Thu 10-09-20 13:47:39, Vijay Balakrishna wrote: > > > When memory is hotplug added or removed the min_free_kbytes must be > > > recalculated based on what is expected by khugepaged.

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-14 Thread Vijay Balakrishna
On 9/10/2020 3:01 PM, Kirill A. Shutemov wrote: On Thu, Sep 10, 2020 at 01:47:39PM -0700, Vijay Balakrishna wrote: When memory is hotplug added or removed the min_free_kbytes must be recalculated based on what is expected by khugepaged. Currently after hotplug, min_free_kbytes will be set

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-14 Thread Vijay Balakrishna
On 9/14/2020 7:33 AM, Michal Hocko wrote: On Thu 10-09-20 13:47:39, Vijay Balakrishna wrote: When memory is hotplug added or removed the min_free_kbytes must be recalculated based on what is expected by khugepaged. Currently after hotplug, min_free_kbytes will be set to a lower default and

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-14 Thread Michal Hocko
On Thu 10-09-20 13:47:39, Vijay Balakrishna wrote: > When memory is hotplug added or removed the min_free_kbytes must be > recalculated based on what is expected by khugepaged. Currently > after hotplug, min_free_kbytes will be set to a lower default and higher > default set when THP enabled is

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-10 Thread Vijay Balakrishna
On 9/10/2020 3:28 PM, Pavel Tatashin wrote: Hi Kirill, On Thu, Sep 10, 2020 at 6:01 PM Kirill A. Shutemov wrote: On Thu, Sep 10, 2020 at 01:47:39PM -0700, Vijay Balakrishna wrote: When memory is hotplug added or removed the min_free_kbytes must be recalculated based on what is expected

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-10 Thread Pavel Tatashin
Hi Kirill, On Thu, Sep 10, 2020 at 6:01 PM Kirill A. Shutemov wrote: > > On Thu, Sep 10, 2020 at 01:47:39PM -0700, Vijay Balakrishna wrote: > > When memory is hotplug added or removed the min_free_kbytes must be > > recalculated based on what is expected by khugepaged. Currently > > after

Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-10 Thread Kirill A. Shutemov
On Thu, Sep 10, 2020 at 01:47:39PM -0700, Vijay Balakrishna wrote: > When memory is hotplug added or removed the min_free_kbytes must be > recalculated based on what is expected by khugepaged. Currently > after hotplug, min_free_kbytes will be set to a lower default and higher > default set when

[[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-10 Thread Vijay Balakrishna
When memory is hotplug added or removed the min_free_kbytes must be recalculated based on what is expected by khugepaged. Currently after hotplug, min_free_kbytes will be set to a lower default and higher default set when THP enabled is lost. This leaves the system with small min_free_kbytes