Re: [[PATCH] 8/9] DMA-UART-Driver-for-AST2500

2018-10-26 Thread sudheer.v
On Sat, Oct 20, 2018 at 09:56:24PM +0530, Vinod wrote: > On 19-10-18, 12:41, sudheer.v wrote: > > On Fri, Oct 19, 2018 at 10:32:24AM +1100, Benjamin Herrenschmidt wrote: > > > On Thu, 2018-10-18 at 15:25 +0530, Vinod wrote: > > > > > > > > > It's not a dmaengine driver. It's a serial UART driver t

Re: [[PATCH] 8/9] DMA-UART-Driver-for-AST2500

2018-10-20 Thread Vinod
On 19-10-18, 12:41, sudheer.v wrote: > On Fri, Oct 19, 2018 at 10:32:24AM +1100, Benjamin Herrenschmidt wrote: > > On Thu, 2018-10-18 at 15:25 +0530, Vinod wrote: > > > > > > > It's not a dmaengine driver. It's a serial UART driver that happens to > > > > use a dedicated DMA engine. > > > > > > T

Re: [[PATCH] 8/9] DMA-UART-Driver-for-AST2500

2018-10-19 Thread sudheer.v
On Fri, Oct 19, 2018 at 10:32:24AM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2018-10-18 at 15:25 +0530, Vinod wrote: > > > > > It's not a dmaengine driver. It's a serial UART driver that happens to > > > use a dedicated DMA engine. > > > > Then I see no reason for it to use dmaengine APIs. T

Re: [[PATCH] 8/9] DMA-UART-Driver-for-AST2500

2018-10-18 Thread Benjamin Herrenschmidt
On Thu, 2018-10-18 at 15:25 +0530, Vinod wrote: > > > It's not a dmaengine driver. It's a serial UART driver that happens to > > use a dedicated DMA engine. > > Then I see no reason for it to use dmaengine APIs. The framework allows > people to share a controller for many clients, but if you have

Re: [[PATCH] 8/9] DMA-UART-Driver-for-AST2500

2018-10-18 Thread Vinod
On 17-10-18, 19:56, Benjamin Herrenschmidt wrote: > On Wed, 2018-10-17 at 11:35 +0530, Vinod wrote: > > On 17-10-18, 09:41, sudheer.v wrote: > > > > Please add the change log describing the driver and its features > > > > > Signed-off-by: sudheer.v > > > --- > > > drivers/tty/serial/8250/8250_a

Re: [[PATCH] 8/9] DMA-UART-Driver-for-AST2500

2018-10-17 Thread Benjamin Herrenschmidt
On Wed, 2018-10-17 at 11:35 +0530, Vinod wrote: > On 17-10-18, 09:41, sudheer.v wrote: > > Please add the change log describing the driver and its features > > > Signed-off-by: sudheer.v > > > > --- > > drivers/tty/serial/8250/8250_aspeed_uart_dma.c | 1594 > > > > 1

Re: [[PATCH] 8/9] DMA-UART-Driver-for-AST2500

2018-10-16 Thread Vinod
On 17-10-18, 09:41, sudheer.v wrote: Please add the change log describing the driver and its features > Signed-off-by: sudheer.v > --- > drivers/tty/serial/8250/8250_aspeed_uart_dma.c | 1594 > > 1 file changed, 1594 insertions(+) > create mode 100644 drivers/tty/se

[[PATCH] 8/9] DMA-UART-Driver-for-AST2500

2018-10-16 Thread sudheer.v
Signed-off-by: sudheer.v --- drivers/tty/serial/8250/8250_aspeed_uart_dma.c | 1594 1 file changed, 1594 insertions(+) create mode 100644 drivers/tty/serial/8250/8250_aspeed_uart_dma.c diff --git a/drivers/tty/serial/8250/8250_aspeed_uart_dma.c b/drivers/tty/serial/825