On Sun, Sep 02, 2007 at 09:53:22PM -0700, Paul Menage wrote:
> On 9/2/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
> > - s += sprintf(s, "%lu\n", *val);
> > + if (read_strategy)
> > + s += read_strategy(*val, s);
> > + else
> > + s += sprintf(s,
>
> But val is an unsigned long long*. So printing *val with %lu will
> break (at least a warning, and maybe corruption if you had other
> parameters) on 32-bit archs.
>
How does this look?
Changelog for version 4
1. Make all resource counters members unsigned long long
2. Use documentation
But val is an unsigned long long*. So printing *val with %lu will
break (at least a warning, and maybe corruption if you had other
parameters) on 32-bit archs.
How does this look?
Changelog for version 4
1. Make all resource counters members unsigned long long
2. Use documentation
On Sun, Sep 02, 2007 at 09:53:22PM -0700, Paul Menage wrote:
On 9/2/07, Balbir Singh [EMAIL PROTECTED] wrote:
- s += sprintf(s, %lu\n, *val);
+ if (read_strategy)
+ s += read_strategy(*val, s);
+ else
+ s += sprintf(s, %lu\n, *val);
This
On Sun, 2007-09-02 at 16:20 +0530, Balbir Singh wrote:
>
> +Setting a limit to a number that is not a multiple of page size causes
> +rounding up of the value. The user must check back to see (by reading
> +memory.limit_in_bytes), to check for differences between desired values and
> +committed
Paul Menage wrote:
> On 9/3/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
>> Paul Menage wrote:
>>> On 9/2/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
- s += sprintf(s, "%lu\n", *val);
+ if (read_strategy)
+ s += read_strategy(*val, s);
+ else
On 9/3/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
> Paul Menage wrote:
> > On 9/2/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
> >> - s += sprintf(s, "%lu\n", *val);
> >> + if (read_strategy)
> >> + s += read_strategy(*val, s);
> >> + else
> >> + s +=
On 9/3/07, Balbir Singh [EMAIL PROTECTED] wrote:
Paul Menage wrote:
On 9/2/07, Balbir Singh [EMAIL PROTECTED] wrote:
- s += sprintf(s, %lu\n, *val);
+ if (read_strategy)
+ s += read_strategy(*val, s);
+ else
+ s += sprintf(s, %lu\n, *val);
Paul Menage wrote:
On 9/3/07, Balbir Singh [EMAIL PROTECTED] wrote:
Paul Menage wrote:
On 9/2/07, Balbir Singh [EMAIL PROTECTED] wrote:
- s += sprintf(s, %lu\n, *val);
+ if (read_strategy)
+ s += read_strategy(*val, s);
+ else
+ s += sprintf(s,
On Sun, 2007-09-02 at 16:20 +0530, Balbir Singh wrote:
+Setting a limit to a number that is not a multiple of page size causes
+rounding up of the value. The user must check back to see (by reading
+memory.limit_in_bytes), to check for differences between desired values and
+committed
Paul Menage wrote:
> On 9/2/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
>> - s += sprintf(s, "%lu\n", *val);
>> + if (read_strategy)
>> + s += read_strategy(*val, s);
>> + else
>> + s += sprintf(s, "%lu\n", *val);
>
> This would be better as %llu
>
Paul Menage wrote:
> On 9/2/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
>> - s += sprintf(s, "%lu\n", *val);
>> + if (read_strategy)
>> + s += read_strategy(*val, s);
>> + else
>> + s += sprintf(s, "%lu\n", *val);
>
> This would be better as %llu
>
Paul Menage wrote:
On 9/2/07, Balbir Singh [EMAIL PROTECTED] wrote:
- s += sprintf(s, %lu\n, *val);
+ if (read_strategy)
+ s += read_strategy(*val, s);
+ else
+ s += sprintf(s, %lu\n, *val);
This would be better as %llu
+ tmp
Paul Menage wrote:
On 9/2/07, Balbir Singh [EMAIL PROTECTED] wrote:
- s += sprintf(s, %lu\n, *val);
+ if (read_strategy)
+ s += read_strategy(*val, s);
+ else
+ s += sprintf(s, %lu\n, *val);
This would be better as %llu
Hi, Paul,
This does
On 9/2/07, Balbir Singh <[EMAIL PROTECTED]> wrote:
> - s += sprintf(s, "%lu\n", *val);
> + if (read_strategy)
> + s += read_strategy(*val, s);
> + else
> + s += sprintf(s, "%lu\n", *val);
This would be better as %llu
> + tmp =
Changelog for version 3
1. Change memory.limit and memory.usage to memory.limit_in_bytes and
memory.usage_in_bytes respectively
2. Remove "Bytes" from the output of the limit and usage counters
3. Remove spurious printk
Changelog for version 2
1. Back end tracking is done in bytes, round up
On 9/2/07, Balbir Singh [EMAIL PROTECTED] wrote:
- s += sprintf(s, %lu\n, *val);
+ if (read_strategy)
+ s += read_strategy(*val, s);
+ else
+ s += sprintf(s, %lu\n, *val);
This would be better as %llu
+ tmp = simple_strtoul(buf,
17 matches
Mail list logo