Re: [-mm patch] fs/unionfs/: possible cleanups

2007-01-20 Thread Josef Sipek
On Thu, Jan 18, 2007 at 10:55:54PM +0100, Adrian Bunk wrote: > Let's start with a small exercise: > > Consider sparse tells you about a global function: > warning: symbol 'unionfs_d_revalidate_wrap' was not declared. Should > it be static? I ran sparse last week, and cleaned up a few

Re: [-mm patch] fs/unionfs/: possible cleanups

2007-01-20 Thread Josef Sipek
On Thu, Jan 18, 2007 at 10:55:54PM +0100, Adrian Bunk wrote: Let's start with a small exercise: Consider sparse tells you about a global function: warning: symbol 'unionfs_d_revalidate_wrap' was not declared. Should it be static? I ran sparse last week, and cleaned up a few things

[-mm patch] fs/unionfs/: possible cleanups

2007-01-18 Thread Adrian Bunk
On Thu, Jan 11, 2007 at 10:26:27PM -0800, Andrew Morton wrote: >... > - Added the unionfs filesystem driver as git-unionfs.patch (Josef "Jeff" > Sipek <[EMAIL PROTECTED]>) >... > Changes since 2.6.20-rc3-mm1: >... > git-unionfs.patch >... > git trees >... Let's start with a small exercise:

[-mm patch] fs/unionfs/: possible cleanups

2007-01-18 Thread Adrian Bunk
On Thu, Jan 11, 2007 at 10:26:27PM -0800, Andrew Morton wrote: ... - Added the unionfs filesystem driver as git-unionfs.patch (Josef Jeff Sipek [EMAIL PROTECTED]) ... Changes since 2.6.20-rc3-mm1: ... git-unionfs.patch ... git trees ... Let's start with a small exercise: Consider