Re: [ 02/42] TTY: do not update atime/mtime on read/write

2013-05-02 Thread Simon Kirby
On Tue, Apr 30, 2013 at 06:41:44PM -0700, Linus Torvalds wrote: > On Tue, Apr 30, 2013 at 5:57 PM, Linus Torvalds > wrote: > > > > Patch is whitespace-damaged and totally untested! Caveat applicator. > > Ok, so it's still whitespace-damaged, but it seems to work. The > appended has the "8 second

Re: [ 02/42] TTY: do not update atime/mtime on read/write

2013-05-01 Thread Wolfram Gloger
Hi, > --- snip snip --- > drivers/tty/pty.c| 3 +++ > drivers/tty/tty_io.c | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c > index a62798fcc014..59bfaecc4e14 100644 > --- a/drivers/tty/pty.c > +++ b/drivers/tty/pty.c > @@ -68

Re: [ 02/42] TTY: do not update atime/mtime on read/write

2013-04-30 Thread Jiri Slaby
On 05/01/2013 03:41 AM, Linus Torvalds wrote: > On Tue, Apr 30, 2013 at 5:57 PM, Linus Torvalds > wrote: >> >> Patch is whitespace-damaged and totally untested! Caveat applicator. > > Ok, so it's still whitespace-damaged, but it seems to work. The > appended has the "8 second rule" too.. > > Com

Re: [ 02/42] TTY: do not update atime/mtime on read/write

2013-04-30 Thread Linus Torvalds
On Tue, Apr 30, 2013 at 5:57 PM, Linus Torvalds wrote: > > Patch is whitespace-damaged and totally untested! Caveat applicator. Ok, so it's still whitespace-damaged, but it seems to work. The appended has the "8 second rule" too.. Comments? Simon? Linus --- snip snip --- drivers/tt

Re: [ 02/42] TTY: do not update atime/mtime on read/write

2013-04-30 Thread Linus Torvalds
On Mon, Apr 29, 2013 at 6:37 PM, Greg Kroah-Hartman wrote: > > Ah, it's using inotify on the /dev/ptmx device. Jiri, your change > really doesn't affect that at all :( Hmm. Maybe something like the appended? Together with making the time modification be 10 seconds to make Simon happy (that's wha

Re: [ 02/42] TTY: do not update atime/mtime on read/write

2013-04-30 Thread Simon Kirby
On Mon, Apr 29, 2013 at 06:37:24PM -0700, Greg Kroah-Hartman wrote: > On Mon, Apr 29, 2013 at 05:36:40PM -0700, Simon Kirby wrote: > > On Mon, Apr 29, 2013 at 05:21:17PM -0700, Greg Kroah-Hartman wrote: > > > > > On Mon, Apr 29, 2013 at 05:14:45PM -0700, Simon Kirby wrote: > > > > On Mon, Apr 29,

Re: [ 02/42] TTY: do not update atime/mtime on read/write

2013-04-29 Thread Greg Kroah-Hartman
On Mon, Apr 29, 2013 at 05:36:40PM -0700, Simon Kirby wrote: > On Mon, Apr 29, 2013 at 05:21:17PM -0700, Greg Kroah-Hartman wrote: > > > On Mon, Apr 29, 2013 at 05:14:45PM -0700, Simon Kirby wrote: > > > On Mon, Apr 29, 2013 at 12:01:44PM -0700, Greg Kroah-Hartman wrote: > > > > > > > 3.8-stable

Re: [ 02/42] TTY: do not update atime/mtime on read/write

2013-04-29 Thread Simon Kirby
On Mon, Apr 29, 2013 at 05:21:17PM -0700, Greg Kroah-Hartman wrote: > On Mon, Apr 29, 2013 at 05:14:45PM -0700, Simon Kirby wrote: > > On Mon, Apr 29, 2013 at 12:01:44PM -0700, Greg Kroah-Hartman wrote: > > > > > 3.8-stable review patch. If anyone has any objections, please let me > > > know. >

Re: [ 02/42] TTY: do not update atime/mtime on read/write

2013-04-29 Thread Simon Kirby
On Mon, Apr 29, 2013 at 12:01:44PM -0700, Greg Kroah-Hartman wrote: > 3.8-stable review patch. If anyone has any objections, please let me know. I object. This breaks functionality I use every day (seeing who else is working on stuff with "w"). Furthermore, the patch does not actually fix the h

Re: [ 02/42] TTY: do not update atime/mtime on read/write

2013-04-29 Thread Greg Kroah-Hartman
On Mon, Apr 29, 2013 at 05:14:45PM -0700, Simon Kirby wrote: > On Mon, Apr 29, 2013 at 12:01:44PM -0700, Greg Kroah-Hartman wrote: > > > 3.8-stable review patch. If anyone has any objections, please let me know. > > I object. This breaks functionality I use every day (seeing who else is > workin

[ 02/42] TTY: do not update atime/mtime on read/write

2013-04-29 Thread Greg Kroah-Hartman
3.8-stable review patch. If anyone has any objections, please let me know. -- From: Jiri Slaby commit b0de59b5733d18b0d1974a060860a8b5c1b36a2e upstream. On http://vladz.devzero.fr/013_ptmx-timing.php, we can see how to find out length of a password using timestamps of /dev/ptm