Re: [ 092/128] iommu/intel: disable DMAR for g4x integrated gfx

2013-02-03 Thread Greg KH
On Sun, Feb 03, 2013 at 05:24:16PM +0100, Mihai Moldovan wrote: > * On 03.02.2013 03:48 PM, Ben Hutchings wrote: > > [...] > > +static void quirk_iommu_g4x_gfx(struct pci_dev *dev) > > +{ > Shouldn't __devinit be used here too, like for quirk_iommu_rwbf? > > It probably doesn't matter too much. es

Re: [ 092/128] iommu/intel: disable DMAR for g4x integrated gfx

2013-02-03 Thread Mihai Moldovan
* On 03.02.2013 03:48 PM, Ben Hutchings wrote: > [...] > +static void quirk_iommu_g4x_gfx(struct pci_dev *dev) > +{ Shouldn't __devinit be used here too, like for quirk_iommu_rwbf? It probably doesn't matter too much. especially on platforms with Intel IOMMU, but... it makes the code coherent. Be

[ 092/128] iommu/intel: disable DMAR for g4x integrated gfx

2013-02-03 Thread Ben Hutchings
3.2-stable review patch. If anyone has any objections, please let me know. -- From: Daniel Vetter commit 9452618e7462181ed9755236803b6719298a13ce upstream. DMAR support on g4x/gm45 integrated gpus seems to be totally busted. So don't bother, but instead disable it by default t