Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-09 Thread Wen Xiong
Greg KH wrote: For the JSM driver, its up to you whether you feel its needed or not. However, I would like to mention that the DIGI drivers that currently reside in the kernel sources *do* reserve that ioctl space, and is acknowledged by "Documentation/ioctl-number.txt": d' F0-FF linu

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-09 Thread Wen Xiong
Greg KH wrote: On Wed, Mar 09, 2005 at 01:35:41PM -0600, Kilau, Scott wrote: As it stands today, your requirement appears to be that she needs to yank all diags ioctls and sysfs files before the driver can make it into the kernel sources. Not all sysfs files, sysfs files are fine, as long a

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-09 Thread Greg KH
On Wed, Mar 09, 2005 at 01:35:41PM -0600, Kilau, Scott wrote: > As it stands today, your requirement appears to be that she needs > to yank all diags ioctls and sysfs files before the driver can make > it into the kernel sources. Not all sysfs files, sysfs files are fine, as long as they are imple

RE: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-09 Thread Kilau, Scott
> > DPA support is a requirement for all Digi drivers, so it would > > not be possible for me to remove them from my "dgnc" version > > of the driver. > "requirement" from whom and to who? The Linux kernel community? >From our customers who are moving from other OS's to Linux, and expect DPA su

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-09 Thread Greg KH
On Wed, Mar 09, 2005 at 11:42:31AM -0600, Kilau, Scott wrote: > Hi Wendy, Greg, all, > > If IBM intends on our DPA management program to work for the JSM > products, the ioctls are needed. Wendy, what is IBM's stance on this? > DPA support is a requirement for all Digi drivers, so it would > not

RE: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-09 Thread Kilau, Scott
sday, March 09, 2005 11:32 AM To: Greg KH Cc: Kilau, Scott; linux-kernel@vger.kernel.org Subject: Re: [ patch 6/7] drivers/serial/jsm: new serial device driver Greg KH wrote: >On Wed, Mar 09, 2005 at 10:50:04AM -0500, Wen Xiong wrote: > > >>+/* Ioctls needed for dp

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-09 Thread Wen Xiong
Greg KH wrote: On Wed, Mar 09, 2005 at 10:50:04AM -0500, Wen Xiong wrote: +/* Ioctls needed for dpa operation */ +#define DIGI_GETDD ('d'<<8) | 248 /* get driver info */ +#define DIGI_GETBD ('d'<<8) | 249 /* get board info */ +#define DIGI_GET_NI_INFO ('d'<<8) | 250 /* nonintellige

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-09 Thread Greg KH
On Wed, Mar 09, 2005 at 10:50:04AM -0500, Wen Xiong wrote: > +/* Ioctls needed for dpa operation */ > +#define DIGI_GETDD ('d'<<8) | 248 /* get driver info */ > +#define DIGI_GETBD ('d'<<8) | 249 /* get board info */ > +#define DIGI_GET_NI_INFO ('d'<<8) | 250

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-09 Thread Wen Xiong
Greg KH wrote: On Tue, Mar 08, 2005 at 01:42:31PM -0500, Wen Xiong wrote: The following email I got from Scott Kilau in digi: Scott Kilau wrote: The DPA program is very old, and is shared among other drivers and OS's, so changing the code to read the sysfs instead of doing ioctls i

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-08 Thread Greg KH
On Tue, Mar 08, 2005 at 01:42:31PM -0500, Wen Xiong wrote: > The following email I got from Scott Kilau in digi: > Scott Kilau wrote: > >The DPA program is very old, and is shared among other drivers > and OS's, >so changing the code to read the sysfs instead of doing ioctls > is

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-08 Thread Wen Xiong
Greg KH wrote: On Mon, Mar 07, 2005 at 05:48:56PM -0500, Wen Xiong wrote: Since some tools in Digi company need these new ioctls to access device driver. I still keep these new ioctls. What tools? What are they used for? Why do they need them? Why can't they just use the sysfs files?

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-07 Thread Greg KH
On Mon, Mar 07, 2005 at 05:48:56PM -0500, Wen Xiong wrote: > Since some tools in Digi company need these new ioctls to access device > driver. I still keep these new ioctls. What tools? What are they used for? Why do they need them? Why can't they just use the sysfs files? As the driver isn

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-07 Thread Wen Xiong
Greg KH wrote: On Fri, Mar 04, 2005 at 04:08:44PM -0500, Wen Xiong wrote: +/ + * Structure used with ioctl commands for DIGI parameters. + / +struct dig

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-05 Thread Greg KH
On Fri, Mar 04, 2005 at 04:08:44PM -0500, Wen Xiong wrote: > +/ > + * Structure used with ioctl commands for DIGI parameters. > + / > +struct digi_t { > +

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-03-04 Thread Wen Xiong
Greg KH wrote: On Sun, Feb 27, 2005 at 06:40:20PM -0500, Wen Xiong wrote: diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/digi.h linux-2.6.9.new/drivers/serial/jsm/digi.h Oh, and please diff against at least the latest kernel release, 2.6.9 is old... + * $Id: digi.h,v 1.7 2004/09/23 16:08

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-02-27 Thread Greg KH
On Sun, Feb 27, 2005 at 06:40:20PM -0500, Wen Xiong wrote: > > diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/digi.h > linux-2.6.9.new/drivers/serial/jsm/digi.h Oh, and please diff against at least the latest kernel release, 2.6.9 is old... > + * $Id: digi.h,v 1.7 2004/09/23 16:08:30 scottk Ex

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-02-27 Thread Christoph Hellwig
On Sun, Feb 27, 2005 at 07:47:58PM -0500, Jeff Garzik wrote: > >+struct shrink_buf_struct { > >+unsigned intshrink_buf_vaddr; /* Virtual address of board > >*/ > >+unsigned intshrink_buf_phys;/* Physical address of board > >*/ > > Major bug. These should be unsigne

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-02-27 Thread Nish Aravamudan
> diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_driver.h > linux-2.6.9.new/drivers/serial/jsm/jsm_driver.h > --- linux-2.6.9.orig/drivers/serial/jsm/jsm_driver.h1969-12-31 > 18:00:00.0 -0600 > +++ linux-2.6.9.new/drivers/serial/jsm/jsm_driver.h 2005-02-27 > 17:14:44.74795201

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-02-27 Thread Rik van Riel
On Sun, 27 Feb 2005, Wen Xiong wrote: This patch is all headers for this device driver. Signed-off-by: Wen Xiong <[EMAIL PROTECTED]> +++ linux-2.6.9.new/drivers/serial/jsm/digi.h 2005-02-27 17:14:44.746952168 -0600 @@ -0,0 +1,416 @@ +/* + * Copyright 2003 Digi International (www.digi.com) + *

Re: [ patch 6/7] drivers/serial/jsm: new serial device driver

2005-02-27 Thread Jeff Garzik
Wen Xiong wrote: +struct rw_t { + unsigned char rw_req; /* Request type */ + unsigned char rw_board; /* Host Adapter board number*/ + unsigned char rw_conc;/* Concentrator number */ + unsigned char rw_reserved;/*

[ patch 6/7] drivers/serial/jsm: new serial device driver

2005-02-27 Thread Wen Xiong
This patch is all headers for this device driver. Signed-off-by: Wen Xiong <[EMAIL PROTECTED]> diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/digi.h linux-2.6.9.new/drivers/serial/jsm/digi.h --- linux-2.6.9.orig/drivers/serial/jsm/digi.h 1969-12-31 18:00:00.0 -0600 +++ linux-2.6.9.new/dr