3.6.11.9-rc1 stable review patch. If anyone has any objections, please let me know.
------------------ From: "zhangwei(Jovi)" <jovi.zhang...@huawei.com> [ Upstream commit fa44063f9ef163c3a4c8d8c0465bb8a056b42035 ] When wrong argument is passed into uprobe_events it does not return an error: [root@jovi tracing]# echo 'p:myprobe /bin/bash' > uprobe_events [root@jovi tracing]# The proper response is: [root@jovi tracing]# echo 'p:myprobe /bin/bash' > uprobe_events -bash: echo: write error: Invalid argument Link: http://lkml.kernel.org/r/51b964ff.5000...@huawei.com Cc: Frederic Weisbecker <fweis...@gmail.com> Cc: <sri...@linux.vnet.ibm.com> Cc: sta...@vger.kernel.org # 3.5+ Signed-off-by: zhangwei(Jovi) <jovi.zhang...@huawei.com> Signed-off-by: Steven Rostedt <rost...@goodmis.org> --- kernel/trace/trace_uprobe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index 03003cd..77dccfc 100644 --- a/kernel/trace/trace_uprobe.c +++ b/kernel/trace/trace_uprobe.c @@ -243,8 +243,10 @@ static int create_trace_uprobe(int argc, char **argv) return -EINVAL; } arg = strchr(argv[1], ':'); - if (!arg) + if (!arg) { + ret = -EINVAL; goto fail_address_parse; + } *arg++ = '\0'; filename = argv[1]; -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
