Re: [1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe()

2019-09-26 Thread Alexandre Belloni
On 26/09/2019 20:52:38+0200, Markus Elfring wrote: > >> Does this feedback indicate also an agreement for the detail > >> if the mapping of internal phy registers would be a required operation? > >> (Would such a resource allocation eventually be optional?) > > > > It is optional. > > Would you

Re: [1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe()

2019-09-26 Thread Markus Elfring
>> Does this feedback indicate also an agreement for the detail >> if the mapping of internal phy registers would be a required operation? >> (Would such a resource allocation eventually be optional?) > > It is optional. Would you like to integrate an other patch variant then? Regards, Markus

Re: [1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe()

2019-09-26 Thread Alexandre Belloni
On 26/09/2019 17:29:02+0200, Markus Elfring wrote: > >> Simplify this function implementation by using a known wrapper function. > … > > Reviewed-by: Andrew Lunn > > Does this feedback indicate also an agreement for the detail > if the mapping of internal phy registers would be a required

Re: [1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe()

2019-09-26 Thread Markus Elfring
>> Simplify this function implementation by using a known wrapper function. … > Reviewed-by: Andrew Lunn Does this feedback indicate also an agreement for the detail if the mapping of internal phy registers would be a required operation? (Would such a resource allocation eventually be optional?)

Re: [PATCH 1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe()

2019-09-20 Thread Andrew Lunn
On Fri, Sep 20, 2019 at 09:02:40PM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 20 Sep 2019 20:20:34 +0200 > > Simplify this function implementation by using a known wrapper function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus

[PATCH 1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe()

2019-09-20 Thread Markus Elfring
From: Markus Elfring Date: Fri, 20 Sep 2019 20:20:34 +0200 Simplify this function implementation by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/phy/mdio-mscc-miim.c | 18 +- 1 file