Re: [1/2] ubifs: Fix potential memory leaks while iterating entries

2020-06-01 Thread Richard Weinberger
On Mon, Jun 1, 2020 at 4:00 PM Markus Elfring wrote: > > >> I suggest to avoid the specification of duplicate function calls > >> (also for the desired exception handling). > >> Will it be helpful to add a few jump targets? > >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tr

Re: [1/2] ubifs: Fix potential memory leaks while iterating entries

2020-06-01 Thread Markus Elfring
>> I suggest to avoid the specification of duplicate function calls >> (also for the desired exception handling). >> Will it be helpful to add a few jump targets? >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=3d77e6a8804abcc0504

Re: [PATCH 1/2] ubifs: Fix potential memory leaks while iterating entries

2020-06-01 Thread Richard Weinberger
On Mon, Jun 1, 2020 at 3:46 PM Zhihao Cheng wrote: > > 在 2020/6/1 20:00, Markus Elfring 写道: > >> Fix some potential memory leaks in error handling branches while > >> iterating xattr entries. > > Such information is useful. > > > > > >> For example, function ubifs_tnc_remove_ino() > >> forgets to

Re: [PATCH 1/2] ubifs: Fix potential memory leaks while iterating entries

2020-06-01 Thread Zhihao Cheng
在 2020/6/1 20:00, Markus Elfring 写道: Fix some potential memory leaks in error handling branches while iterating xattr entries. Such information is useful. For example, function ubifs_tnc_remove_ino() forgets to free pxent if it exists. Similar problems also exist in ubifs_purge_xattrs(), ubif

Re: [PATCH 1/2] ubifs: Fix potential memory leaks while iterating entries

2020-06-01 Thread Markus Elfring
> Fix some potential memory leaks in error handling branches while > iterating xattr entries. Such information is useful. > For example, function ubifs_tnc_remove_ino() > forgets to free pxent if it exists. Similar problems also exist in > ubifs_purge_xattrs(), ubifs_add_orphan() and ubifs_jnl_w