On Wed, Apr 10, 2013 at 01:36:36PM +0300, Mika Westerberg wrote:
> From: Andy Shevchenko
>
> This makes the error handling much more simpler than open-coding everything
> and in addition makes the probe function smaller and tidier.
>
> Signed-off-by: Andy Shevchenko
> Signed-off-by: Mika
On Wed, Apr 10, 2013 at 01:36:36PM +0300, Mika Westerberg wrote:
From: Andy Shevchenko andriy.shevche...@linux.intel.com
This makes the error handling much more simpler than open-coding everything
and in addition makes the probe function smaller and tidier.
Signed-off-by: Andy Shevchenko
From: Andy Shevchenko
This makes the error handling much more simpler than open-coding everything
and in addition makes the probe function smaller and tidier.
Signed-off-by: Andy Shevchenko
Signed-off-by: Mika Westerberg
---
Changes to v1:
- dropped redundant dev_err() after
From: Andy Shevchenko andriy.shevche...@linux.intel.com
This makes the error handling much more simpler than open-coding everything
and in addition makes the probe function smaller and tidier.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Signed-off-by: Mika Westerberg
> > > i2c_dw_disable_int(dev);
> > > - r = request_irq(dev->irq, i2c_dw_isr, IRQF_SHARED, pdev->name, dev);
> > > + r = devm_request_irq(>dev, dev->irq, i2c_dw_isr, IRQF_SHARED,
> > > + pdev->name, dev);
> >
> > Is it ensured that no interrupts will happen during remove?
On Tue, Apr 09, 2013 at 11:00:32AM +0200, Wolfram Sang wrote:
>
> > @@ -108,32 +108,27 @@ static int dw_i2c_probe(struct platform_device *pdev)
> > return irq; /* -ENXIO */
> > }
> >
> > - ioarea = request_mem_region(mem->start, resource_size(mem),
> > -
> @@ -108,32 +108,27 @@ static int dw_i2c_probe(struct platform_device *pdev)
> return irq; /* -ENXIO */
> }
>
> - ioarea = request_mem_region(mem->start, resource_size(mem),
> - pdev->name);
> - if (!ioarea) {
> - dev_err(>dev, "I2C
@@ -108,32 +108,27 @@ static int dw_i2c_probe(struct platform_device *pdev)
return irq; /* -ENXIO */
}
- ioarea = request_mem_region(mem-start, resource_size(mem),
- pdev-name);
- if (!ioarea) {
- dev_err(pdev-dev, I2C region
On Tue, Apr 09, 2013 at 11:00:32AM +0200, Wolfram Sang wrote:
@@ -108,32 +108,27 @@ static int dw_i2c_probe(struct platform_device *pdev)
return irq; /* -ENXIO */
}
- ioarea = request_mem_region(mem-start, resource_size(mem),
- pdev-name);
-
i2c_dw_disable_int(dev);
- r = request_irq(dev-irq, i2c_dw_isr, IRQF_SHARED, pdev-name, dev);
+ r = devm_request_irq(pdev-dev, dev-irq, i2c_dw_isr, IRQF_SHARED,
+ pdev-name, dev);
Is it ensured that no interrupts will happen during remove? Because the
adapter
Hi Wolfram,
Any comments on this series? Could you consider merging these for 3.10?
Thanks.
On Thu, Mar 21, 2013 at 02:09:54PM +0200, Mika Westerberg wrote:
> From: Andy Shevchenko
>
> This makes the error handling much more simpler than open-coding everything
> and in addition makes the
Hi Wolfram,
Any comments on this series? Could you consider merging these for 3.10?
Thanks.
On Thu, Mar 21, 2013 at 02:09:54PM +0200, Mika Westerberg wrote:
From: Andy Shevchenko andriy.shevche...@linux.intel.com
This makes the error handling much more simpler than open-coding everything
From: Andy Shevchenko
This makes the error handling much more simpler than open-coding everything
and in addition makes the probe function smaller and tidier.
Signed-off-by: Andy Shevchenko
Signed-off-by: Mika Westerberg
---
drivers/i2c/busses/i2c-designware-platdrv.c | 73
From: Andy Shevchenko andriy.shevche...@linux.intel.com
This makes the error handling much more simpler than open-coding everything
and in addition makes the probe function smaller and tidier.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Signed-off-by: Mika Westerberg
14 matches
Mail list logo
