Re: [11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware

2018-01-09 Thread Guenter Roeck
On 01/09/2018 06:41 PM, Gabriel C wrote: 2018-01-10 3:09 GMT+01:00 Guenter Roeck : On Wed, Jan 10, 2018 at 02:26:14AM +0100, Gabriel C wrote: On 10.01.2018 01:05, Guenter Roeck wrote: Hi, On Wed, Jan 10, 2018 at 12:58:00AM +0100, Gabriel C wrote: On 10.01.2018 00:37, Guenter Roeck wrote: Hi

Re: [11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware

2018-01-09 Thread Gabriel C
2018-01-10 3:09 GMT+01:00 Guenter Roeck : > On Wed, Jan 10, 2018 at 02:26:14AM +0100, Gabriel C wrote: >> On 10.01.2018 01:05, Guenter Roeck wrote: >> >Hi, >> > >> >On Wed, Jan 10, 2018 at 12:58:00AM +0100, Gabriel C wrote: >> >>On 10.01.2018 00:37, Guenter Roeck wrote: >> >>>Hi, >> >>> >> >>>On Tu

Re: [11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware

2018-01-09 Thread Guenter Roeck
On Wed, Jan 10, 2018 at 02:26:14AM +0100, Gabriel C wrote: > On 10.01.2018 01:05, Guenter Roeck wrote: > >Hi, > > > >On Wed, Jan 10, 2018 at 12:58:00AM +0100, Gabriel C wrote: > >>On 10.01.2018 00:37, Guenter Roeck wrote: > >>>Hi, > >>> > >>>On Tue, Jan 09, 2018 at 05:58:07PM -0500, Lyude Paul wrot

Re: [11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware

2018-01-09 Thread Gabriel C
On 10.01.2018 01:05, Guenter Roeck wrote: Hi, On Wed, Jan 10, 2018 at 12:58:00AM +0100, Gabriel C wrote: On 10.01.2018 00:37, Guenter Roeck wrote: Hi, On Tue, Jan 09, 2018 at 05:58:07PM -0500, Lyude Paul wrote: Hi! I'm the one from the Fedora bugzilla who said they'd help review these patche

Re: [11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware

2018-01-09 Thread Lyude Paul
Oh fantastic! this works awesome, thank you ♥ On Tue, 2018-01-09 at 16:11 -0800, Guenter Roeck wrote: > On Tue, Jan 09, 2018 at 07:04:25PM -0500, Lyude Paul wrote: > > How exactly did you go about enabling the Super-IO watchdog on your MSI > > board? > > This is an MSI A320M that I'm trying to ma

Re: [11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware

2018-01-09 Thread Guenter Roeck
On Tue, Jan 09, 2018 at 07:04:25PM -0500, Lyude Paul wrote: > How exactly did you go about enabling the Super-IO watchdog on your MSI board? > This is an MSI A320M that I'm trying to make work here > MSI boards use NCT679x Super-IO chips. The watchdog on those chips is supported by the w83627hf_

Re: [11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware

2018-01-09 Thread Guenter Roeck
Hi, On Wed, Jan 10, 2018 at 12:58:00AM +0100, Gabriel C wrote: > On 10.01.2018 00:37, Guenter Roeck wrote: > >Hi, > > > >On Tue, Jan 09, 2018 at 05:58:07PM -0500, Lyude Paul wrote: > >>Hi! I'm the one from the Fedora bugzilla who said they'd help review these > >>patches. I might end up responding

Re: [11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware

2018-01-09 Thread Lyude Paul
How exactly did you go about enabling the Super-IO watchdog on your MSI board? This is an MSI A320M that I'm trying to make work here On Tue, 2018-01-09 at 15:37 -0800, Guenter Roeck wrote: > Hi, > > On Tue, Jan 09, 2018 at 05:58:07PM -0500, Lyude Paul wrote: > > Hi! I'm the one from the Fedora

Re: [11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware

2018-01-09 Thread Gabriel C
On 10.01.2018 00:37, Guenter Roeck wrote: Hi, On Tue, Jan 09, 2018 at 05:58:07PM -0500, Lyude Paul wrote: Hi! I'm the one from the Fedora bugzilla who said they'd help review these patches. I might end up responding to this with a real review comment after this message, but first: mind cc'ing

Re: [11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware

2018-01-09 Thread Guenter Roeck
Hi, On Tue, Jan 09, 2018 at 05:58:07PM -0500, Lyude Paul wrote: > Hi! I'm the one from the Fedora bugzilla who said they'd help review these > patches. I might end up responding to this with a real review comment after > this message, but first: > > mind cc'ing me future versions of this patchset

Re: [11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware

2018-01-09 Thread Lyude Paul
Hi! I'm the one from the Fedora bugzilla who said they'd help review these patches. I might end up responding to this with a real review comment after this message, but first: mind cc'ing me future versions of this patchset and also, is there any way you know of that one could figure out whether o

[PATCH 11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware

2017-12-24 Thread Guenter Roeck
If the watchdog control register indicates that the watchdog hardware is disabled even after we tried to enable it, there is no point to instantiate the driver. Cc: Zoltán Böszörményi Signed-off-by: Guenter Roeck --- drivers/watchdog/sp5100_tco.c | 8 +++- drivers/watchdog/sp5100_tco.h | 1