答复: [2/2] mfd: max77620: Add low battery monitor support

2019-01-29 Thread Mark Zhang
_chip writes 0xFF to offset zero. Mark -邮件原件- 发件人: Billy Laws 发送时间: Tuesday, January 29, 2019 9:34 PM 收件人: Mark Zhang 抄送: Lee Jones ; linux-kernel@vger.kernel.org; linux-te...@vger.kernel.org; Laxman Dewangan ; Venkat Reddy Talla 主题: Re: [2/2] mfd: max77620: Add low battery monito

Re: [2/2] mfd: max77620: Add low battery monitor support

2019-01-29 Thread Billy Laws
It does, see this article https://blog.quendi.moe/2018/07/03/en-debugging-nintendo-switch-linux-power-management-battery-desync-edition/ On Tue, Jan 29, 2019 at 9:03 AM Mark Zhang wrote: > > On 1/29/2019 3:36 PM, Billy Laws wrote: > > Sure, that's fine with me, will send then this gets accepted.

Re: [2/2] mfd: max77620: Add low battery monitor support

2019-01-29 Thread Mark Zhang
On 1/29/2019 3:36 PM, Billy Laws wrote: > Sure, that's fine with me, will send then this gets accepted. Two > other things: you should probably set the reg to 0 if the property > isn't specified as regmap_add_irqchip sets it to 0xff (basically all > enabled on highest limit), and you haven't update

答复: [2/2] mfd: max77620: Add low battery monitor support

2019-01-28 Thread Mark Zhang
Oh yeah will do, thanks. -邮件原件- 发件人: Billy Laws 发送时间: Tuesday, January 29, 2019 3:36 PM 收件人: Mark Zhang 抄送: Lee Jones ; linux-kernel@vger.kernel.org; linux-te...@vger.kernel.org; Laxman Dewangan ; Venkat Reddy Talla 主题: Re: [2/2] mfd: max77620: Add low battery monitor support Sure

Re: [2/2] mfd: max77620: Add low battery monitor support

2019-01-28 Thread Billy Laws
Sure, that's fine with me, will send then this gets accepted. Two other things: you should probably set the reg to 0 if the property isn't specified as regmap_add_irqchip sets it to 0xff (basically all enabled on highest limit), and you haven't updated the dt-bindings. On Tue, Jan 29, 2019 at 6:52

Re: [2/2] mfd: max77620: Add low battery monitor support

2019-01-28 Thread Mark Zhang
On 1/27/2019 10:54 PM, Billy Laws wrote: > >This patch adds PMIC configurations for low-battery > >monitoring by handling max77620 register CNFGGLBL1. > > > It might be an idea to add lbhyst configuration here and support using > custom lbdac values to specify a different cutoff point. Yeah thi

Re: [2/2] mfd: max77620: Add low battery monitor support

2019-01-27 Thread Billy Laws
On 1/28/19, Lee Jones wrote: > Re-sending due to dodgy looking 'reply-to'. > > On Sun, 27 Jan 2019, Billy Laws wrote: > >> >This patch adds PMIC configurations for low-battery >> >monitoring by handling max77620 register CNFGGLBL1. >> > >> It might be an idea to add lbhyst configuration here and s

Re: [2/2] mfd: max77620: Add low battery monitor support

2019-01-27 Thread Lee Jones
Re-sending due to dodgy looking 'reply-to'. On Sun, 27 Jan 2019, Billy Laws wrote: > >This patch adds PMIC configurations for low-battery > >monitoring by handling max77620 register CNFGGLBL1. > > > It might be an idea to add lbhyst configuration here and support using > custom lbdac values to sp

Re: [2/2] mfd: max77620: Add low battery monitor support

2019-01-27 Thread Lee Jones
On Sun, 27 Jan 2019, Billy Laws wrote: > >This patch adds PMIC configurations for low-battery > >monitoring by handling max77620 register CNFGGLBL1. > > > It might be an idea to add lbhyst configuration here and support using > custom lbdac values to specify a different cutoff point. Do you know

Re: [2/2] mfd: max77620: Add low battery monitor support

2019-01-27 Thread Billy Laws
>This patch adds PMIC configurations for low-battery >monitoring by handling max77620 register CNFGGLBL1. > It might be an idea to add lbhyst configuration here and support using custom lbdac values to specify a different cutoff point. See: https://datasheetspdf.com/pdf-file/924230/Maxim/MAX8698C

[PATCH 2/2] mfd: max77620: Add low battery monitor support

2019-01-22 Thread Mark Zhang
This patch adds PMIC configurations for low-battery monitoring by handling max77620 register CNFGGLBL1. Signed-off-by: Laxman Dewangan Signed-off-by: Venkat Reddy Talla Signed-off-by: Mark Zhang --- drivers/mfd/max77620.c | 57 +- 1 file changed, 56 inse