Re: [2/6] uaccess: add probe_kernel_write()

2008-02-11 Thread Randy Dunlap
On Sun, 10 Feb 2008 21:05:40 +0100 Ingo Molnar wrote: > Subject: uaccess: add probe_kernel_write() > From: Ingo Molnar <[EMAIL PROTECTED]> > > add probe_kernel_read() and probe_kernel_write(). > > Uninlined and restricted to kernel range memory only, as suggested > by Linus. > > Signed-off-by:

Re: [2/6] uaccess: add probe_kernel_write()

2008-02-10 Thread Ingo Molnar
* Linus Torvalds <[EMAIL PROTECTED]> wrote: > > Along Linus' suggestion to work on larger chunks in kgdb, here are > > improved probe_kernel_read/write helpers that take a size argument. > > I don't think this is good. > > Make it > - a function, not a #define > - preferably uninlined (this d

Re: [2/6] uaccess: add probe_kernel_write()

2008-02-10 Thread Linus Torvalds
On Sun, 10 Feb 2008, Jan Kiszka wrote: > > Along Linus' suggestion to work on larger chunks in kgdb, here are > improved probe_kernel_read/write helpers that take a size argument. I don't think this is good. Make it - a function, not a #define - preferably uninlined (this does *not* look per

Re: [2/6] uaccess: add probe_kernel_write()

2008-02-10 Thread Jan Kiszka
Ingo Molnar wrote: > From: Ingo Molnar <[EMAIL PROTECTED]> > > add probe_kernel_write() - copy & paste of the existing > probe_kernel_access(), extended to writes. Along Linus' suggestion to work on larger chunks in kgdb, here are improved probe_kernel_read/write helpers that take a size argument

[2/6] uaccess: add probe_kernel_write()

2008-02-09 Thread Ingo Molnar
From: Ingo Molnar <[EMAIL PROTECTED]> add probe_kernel_write() - copy & paste of the existing probe_kernel_access(), extended to writes. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Reviewed-by: Thomas Gleixner <[EMAIL PROTECTED]> --- include/linux/uaccess.h | 22 ++ 1 fi