Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

2005-08-30 Thread Adrian Bunk
On Tue, Aug 30, 2005 at 06:38:19PM +0200, Olaf Hering wrote: > > page_cache_release and release_pages will be undefined when compiling > arch/ppc/configs/common_defconfig, but not arch/i386/defconfig, with > CONFIG_SWAP=n There will be some compile errors in cases where compilation previously wo

Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

2005-08-30 Thread Olaf Hering
On Tue, Aug 30, Adrian Bunk wrote: > On Tue, Aug 30, 2005 at 06:18:14PM +0200, Olaf Hering wrote: > > On Tue, Aug 30, Adrian Bunk wrote: > > > > > Currently, using an undeclared function gives a compile warning, but it > > > can lead to a link or even a runtime error. > > > > > > With -Werror

Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

2005-08-30 Thread Adrian Bunk
On Tue, Aug 30, 2005 at 06:18:14PM +0200, Olaf Hering wrote: > On Tue, Aug 30, Adrian Bunk wrote: > > > Currently, using an undeclared function gives a compile warning, but it > > can lead to a link or even a runtime error. > > > > With -Werror-implicit-function-declaration, we are getting an i

Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

2005-08-30 Thread Olaf Hering
On Tue, Aug 30, Adrian Bunk wrote: > Currently, using an undeclared function gives a compile warning, but it > can lead to a link or even a runtime error. > > With -Werror-implicit-function-declaration, we are getting an immediate > compile error instead. You have to fix CONFIG_SWAP=n as well

[2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

2005-08-30 Thread Adrian Bunk
Currently, using an undeclared function gives a compile warning, but it can lead to a link or even a runtime error. With -Werror-implicit-function-declaration, we are getting an immediate compile error instead. This patch also removes some unneeded spaces between two tabs in the following line

Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

2005-07-30 Thread Adrian Bunk
On Sat, Jul 30, 2005 at 11:08:00AM -0700, Andrew Morton wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > Currently, using an undeclared function gives a compile warning, but it > > can lead to a link or even a runtime error. > > > > With -Werror-implicit-function-declaration, we are gettin

Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

2005-07-30 Thread Sam Ravnborg
On Sat, Jul 30, 2005 at 07:59:11PM +0100, Christoph Hellwig wrote: > On Sat, Jul 30, 2005 at 08:52:26PM +0200, Sam Ravnborg wrote: > > Please - use tabs for indention, not for alignment. > > The below would look rather messy with tabs=4. > > Almost everywhere tabs are used in Makefiles it is plina

Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

2005-07-30 Thread Christoph Hellwig
On Sat, Jul 30, 2005 at 08:52:26PM +0200, Sam Ravnborg wrote: > Please - use tabs for indention, not for alignment. > The below would look rather messy with tabs=4. > Almost everywhere tabs are used in Makefiles it is plina wrong. > Tabs are brillient for indention but you cannot just assume 8 spac

Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

2005-07-30 Thread Sam Ravnborg
On Sat, Jul 30, 2005 at 06:52:02PM +0200, Adrian Bunk wrote: > Currently, using an undeclared function gives a compile warning, but it > can lead to a link or even a runtime error. > > With -Werror-implicit-function-declaration, we are getting an immediate > compile error instead. For i386 this

Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

2005-07-30 Thread Andrew Morton
Adrian Bunk <[EMAIL PROTECTED]> wrote: > > Currently, using an undeclared function gives a compile warning, but it > can lead to a link or even a runtime error. > > With -Werror-implicit-function-declaration, we are getting an immediate > compile error instead. > > This patch also removes some

[2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

2005-07-30 Thread Adrian Bunk
Currently, using an undeclared function gives a compile warning, but it can lead to a link or even a runtime error. With -Werror-implicit-function-declaration, we are getting an immediate compile error instead. This patch also removes some unneeded spaces between two tabs in the following line