This patch contains the following possible cleanups:
- make the needlessly global function __nvram_set_checksum static
- #if 0 the unused global function nvram_set_checksum
- remove the EXPORT_SYMBOL's for both functions
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/char/nvram.c | 6 +++---
include/linux/nvram.h | 2 --
2 files changed, 3 insertions(+), 5 deletions(-)
--- linux-2.6.12-rc2-mm3-full/include/linux/nvram.h.old 2005-04-17
18:15:57.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/linux/nvram.h 2005-04-17
18:16:04.000000000 +0200
@@ -20,8 +20,6 @@
extern void nvram_write_byte(unsigned char c, int i);
extern int __nvram_check_checksum(void);
extern int nvram_check_checksum(void);
-extern void __nvram_set_checksum(void);
-extern void nvram_set_checksum(void);
#endif
#endif /* _LINUX_NVRAM_H */
--- linux-2.6.12-rc2-mm3-full/drivers/char/nvram.c.old 2005-04-17
18:16:10.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/char/nvram.c 2005-04-17
18:16:36.000000000 +0200
@@ -211,12 +211,13 @@
return rv;
}
-void
+static void
__nvram_set_checksum(void)
{
mach_set_checksum();
}
+#if 0
void
nvram_set_checksum(void)
{
@@ -226,6 +227,7 @@
__nvram_set_checksum();
spin_unlock_irqrestore(&rtc_lock, flags);
}
+#endif /* 0 */
/*
* The are the file operation function for user access to /dev/nvram
@@ -921,6 +923,4 @@
EXPORT_SYMBOL(nvram_write_byte);
EXPORT_SYMBOL(__nvram_check_checksum);
EXPORT_SYMBOL(nvram_check_checksum);
-EXPORT_SYMBOL(__nvram_set_checksum);
-EXPORT_SYMBOL(nvram_set_checksum);
MODULE_ALIAS_MISCDEV(NVRAM_MINOR);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
