Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static

2005-01-31 Thread Dmitry Torokhov
On Mon, 31 Jan 2005 23:27:54 +0100, Stelian Pop <[EMAIL PROTECTED]> wrote: > On Mon, Jan 31, 2005 at 05:13:22PM -0500, Dmitry Torokhov wrote: > > > On Mon, 31 Jan 2005 22:49:05 +0100, Stelian Pop <[EMAIL PROTECTED]> wrote: > > > > > > sonypi.h is a "local" header file used only by sonypi.c. > > >

Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static

2005-01-31 Thread Stelian Pop
On Mon, Jan 31, 2005 at 05:13:22PM -0500, Dmitry Torokhov wrote: > On Mon, 31 Jan 2005 22:49:05 +0100, Stelian Pop <[EMAIL PROTECTED]> wrote: > > > > sonypi.h is a "local" header file used only by sonypi.c. > > > > I would like to keep those tables in sonypi.h rather than putting > > all into so

Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static

2005-01-31 Thread Dmitry Torokhov
On Mon, 31 Jan 2005 22:49:05 +0100, Stelian Pop <[EMAIL PROTECTED]> wrote: > > sonypi.h is a "local" header file used only by sonypi.c. > > I would like to keep those tables in sonypi.h rather than putting > all into sonypi.c (or we could as well remove sonypi.h and put all the > contents into th

Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static

2005-01-31 Thread Adrian Bunk
On Mon, Jan 31, 2005 at 10:49:05PM +0100, Stelian Pop wrote: > On Mon, Jan 31, 2005 at 06:35:08PM +0100, Adrian Bunk wrote: > > > This patch makes three needlessly global structs static. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > > --- > > > > drivers/char/sonypi.c | 76 +++

Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static

2005-01-31 Thread Stelian Pop
On Mon, Jan 31, 2005 at 06:35:08PM +0100, Adrian Bunk wrote: > This patch makes three needlessly global structs static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > > drivers/char/sonypi.c | 76 +- > drivers/char/sonypi.h | 74 ---

[2.6 patch] drivers/char/sonypi.c: make 3 structs static

2005-01-31 Thread Adrian Bunk
This patch makes three needlessly global structs static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/char/sonypi.c | 76 +- drivers/char/sonypi.h | 74 2 files changed, 75 insertions(+), 75 delet