Re: [2.6 patch] drivers/isdn/hardware/eicon/: misc possible cleanups

2005-02-08 Thread Armin Schindler
On Wed, 9 Feb 2005, Adrian Bunk wrote: > On Sun, Feb 06, 2005 at 11:18:18AM +0100, Armin Schindler wrote: > > > Hi Adrian, > > Hi Armin, > > > thanks for the proposed patch. > > Making the functions static is a good idea, I will check and test this. > > Removing some functions, especially from i

Re: [2.6 patch] drivers/isdn/hardware/eicon/: misc possible cleanups

2005-02-08 Thread Adrian Bunk
On Sun, Feb 06, 2005 at 11:18:18AM +0100, Armin Schindler wrote: > Hi Adrian, Hi Armin, > thanks for the proposed patch. > Making the functions static is a good idea, I will check and test this. > Removing some functions, especially from io.* and di.* is not good. These > functions are mainly u

Re: [2.6 patch] drivers/isdn/hardware/eicon/: misc possible cleanups

2005-02-06 Thread Armin Schindler
Hi Adrian, thanks for the proposed patch. Making the functions static is a good idea, I will check and test this. Removing some functions, especially from io.* and di.* is not good. These functions are mainly used with other sub-drivers which are not part of the kernel. I will check if they are s

[2.6 patch] drivers/isdn/hardware/eicon/: misc possible cleanups

2005-02-05 Thread Adrian Bunk
This patch contains the following possible cleanups: - make some needlessly global code static - dadapter.h: remoe the unused #define OLD_MAX_DESCRIPTORS - remove the following unused functions: - di.c: pr_test_int - di.c: pr_clear_int - di.c: scom_out - di.c: scom_ready - di.c: scom_dpc