Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups

2005-07-15 Thread Mauro Carvalho Chehab
Adrian, Your patch is at my personal TODO list. We had lots of patches for 2.6.13, with some sigificative enhancements. Unfortunatelly, your patch from 19 Apr 2005 was not applied, maybe because you've sent during a period where V4L was Orphaned. We've decided

[2.6 patch] drivers/media/video/tveeprom.c: possible cleanups

2005-07-15 Thread Adrian Bunk
This patch contains the following possible cleanups: - make two needlessly global structs static - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 9 Jul 2005 - 19 Apr 2005

[2.6 patch] drivers/media/video/tveeprom.c: possible cleanups

2005-07-15 Thread Adrian Bunk
This patch contains the following possible cleanups: - make two needlessly global structs static - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch was already sent on: - 9 Jul 2005 - 19 Apr 2005

Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups

2005-07-15 Thread Mauro Carvalho Chehab
Adrian, Your patch is at my personal TODO list. We had lots of patches for 2.6.13, with some sigificative enhancements. Unfortunatelly, your patch from 19 Apr 2005 was not applied, maybe because you've sent during a period where V4L was Orphaned. We've decided

[2.6 patch] drivers/media/video/tveeprom.c: possible cleanups

2005-07-08 Thread Adrian Bunk
This patch contains the following possible cleanups: - make two needlessly global structs static - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 19 Apr 2005 drivers/media/video/tveeprom.c |

[2.6 patch] drivers/media/video/tveeprom.c: possible cleanups

2005-07-08 Thread Adrian Bunk
This patch contains the following possible cleanups: - make two needlessly global structs static - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch was already sent on: - 19 Apr 2005 drivers/media/video/tveeprom.c |6

Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups

2005-04-19 Thread Gerd Knorr
> - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump That's a debug helper function, please don't drop it. #if 0 might be ok, not sure though, the tveeprom module is also used by a out-of-kernel driver (ivtv). Otherwise the patch looks fine to me. Gerd - To unsubscribe from this

Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups

2005-04-19 Thread Gerd Knorr
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump That's a debug helper function, please don't drop it. #if 0 might be ok, not sure though, the tveeprom module is also used by a out-of-kernel driver (ivtv). Otherwise the patch looks fine to me. Gerd - To unsubscribe from this

[2.6 patch] drivers/media/video/tveeprom.c: possible cleanups

2005-04-18 Thread Adrian Bunk
This patch contains the following possible cleanups: - make two needlessly global structs static - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/media/video/tveeprom.c |6 -- include/media/tveeprom.h |1

[2.6 patch] drivers/media/video/tveeprom.c: possible cleanups

2005-04-18 Thread Adrian Bunk
This patch contains the following possible cleanups: - make two needlessly global structs static - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/media/video/tveeprom.c |6 -- include/media/tveeprom.h |1 -