Re: [2.6 patch] drivers/mmc/core/: make 4 functions static

2007-07-20 Thread Pierre Ossman
On Mon, 16 Jul 2007 04:33:46 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > > If mmc_start_request() is considered part of an API people should > use, why isn't there a prototype in a header file? > Just goes to show how much I know. ;) So I guess we can privatize that one. But I'd still like

Re: [2.6 patch] drivers/mmc/core/: make 4 functions static

2007-07-20 Thread Pierre Ossman
On Mon, 16 Jul 2007 04:33:46 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: If mmc_start_request() is considered part of an API people should use, why isn't there a prototype in a header file? Just goes to show how much I know. ;) So I guess we can privatize that one. But I'd still like to

Re: [2.6 patch] drivers/mmc/core/: make 4 functions static

2007-07-15 Thread Adrian Bunk
On Sun, Jul 15, 2007 at 06:52:34PM +0200, Pierre Ossman wrote: > On Fri, 13 Jul 2007 01:56:02 +0200 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch makes the following needlessly global functions static: > > - sd_ops.c: mmc_wait_for_app_cmd() > > - core.c: mmc_start_request() > > I am

Re: [2.6 patch] drivers/mmc/core/: make 4 functions static

2007-07-15 Thread Pierre Ossman
On Fri, 13 Jul 2007 01:56:02 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > This patch makes the following needlessly global functions static: > - sd_ops.c: mmc_wait_for_app_cmd() > - core.c: mmc_start_request() I am a bit torn about these two. Even though we don't cater to out-of-tree stuff,

Re: [2.6 patch] drivers/mmc/core/: make 4 functions static

2007-07-15 Thread Pierre Ossman
On Fri, 13 Jul 2007 01:56:02 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: This patch makes the following needlessly global functions static: - sd_ops.c: mmc_wait_for_app_cmd() - core.c: mmc_start_request() I am a bit torn about these two. Even though we don't cater to out-of-tree stuff, having

Re: [2.6 patch] drivers/mmc/core/: make 4 functions static

2007-07-15 Thread Adrian Bunk
On Sun, Jul 15, 2007 at 06:52:34PM +0200, Pierre Ossman wrote: On Fri, 13 Jul 2007 01:56:02 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: This patch makes the following needlessly global functions static: - sd_ops.c: mmc_wait_for_app_cmd() - core.c: mmc_start_request() I am a bit torn

[2.6 patch] drivers/mmc/core/: make 4 functions static

2007-07-12 Thread Adrian Bunk
This patch makes the following needlessly global functions static: - sd_ops.c: mmc_app_cmd() - sd_ops.c: mmc_wait_for_app_cmd() - core.c: __mmc_release_bus() - core.c: mmc_start_request() Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/mmc/core/core.c | 49

[2.6 patch] drivers/mmc/core/: make 4 functions static

2007-07-12 Thread Adrian Bunk
This patch makes the following needlessly global functions static: - sd_ops.c: mmc_app_cmd() - sd_ops.c: mmc_wait_for_app_cmd() - core.c: __mmc_release_bus() - core.c: mmc_start_request() Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/mmc/core/core.c | 49