Re: [2.6 patch] drivers/net/wireless/libertas/fw.c: fix use-before-check

2007-05-18 Thread Eugene Teo
Hi John, John W. Linville wrote: > On Sat, May 19, 2007 at 01:06:49AM +0800, Eugene Teo wrote: >> NULL checks should be performed before the dereference. >> >> Spotted by the Coverity checker. >> >> Signed-off-by: Eugene Teo <[EMAIL PROTECTED]> > > This does not apply against 2.6.22-rc1. Please

Re: [2.6 patch] drivers/net/wireless/libertas/fw.c: fix use-before-check

2007-05-18 Thread John W. Linville
On Sat, May 19, 2007 at 01:06:49AM +0800, Eugene Teo wrote: > NULL checks should be performed before the dereference. > > Spotted by the Coverity checker. > > Signed-off-by: Eugene Teo <[EMAIL PROTECTED]> This does not apply against 2.6.22-rc1. Please rediff and repost. Thanks, John -- John

Re: [2.6 patch] drivers/net/wireless/libertas/fw.c: fix use-before-check

2007-05-18 Thread John W. Linville
This should be sent to linux-wireless (and CC'ed to me) as well... On Sat, May 19, 2007 at 01:06:49AM +0800, Eugene Teo wrote: > NULL checks should be performed before the dereference. > > Spotted by the Coverity checker. > > Signed-off-by: Eugene Teo <[EMAIL PROTECTED]> > > diff --git

[2.6 patch] drivers/net/wireless/libertas/fw.c: fix use-before-check

2007-05-18 Thread Eugene Teo
NULL checks should be performed before the dereference. Spotted by the Coverity checker. Signed-off-by: Eugene Teo <[EMAIL PROTECTED]> diff --git a/drivers/net/wireless/libertas/fw.c b/drivers/net/wireless/libertas/fw.c index 441123c..5c63c9b 100644 --- a/drivers/net/wireless/libertas/fw.c +++

[2.6 patch] drivers/net/wireless/libertas/fw.c: fix use-before-check

2007-05-18 Thread Eugene Teo
NULL checks should be performed before the dereference. Spotted by the Coverity checker. Signed-off-by: Eugene Teo [EMAIL PROTECTED] diff --git a/drivers/net/wireless/libertas/fw.c b/drivers/net/wireless/libertas/fw.c index 441123c..5c63c9b 100644 --- a/drivers/net/wireless/libertas/fw.c +++

Re: [2.6 patch] drivers/net/wireless/libertas/fw.c: fix use-before-check

2007-05-18 Thread John W. Linville
This should be sent to linux-wireless (and CC'ed to me) as well... On Sat, May 19, 2007 at 01:06:49AM +0800, Eugene Teo wrote: NULL checks should be performed before the dereference. Spotted by the Coverity checker. Signed-off-by: Eugene Teo [EMAIL PROTECTED] diff --git

Re: [2.6 patch] drivers/net/wireless/libertas/fw.c: fix use-before-check

2007-05-18 Thread John W. Linville
On Sat, May 19, 2007 at 01:06:49AM +0800, Eugene Teo wrote: NULL checks should be performed before the dereference. Spotted by the Coverity checker. Signed-off-by: Eugene Teo [EMAIL PROTECTED] This does not apply against 2.6.22-rc1. Please rediff and repost. Thanks, John -- John W.

Re: [2.6 patch] drivers/net/wireless/libertas/fw.c: fix use-before-check

2007-05-18 Thread Eugene Teo
Hi John, John W. Linville wrote: On Sat, May 19, 2007 at 01:06:49AM +0800, Eugene Teo wrote: NULL checks should be performed before the dereference. Spotted by the Coverity checker. Signed-off-by: Eugene Teo [EMAIL PROTECTED] This does not apply against 2.6.22-rc1. Please rediff and