Re: [2.6 patch] fs/jbd/: possible cleanups

2005-07-12 Thread Andreas Dilger
On Jul 13, 2005 00:43 +0200, Adrian Bunk wrote: > On Tue, Jul 12, 2005 at 04:32:44PM -0600, Andreas Dilger wrote: > > I don't mind removing this function, but it shouldn't be put inside #ifdef > > JBD_DEBUG, as that would remove the check from the compiler-parsed code > > and defeat the purpose

Re: [2.6 patch] fs/jbd/: possible cleanups

2005-07-12 Thread Adrian Bunk
On Tue, Jul 12, 2005 at 04:32:44PM -0600, Andreas Dilger wrote: > On Jul 12, 2005 22:27 +0200, Adrian Bunk wrote: >... > > - journal.c: remove the unused global function __journal_internal_check > > and move the check to journal_init > > I don't mind removing this function, but it

Re: [2.6 patch] fs/jbd/: possible cleanups

2005-07-12 Thread Andreas Dilger
On Jul 12, 2005 22:27 +0200, Adrian Bunk wrote: > - make needlessly global functions static I had previously commented on this patch: > - journal.c: remove the unused global function __journal_internal_check > and move the check to journal_init I don't mind removing this function,

[2.6 patch] fs/jbd/: possible cleanups

2005-07-12 Thread Adrian Bunk
This patch contains the following possible cleanups: - make needlessly global functions static - journal.c: remove the unused global function __journal_internal_check and move the check to journal_init - remove the following write-only global variable: - journal.c: current_journal -

Re: [2.6 patch] fs/jbd/: possible cleanups

2005-07-12 Thread Andreas Dilger
On Jul 12, 2005 22:27 +0200, Adrian Bunk wrote: - make needlessly global functions static I had previously commented on this patch: - journal.c: remove the unused global function __journal_internal_check and move the check to journal_init I don't mind removing this function,

Re: [2.6 patch] fs/jbd/: possible cleanups

2005-07-12 Thread Adrian Bunk
On Tue, Jul 12, 2005 at 04:32:44PM -0600, Andreas Dilger wrote: On Jul 12, 2005 22:27 +0200, Adrian Bunk wrote: ... - journal.c: remove the unused global function __journal_internal_check and move the check to journal_init I don't mind removing this function, but it shouldn't

Re: [2.6 patch] fs/jbd/: possible cleanups

2005-07-12 Thread Andreas Dilger
On Jul 13, 2005 00:43 +0200, Adrian Bunk wrote: On Tue, Jul 12, 2005 at 04:32:44PM -0600, Andreas Dilger wrote: I don't mind removing this function, but it shouldn't be put inside #ifdef JBD_DEBUG, as that would remove the check from the compiler-parsed code and defeat the purpose of the

[2.6 patch] fs/jbd/: possible cleanups

2005-07-12 Thread Adrian Bunk
This patch contains the following possible cleanups: - make needlessly global functions static - journal.c: remove the unused global function __journal_internal_check and move the check to journal_init - remove the following write-only global variable: - journal.c: current_journal -

[2.6 patch] fs/jbd/: possible cleanups

2005-04-23 Thread Adrian Bunk
This patch contains the following possible cleanups: - make needlessly global functions static - #if 0 the following unused global functions: - journal.c: __journal_internal_check - journal.c: journal_ack_err - remove the following write-only global variable: - journal.c: current_journal -

[2.6 patch] fs/jbd/: possible cleanups

2005-04-23 Thread Adrian Bunk
This patch contains the following possible cleanups: - make needlessly global functions static - #if 0 the following unused global functions: - journal.c: __journal_internal_check - journal.c: journal_ack_err - remove the following write-only global variable: - journal.c: current_journal -