Re: [2.6 patch] mm/vmstat.c: possible cleanups

2007-07-06 Thread Christoph Lameter
On Fri, 6 Jul 2007, Adrian Bunk wrote: > > Hmmm... This may be needed by the cpu idle code to update the vm stats > > before going idle. > > Since 1 year it's making the kernel image larger without having a single > user. > > And if it will one day get a user, removing the #if 0 will be trivia

Re: [2.6 patch] mm/vmstat.c: possible cleanups

2007-07-06 Thread Adrian Bunk
On Fri, Jul 06, 2007 at 10:49:02AM -0700, Christoph Lameter wrote: > On Fri, 6 Jul 2007, Adrian Bunk wrote: > > > This patch contains the following possible cleanups: > > - make the needlessly global setup_vmstat() static > > Ok. > > > - #if 0 the unused refresh_vm_stats() > > Hmmm... This may

Re: [2.6 patch] mm/vmstat.c: possible cleanups

2007-07-06 Thread Christoph Lameter
On Fri, 6 Jul 2007, Adrian Bunk wrote: > This patch contains the following possible cleanups: > - make the needlessly global setup_vmstat() static Ok. > - #if 0 the unused refresh_vm_stats() Hmmm... This may be needed by the cpu idle code to update the vm stats before going idle. - To unsubscr

[2.6 patch] mm/vmstat.c: possible cleanups

2007-07-05 Thread Adrian Bunk
This patch contains the following possible cleanups: - make the needlessly global setup_vmstat() static - #if 0 the unused refresh_vm_stats() Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- mm/vmstat.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) --- linux-2.6.22-rc6-mm1/mm