Re: [2.6 patch] remove the config option for the cs5530a_warm_reset() quirk

Adrian Bunk wrote: > I have no strong opinion regarding this - if it's agreed upon that it's > unlikely it will ever grow, I can also send an additional patch > simplifying it. I haven't got any response from the original person who submitted this patch. It isn't clear to me whether this is a

Re: [2.6 patch] remove the config option for the cs5530a_warm_reset() quirk

On Sat, Mar 31, 2007 at 02:05:23PM -0700, Jeremy Fitzhardinge wrote: > Adrian Bunk wrote: > > Instead of cleaning up this mess, please replace this patch with the > > patch below. > > > > Yeah, I considered that patch as a placeholder; I'd been wondering if it > can be completely removed. >

Re: [2.6 patch] remove the config option for the cs5530a_warm_reset() quirk

Adrian Bunk wrote: > Instead of cleaning up this mess, please replace this patch with the > patch below. > Yeah, I considered that patch as a placeholder; I'd been wondering if it can be completely removed. But this patch looks fine, though I'd go further - the lookup table of pci ids is

[2.6 patch] remove the config option for the cs5530a_warm_reset() quirk

On Fri, Mar 30, 2007 at 01:05:59AM -0700, Andrew Morton wrote: >... > Changes since 2.6.21-rc5-mm2: >... > +x86_64-mm-clean-up-mach_reboot_fixups.patch >... > A few x86 updates >... OMG - I'll never understand how someone could initially start doing this hiding of a small fixup behind a config

[2.6 patch] remove the config option for the cs5530a_warm_reset() quirk

On Fri, Mar 30, 2007 at 01:05:59AM -0700, Andrew Morton wrote: ... Changes since 2.6.21-rc5-mm2: ... +x86_64-mm-clean-up-mach_reboot_fixups.patch ... A few x86 updates ... OMG - I'll never understand how someone could initially start doing this hiding of a small fixup behind a config option.

Re: [2.6 patch] remove the config option for the cs5530a_warm_reset() quirk

Adrian Bunk wrote: Instead of cleaning up this mess, please replace this patch with the patch below. Yeah, I considered that patch as a placeholder; I'd been wondering if it can be completely removed. But this patch looks fine, though I'd go further - the lookup table of pci ids is

Re: [2.6 patch] remove the config option for the cs5530a_warm_reset() quirk

On Sat, Mar 31, 2007 at 02:05:23PM -0700, Jeremy Fitzhardinge wrote: Adrian Bunk wrote: Instead of cleaning up this mess, please replace this patch with the patch below. Yeah, I considered that patch as a placeholder; I'd been wondering if it can be completely removed. But this

Re: [2.6 patch] remove the config option for the cs5530a_warm_reset() quirk

Adrian Bunk wrote: I have no strong opinion regarding this - if it's agreed upon that it's unlikely it will ever grow, I can also send an additional patch simplifying it. I haven't got any response from the original person who submitted this patch. It isn't clear to me whether this is a fix