Re: [2.6 patch] security/selinux/netlabel.c: fix double free

2008-01-28 Thread Paul Moore
On Monday 28 January 2008 5:35:40 pm Adrian Bunk wrote: > On Mon, Jan 28, 2008 at 05:23:46PM -0500, Paul Moore wrote: > > Thanks for finding this mistake, however, I'd rather see it fixed > > by removing the netlbl_secattr_destroy() call in > > security_netlbl_sid_to_secattr() as it really

Re: [2.6 patch] security/selinux/netlabel.c: fix double free

2008-01-28 Thread Adrian Bunk
On Mon, Jan 28, 2008 at 05:23:46PM -0500, Paul Moore wrote: > On Monday 28 January 2008 5:09:38 pm Adrian Bunk wrote: > > This patch fixes a double free (security_netlbl_sid_to_secattr() > > already calls netlbl_secattr_destroy() when it returns !0) introduced > > by commit

Re: [2.6 patch] security/selinux/netlabel.c: fix double free

2008-01-28 Thread Paul Moore
On Monday 28 January 2008 5:09:38 pm Adrian Bunk wrote: > This patch fixes a double free (security_netlbl_sid_to_secattr() > already calls netlbl_secattr_destroy() when it returns !0) introduced > by commit 45c950e0f839fded922ebc0bfd59b1081cc71b70 and spotted by the > Coverity checker. Hi Adrian,

[2.6 patch] security/selinux/netlabel.c: fix double free

2008-01-28 Thread Adrian Bunk
This patch fixes a double free (security_netlbl_sid_to_secattr() already calls netlbl_secattr_destroy() when it returns !0) introduced by commit 45c950e0f839fded922ebc0bfd59b1081cc71b70 and spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- ---

Re: [2.6 patch] security/selinux/netlabel.c: fix double free

2008-01-28 Thread Paul Moore
On Monday 28 January 2008 5:09:38 pm Adrian Bunk wrote: This patch fixes a double free (security_netlbl_sid_to_secattr() already calls netlbl_secattr_destroy() when it returns !0) introduced by commit 45c950e0f839fded922ebc0bfd59b1081cc71b70 and spotted by the Coverity checker. Hi Adrian,

Re: [2.6 patch] security/selinux/netlabel.c: fix double free

2008-01-28 Thread Adrian Bunk
On Mon, Jan 28, 2008 at 05:23:46PM -0500, Paul Moore wrote: On Monday 28 January 2008 5:09:38 pm Adrian Bunk wrote: This patch fixes a double free (security_netlbl_sid_to_secattr() already calls netlbl_secattr_destroy() when it returns !0) introduced by commit

Re: [2.6 patch] security/selinux/netlabel.c: fix double free

2008-01-28 Thread Paul Moore
On Monday 28 January 2008 5:35:40 pm Adrian Bunk wrote: On Mon, Jan 28, 2008 at 05:23:46PM -0500, Paul Moore wrote: Thanks for finding this mistake, however, I'd rather see it fixed by removing the netlbl_secattr_destroy() call in security_netlbl_sid_to_secattr() as it really shouldn't be

[2.6 patch] security/selinux/netlabel.c: fix double free

2008-01-28 Thread Adrian Bunk
This patch fixes a double free (security_netlbl_sid_to_secattr() already calls netlbl_secattr_destroy() when it returns !0) introduced by commit 45c950e0f839fded922ebc0bfd59b1081cc71b70 and spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- ---