Re: [2.6 patch] unexport do_settimeofday

On Fri, Feb 25, 2005 at 12:28:04AM -0800, Andrew Morton wrote: > > for _set_ time of day? I really can't imagine anyone messing with that. > > _get_... sure. but set??? > > Sure. But there must have been a reason to export it in the first place. NO. Speaking from experience there's tons of tota

Re: [2.6 patch] unexport do_settimeofday

On Sat, Feb 26, 2005 at 11:01:24AM +0100, Arjan van de Ven wrote: > On Fri, 2005-02-25 at 15:20 -0800, Andrew Morton wrote: > > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > > You get a false positive if the file containing the symbol is itself a > > > module. > > > > I don't understand what

Re: [2.6 patch] unexport do_settimeofday

On Fri, Feb 25, 2005 at 03:20:09PM -0800, Andrew Morton wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > +#ifdef MODULE > > > +#define __deprecated_in_modules __deprecated > > > +#else > > > +#define __deprecated_in_modules /* OK in non-modular code */ > > > +#endif > > > + > > >... > > >

Re: [2.6 patch] unexport do_settimeofday

On Fri, 2005-02-25 at 15:20 -0800, Andrew Morton wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > +#ifdef MODULE > > > +#define __deprecated_in_modules __deprecated > > > +#else > > > +#define __deprecated_in_modules /* OK in non-modular code */ > > > +#endif > > > + > > >... > > > > Look

Re: [2.6 patch] unexport do_settimeofday

Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > +#ifdef MODULE > > +#define __deprecated_in_modules __deprecated > > +#else > > +#define __deprecated_in_modules /* OK in non-modular code */ > > +#endif > > + > >... > > Looks good. > > > One more question: > > You get a false positive if the file c

Re: [2.6 patch] unexport do_settimeofday

On Fri, Feb 25, 2005 at 01:55:04PM -0800, Andrew Morton wrote: >... > --- 25/include/linux/compiler.h~a 2005-02-25 13:53:32.0 -0800 > +++ 25-akpm/include/linux/compiler.h 2005-02-25 13:54:45.0 -0800 > @@ -86,6 +86,12 @@ extern void __chk_io_ptr(void __iomem *) > # define __dep

Re: [2.6 patch] unexport do_settimeofday

Adrian Bunk <[EMAIL PROTECTED]> wrote: > > On Thu, Feb 24, 2005 at 09:24:48PM -0800, Andrew Morton wrote: > > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > > > > > I haven't found any possible modular usage of do_settimeofday in the > > > kernel. > > > > Please, > > > > - Add deprecated_if

Re: [2.6 patch] unexport do_settimeofday

On Thu, Feb 24, 2005 at 09:24:48PM -0800, Andrew Morton wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > > I haven't found any possible modular usage of do_settimeofday in the > > kernel. > > Please, > > - Add deprecated_if_module >... What's the correct header file for __deprecated

Re: [2.6 patch] unexport do_settimeofday

Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > actually exports cause kernels to be bigger. Some of these exports > aren't even used in the kernel entirely, others cause the kernel to be > bigger just by being non-static and having the symbol structures there. Yup. IOW, this problem is so vanish

Re: [2.6 patch] unexport do_settimeofday

On Fri, 2005-02-25 at 02:26 -0700, Andreas Dilger wrote: > On Feb 25, 2005 09:47 +0100, Bartlomiej Zolnierkiewicz wrote: > > On Fri, 25 Feb 2005 00:28:04 -0800, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > I haven't found any possible modular usage

Re: [2.6 patch] unexport do_settimeofday

On Feb 25, 2005 09:47 +0100, Bartlomiej Zolnierkiewicz wrote: > On Fri, 25 Feb 2005 00:28:04 -0800, Andrew Morton <[EMAIL PROTECTED]> wrote: > > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > I haven't found any possible modular usage of do_settimeofday in the > > > kernel. > > > > Sure. But the

Re: [2.6 patch] unexport do_settimeofday

On Fri, 25 Feb 2005 00:28:04 -0800, Andrew Morton <[EMAIL PROTECTED]> wrote: > Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > > On Thu, 2005-02-24 at 21:24 -0800, Andrew Morton wrote: > > > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > > > > > > > > I haven't found any possible modular usage

Re: [2.6 patch] unexport do_settimeofday

Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > On Thu, 2005-02-24 at 21:24 -0800, Andrew Morton wrote: > > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > > > > > I haven't found any possible modular usage of do_settimeofday in the > > > kernel. > > > > Please, > > > > - Add deprecated_if_m

Re: [2.6 patch] unexport do_settimeofday

On Thu, 2005-02-24 at 21:24 -0800, Andrew Morton wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > > I haven't found any possible modular usage of do_settimeofday in the > > kernel. > > Please, > > - Add deprecated_if_module > > - Use it for do_settimeofday() > > - Add do_settimeofd

Re: [2.6 patch] unexport do_settimeofday

Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > I haven't found any possible modular usage of do_settimeofday in the > kernel. Please, - Add deprecated_if_module - Use it for do_settimeofday() - Add do_settimeofday to Documentation/feature-removal-schedule.txt - To unsubscribe from this list:

[2.6 patch] unexport do_settimeofday

I haven't found any possible modular usage of do_settimeofday in the kernel. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 20 Jan 2005 arch/alpha/kernel/time.c |2 -- arch/arm/kernel/time.c |2 -- arch/arm26/kernel/time.c |2 --

[RFC: 2.6 patch] unexport do_settimeofday

[ same patch with corrected subject ] Is the patch below correct? Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- arch/alpha/kernel/time.c |2 -- arch/arm/kernel/time.c |2 -- arch/arm26/kernel/time.c |2 -- arch/cris/kernel/time.c |2 -- arch/h8300/kern