Re: [discuss] [2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT

2007-01-10 Thread Jan Beulich
>>> Andrew Morton <[EMAIL PROTECTED]> 09.01.07 23:04 >>> >On Tue, 9 Jan 2007 12:01:21 +0100 >Andi Kleen <[EMAIL PROTECTED]> wrote: > >> On Tuesday 09 January 2007 03:55, Adrian Bunk wrote: >> > RESTORE_CONTEXT lost a newline in >> > commit 658fdbef66e5e9be79b457edc2cbbb3add840aa9: >> > http://www.

Re: [2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT

2007-01-09 Thread Andi Kleen
> > In other words we'll leave it in its present buggy form so that it will > explode next time someone tries to use it for something new, rather than a) It shouldn't be used for anything new. It's really a private macro in the context switch code, nothing that any other code is supposed to use.

Re: [2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT

2007-01-09 Thread Andrew Morton
On Tue, 9 Jan 2007 23:43:00 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > > But the patch is a bugfix. Without it, you cannot do > > > > RESTORE_CONTEXT \ > > .globl ... \ > > > > Was the addition of this restriction to RESTORE_CONTEXT deliberate, or > > mistaken? > > REST

Re: [2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT

2007-01-09 Thread Andi Kleen
> > But the patch is a bugfix. Without it, you cannot do > > RESTORE_CONTEXT \ > .globl ... \ > > Was the addition of this restriction to RESTORE_CONTEXT deliberate, or > mistaken? RESTORE_CONTEXT is a private macro and I don't see why we should support out of tree usages for

Re: [2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT

2007-01-09 Thread Andrew Morton
On Tue, 9 Jan 2007 12:01:21 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote: > On Tuesday 09 January 2007 03:55, Adrian Bunk wrote: > > RESTORE_CONTEXT lost a newline in > > commit 658fdbef66e5e9be79b457edc2cbbb3add840aa9: > > http://www.mail-archive.com/kgdb-bugreport@lists.sourceforge.net/msg00559.h

Re: [2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT

2007-01-09 Thread Andi Kleen
On Tuesday 09 January 2007 03:55, Adrian Bunk wrote: > RESTORE_CONTEXT lost a newline in > commit 658fdbef66e5e9be79b457edc2cbbb3add840aa9: > http://www.mail-archive.com/kgdb-bugreport@lists.sourceforge.net/msg00559.html I don't think we should add such changes for external patchkits. In general

[2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT

2007-01-08 Thread Adrian Bunk
RESTORE_CONTEXT lost a newline in commit 658fdbef66e5e9be79b457edc2cbbb3add840aa9: http://www.mail-archive.com/kgdb-bugreport@lists.sourceforge.net/msg00559.html Reported by Steven M. Christey. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- a/include/asm-x86_64/system.h +++ b/include/asm-x8