Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Adrian Bunk
On Wed, Mar 02, 2005 at 01:18:17PM -0800, Andrew Morton wrote: > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > > > Thing is, CRYPTO_AES on only selectable on x86. > > > > You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig, > > the dependencies are a bit weird: > > > > config

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Adrian Bunk
On Wed, Mar 02, 2005 at 05:41:50PM -0500, Jeff Garzik wrote: > Andrew Morton wrote: > >Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > >>>Thing is, CRYPTO_AES on only selectable on x86. > >> > >>You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig, > >>the dependencies are a bit weird

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Jeff Garzik
Adrian Bunk wrote: On Wed, Mar 02, 2005 at 05:41:50PM -0500, Jeff Garzik wrote: Andrew Morton wrote: Jeff Garzik <[EMAIL PROTECTED]> wrote: Thing is, CRYPTO_AES on only selectable on x86. You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig, the dependencies are a bit weird: conf

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Jeff Garzik
Andrew Morton wrote: Jeff Garzik <[EMAIL PROTECTED]> wrote: Thing is, CRYPTO_AES on only selectable on x86. You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig, the dependencies are a bit weird: config CRYPTO_AES tristate "AES cipher algorithms" depends on CRYPT

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Andrew Morton
Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > Would be better to just do: > > > > config CRYPTO_AES > > select CRYPTO_AES_586 if (X86 && !X86_64) > > select CRYPTO_AES_OTHER if !(X86 && !X86_64) > > > > and hide CRYPTO_AES_586 and CRYPTO_AES_OTHER from the outside world. > > > http://w

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Adrian Bunk
On Wed, Mar 02, 2005 at 02:12:04PM -0500, Jeff Garzik wrote: > Adrian Bunk wrote: > >On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote: > > > >>Adrian Bunk wrote: > >> > >>>+ select CRYPTO > >>> select CRYPTO_AES > >>> ---help--- > >>> Include software based cipher suites in suppor

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Andrew Morton
Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > Thing is, CRYPTO_AES on only selectable on x86. > > You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig, > the dependencies are a bit weird: > > config CRYPTO_AES > tristate "AES cipher algorithms" > depends on

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Jeff Garzik
Andrew Morton wrote: Jeff Garzik <[EMAIL PROTECTED]> wrote: Adrian Bunk wrote: On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote: Adrian Bunk wrote: + select CRYPTO select CRYPTO_AES ---help--- Include software based cipher suites in support of IEEE 802.11i (aka TGi, WPA, WPA2, WPA

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Andrew Morton
Jeff Garzik <[EMAIL PROTECTED]> wrote: > > Adrian Bunk wrote: > > On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote: > > > >>Adrian Bunk wrote: > >> > >>>+ select CRYPTO > >>> select CRYPTO_AES > >>> ---help--- > >>> Include software based cipher suites in support of IEEE 802.11i

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Jeff Garzik
Adrian Bunk wrote: On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote: Adrian Bunk wrote: + select CRYPTO select CRYPTO_AES ---help--- Include software based cipher suites in support of IEEE 802.11i (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled networks. @@ -54,10 +5

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Adrian Bunk
On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote: > Adrian Bunk wrote: > >+select CRYPTO > > select CRYPTO_AES > > ---help--- > > Include software based cipher suites in support of IEEE 802.11i > > (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled > >

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-01 Thread Jeff Garzik
Adrian Bunk wrote: + select CRYPTO select CRYPTO_AES ---help--- Include software based cipher suites in support of IEEE 802.11i (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled networks. @@ -54,10 +55,11 @@ "ieee80211_crypt_ccmp". config IEEE80211_CRYPT_TKIP tristate

[2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-02-26 Thread Adrian Bunk
On Wed, Feb 23, 2005 at 01:42:33AM -0800, Andrew Morton wrote: >... > Changes since 2.6.11-rc3-mm1: >... > bk-netdev.patch >... Some of the options that needlessly wrote in their help text which options they do selct (patch already sent) didn't obey the most important rule of select If you