Dmitry, responding to Pawe__:
> > IMHO each header (e.g. psmouse.h) should include headers for types it uses.
> >
>
> Hmm, I thought it was other way around
I tend to agree with Pawe__ here.
There are two extremes here that I would avoid. Do not try to include
in source files every header
On Sunday 13 March 2005 11:54, PaweÅ Sikora wrote:
> On Sunday 13 of March 2005 17:48, Dmitry Torokhov wrote:
> > On Sunday 13 March 2005 08:20, PaweÅ Sikora wrote:
> > > Hi,
> > >
> > > Attched patch fixes gcc error:
> > > `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete
>
On Sunday 13 of March 2005 17:48, Dmitry Torokhov wrote:
> On Sunday 13 March 2005 08:20, PaweÅ Sikora wrote:
> > Hi,
> >
> > Attched patch fixes gcc error:
> > `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete
> > type`
>
> What file fails compilation?
custom patch for
On Sunday 13 March 2005 08:20, PaweÅ Sikora wrote:
> Hi,
>
> Attched patch fixes gcc error:
> `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete type`
>
What file fails compilation? As far as I can see all users of psmouse.h do
#include first.
--
Dmitry
-
To unsubscribe
Hi,
Attched patch fixes gcc error:
`drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete type`
Please apply.
--
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */
#define say(x) lie(x)
drivers/input/mouse/psmouse.h:40:
Hi,
Attched patch fixes gcc error:
`drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete type`
Please apply.
--
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */
#define say(x) lie(x)
drivers/input/mouse/psmouse.h:40:
On Sunday 13 March 2005 08:20, Pawe Sikora wrote:
Hi,
Attched patch fixes gcc error:
`drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete type`
What file fails compilation? As far as I can see all users of psmouse.h do
#include linux/libps2.h first.
--
Dmitry
-
To
On Sunday 13 of March 2005 17:48, Dmitry Torokhov wrote:
On Sunday 13 March 2005 08:20, Pawe Sikora wrote:
Hi,
Attched patch fixes gcc error:
`drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete
type`
What file fails compilation?
custom patch for trackpoint device.
On Sunday 13 March 2005 11:54, Pawe Sikora wrote:
On Sunday 13 of March 2005 17:48, Dmitry Torokhov wrote:
On Sunday 13 March 2005 08:20, Pawe Sikora wrote:
Hi,
Attched patch fixes gcc error:
`drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete
type`
What
Dmitry, responding to Pawe__:
IMHO each header (e.g. psmouse.h) should include headers for types it uses.
Hmm, I thought it was other way around
I tend to agree with Pawe__ here.
There are two extremes here that I would avoid. Do not try to include
in source files every header that is
10 matches
Mail list logo