Re: [2.6.11.3] gcc4 / psmouse.h - compilation fix.

2005-03-13 Thread Paul Jackson
Dmitry, responding to Pawe__: > > IMHO each header (e.g. psmouse.h) should include headers for types it uses. > > > > Hmm, I thought it was other way around I tend to agree with Pawe__ here. There are two extremes here that I would avoid. Do not try to include in source files every header

Re: [2.6.11.3] gcc4 / psmouse.h - compilation fix.

2005-03-13 Thread Dmitry Torokhov
On Sunday 13 March 2005 11:54, PaweÅ Sikora wrote: > On Sunday 13 of March 2005 17:48, Dmitry Torokhov wrote: > > On Sunday 13 March 2005 08:20, PaweÅ Sikora wrote: > > > Hi, > > > > > > Attched patch fixes gcc error: > > > `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete >

Re: [2.6.11.3] gcc4 / psmouse.h - compilation fix.

2005-03-13 Thread PaweÅ Sikora
On Sunday 13 of March 2005 17:48, Dmitry Torokhov wrote: > On Sunday 13 March 2005 08:20, PaweÅ Sikora wrote: > > Hi, > > > > Attched patch fixes gcc error: > > `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete > > type` > > What file fails compilation? custom patch for

Re: [2.6.11.3] gcc4 / psmouse.h - compilation fix.

2005-03-13 Thread Dmitry Torokhov
On Sunday 13 March 2005 08:20, PaweÅ Sikora wrote: > Hi, > > Attched patch fixes gcc error: > `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete type` > What file fails compilation? As far as I can see all users of psmouse.h do #include first. -- Dmitry - To unsubscribe

[2.6.11.3] gcc4 / psmouse.h - compilation fix.

2005-03-13 Thread PaweÅ Sikora
Hi, Attched patch fixes gcc error: `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete type` Please apply. -- /* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */ #define say(x) lie(x) drivers/input/mouse/psmouse.h:40:

[2.6.11.3] gcc4 / psmouse.h - compilation fix.

2005-03-13 Thread Pawe Sikora
Hi, Attched patch fixes gcc error: `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete type` Please apply. -- /* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */ #define say(x) lie(x) drivers/input/mouse/psmouse.h:40:

Re: [2.6.11.3] gcc4 / psmouse.h - compilation fix.

2005-03-13 Thread Dmitry Torokhov
On Sunday 13 March 2005 08:20, Pawe Sikora wrote: Hi, Attched patch fixes gcc error: `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete type` What file fails compilation? As far as I can see all users of psmouse.h do #include linux/libps2.h first. -- Dmitry - To

Re: [2.6.11.3] gcc4 / psmouse.h - compilation fix.

2005-03-13 Thread Pawe Sikora
On Sunday 13 of March 2005 17:48, Dmitry Torokhov wrote: On Sunday 13 March 2005 08:20, Pawe Sikora wrote: Hi, Attched patch fixes gcc error: `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete type` What file fails compilation? custom patch for trackpoint device.

Re: [2.6.11.3] gcc4 / psmouse.h - compilation fix.

2005-03-13 Thread Dmitry Torokhov
On Sunday 13 March 2005 11:54, Pawe Sikora wrote: On Sunday 13 of March 2005 17:48, Dmitry Torokhov wrote: On Sunday 13 March 2005 08:20, Pawe Sikora wrote: Hi, Attched patch fixes gcc error: `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete type` What

Re: [2.6.11.3] gcc4 / psmouse.h - compilation fix.

2005-03-13 Thread Paul Jackson
Dmitry, responding to Pawe__: IMHO each header (e.g. psmouse.h) should include headers for types it uses. Hmm, I thought it was other way around I tend to agree with Pawe__ here. There are two extremes here that I would avoid. Do not try to include in source files every header that is