Re: [3/3] Coccinelle: pci_free_consistent: Extend when constraints for two SmPL ellipses

2019-05-15 Thread Markus Elfring
> 2, If you really plan to add the two restrictions above, > you may need to consider this further than simply adding a "when != id = > (T2)(e)" statement. > I constructed the flollowing code snippet as a test case: … > Using the original SmPL, we can find a bug. > But with your modified SmPL,

Re: [3/3] Coccinelle: pci_free_consistent: Extend when constraints for two SmPL ellipses

2019-05-15 Thread Markus Elfring
Am 15.05.19 um 12:19 schrieb Julia Lawall: > > > On Wed, 15 May 2019, Markus Elfring wrote: > > On the other hand, I do care about causing false negatives. Do you find the missing warning after the addition of such an exclusion specification interesting? >>> >>> I already

Re: [3/3] Coccinelle: pci_free_consistent: Extend when constraints for two SmPL ellipses

2019-05-15 Thread Julia Lawall
On Wed, 15 May 2019, Markus Elfring wrote: > >>> On the other hand, I do care about causing false negatives. > >> > >> Do you find the missing warning after the addition of such an exclusion > >> specification interesting? > > > > I already suggested how to improve the code. > > I find that the