Re: [5/9] [TUN] Fix check for underflow

2005-03-16 Thread Chris Wright
* Patrick McHardy ([EMAIL PROTECTED]) wrote: > Chris Wright wrote: > >-stable review patch. If anyone has any objections, please let us know. > > > > I agree to both patches and additionally propose this one. > It fixes a crash when reading /proc/net/route (netstat -rn) > while routes are

Re: [5/9] [TUN] Fix check for underflow

2005-03-16 Thread Patrick McHardy
Chris Wright wrote: -stable review patch. If anyone has any objections, please let us know. I agree to both patches and additionally propose this one. It fixes a crash when reading /proc/net/route (netstat -rn) while routes are changed. I've seen two bugreports of users beeing hit by this bug,

[5/9] [TUN] Fix check for underflow

2005-03-16 Thread Chris Wright
-stable review patch. If anyone has any objections, please let us know. From: Stephen Hemminger <[EMAIL PROTECTED]> http://bugme.osdl.org/show_bug.cgi?id=4279 Summary: When I try to start vpnc the net/core/skbuff.c:91 crash This check is wrong, gcc optimizes it away: if

[5/9] [TUN] Fix check for underflow

2005-03-16 Thread Chris Wright
-stable review patch. If anyone has any objections, please let us know. From: Stephen Hemminger [EMAIL PROTECTED] http://bugme.osdl.org/show_bug.cgi?id=4279 Summary: When I try to start vpnc the net/core/skbuff.c:91 crash This check is wrong, gcc optimizes it away: if

Re: [5/9] [TUN] Fix check for underflow

2005-03-16 Thread Patrick McHardy
Chris Wright wrote: -stable review patch. If anyone has any objections, please let us know. I agree to both patches and additionally propose this one. It fixes a crash when reading /proc/net/route (netstat -rn) while routes are changed. I've seen two bugreports of users beeing hit by this bug,

Re: [5/9] [TUN] Fix check for underflow

2005-03-16 Thread Chris Wright
* Patrick McHardy ([EMAIL PROTECTED]) wrote: Chris Wright wrote: -stable review patch. If anyone has any objections, please let us know. I agree to both patches and additionally propose this one. It fixes a crash when reading /proc/net/route (netstat -rn) while routes are changed. I've