Re: [5.2 regression] copy_fpstate_to_sigframe() change causing crash in 32-bit process

2019-06-06 Thread Sebastian Andrzej Siewior
On 2019-06-05 10:32:57 [-0700], Eric Biggers wrote: > As I said, the commit looks broken to me. save_fsave_header() reads from > tsk->thread.fpu.state.fxsave, which due to that commit isn't being updated > with > the latest registers. Am I missing something? Note the comment you deleted: So if

Re: [5.2 regression] copy_fpstate_to_sigframe() change causing crash in 32-bit process

2019-06-05 Thread Eric Biggers
On Wed, Jun 05, 2019 at 04:04:05PM +0200, Sebastian Andrzej Siewior wrote: > On 2019-06-04 11:53:58 [-0700], Eric Biggers wrote: > > On latest Linus' tree I'm getting a crash in a 32-bit Wine process. > > > > I bisected it to the following commit: > > > > commit 39388e80f9b0c3788bfb6efe3054bdce0c

Re: [5.2 regression] copy_fpstate_to_sigframe() change causing crash in 32-bit process

2019-06-05 Thread Sebastian Andrzej Siewior
On 2019-06-04 11:53:58 [-0700], Eric Biggers wrote: > On latest Linus' tree I'm getting a crash in a 32-bit Wine process. > > I bisected it to the following commit: > > commit 39388e80f9b0c3788bfb6efe3054bdce0c3ead45 > Author: Sebastian Andrzej Siewior > Date: Wed Apr 3 18:41:35 2019 +0200 >

[5.2 regression] copy_fpstate_to_sigframe() change causing crash in 32-bit process

2019-06-04 Thread Eric Biggers
On latest Linus' tree I'm getting a crash in a 32-bit Wine process. I bisected it to the following commit: commit 39388e80f9b0c3788bfb6efe3054bdce0c3ead45 Author: Sebastian Andrzej Siewior Date: Wed Apr 3 18:41:35 2019 +0200 x86/fpu: Don't save fxregs for ia32 frames in copy_fpstate_to_si