Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread xiphmont
On 1/26/07, Greg KH <[EMAIL PROTECTED]> wrote: Ok, I'll do it through my trees, but I'll wait for Monty to finish building and testing. /me hands Monty a copy of distcc and ccache :) More like a disk that isn't strangely crippled. (This kernel isn't getting anywhere near the studly machines

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread Greg KH
On Fri, Jan 26, 2007 at 07:25:34PM +0100, Takashi Iwai wrote: > Greg, feel free to pick it up to your tree for pushing. Since this > patch conflicts with the development tree of ALSA mm branch, it'd be > even harder to push from ALSA tree, unfortuantely... > > Of course, it'd be safer after

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread Greg KH
On Fri, Jan 26, 2007 at 01:03:41PM -0500, [EMAIL PROTECTED] wrote: > Before I get to the less focused rant below, I wanted to mention that > the HELP text for 'Create deprecated sysfs files' does not make it > clear that one is opting for old in exclusion of new. Hm, can you think of some better

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread xiphmont
Yes, working on testing all cases here, takes a while, kernel builds are hella long on this machine. Monty - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread Takashi Iwai
At Fri, 26 Jan 2007 10:04:57 -0800, Greg KH wrote: > > On Fri, Jan 26, 2007 at 12:40:31PM +0100, Takashi Iwai wrote: > > At Fri, 26 Jan 2007 05:53:36 -0500, > > [EMAIL PROTECTED] wrote: > > > > > > On 1/25/07, Greg KH <[EMAIL PROTECTED]> wrote: > > > > > > > Is there anything else left to fix?

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread Greg KH
On Fri, Jan 26, 2007 at 12:40:31PM +0100, Takashi Iwai wrote: > At Fri, 26 Jan 2007 05:53:36 -0500, > [EMAIL PROTECTED] wrote: > > > > On 1/25/07, Greg KH <[EMAIL PROTECTED]> wrote: > > > > > Is there anything else left to fix? > > > > Once that testing is done, no. But don't trust the two

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread xiphmont
Before I get to the less focused rant below, I wanted to mention that the HELP text for 'Create deprecated sysfs files' does not make it clear that one is opting for old in exclusion of new. On 1/25/07, Greg KH <[EMAIL PROTECTED]> wrote: There is no such thing as a "stable release update"

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread Takashi Iwai
At Fri, 26 Jan 2007 05:53:36 -0500, [EMAIL PROTECTED] wrote: > > On 1/25/07, Greg KH <[EMAIL PROTECTED]> wrote: > > > Is there anything else left to fix? > > Once that testing is done, no. But don't trust the two patches I sent > yet, I'll resumbit the patch resulting from more thorough

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread xiphmont
On 1/25/07, Greg KH <[EMAIL PROTECTED]> wrote: I want to do just a little more testing here (Takashi reminded me I have a bit more testing of my own to do). Can you give me the 'tree /sys/class/sound' output? Once I verify it's 'all good' (actually, I'm stalling; not in front of the machine

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread xiphmont
On 1/25/07, Greg KH [EMAIL PROTECTED] wrote: I want to do just a little more testing here (Takashi reminded me I have a bit more testing of my own to do). Can you give me the 'tree /sys/class/sound' output? Once I verify it's 'all good' (actually, I'm stalling; not in front of the machine

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread Takashi Iwai
At Fri, 26 Jan 2007 05:53:36 -0500, [EMAIL PROTECTED] wrote: On 1/25/07, Greg KH [EMAIL PROTECTED] wrote: Is there anything else left to fix? Once that testing is done, no. But don't trust the two patches I sent yet, I'll resumbit the patch resulting from more thorough testing in a

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread xiphmont
Before I get to the less focused rant below, I wanted to mention that the HELP text for 'Create deprecated sysfs files' does not make it clear that one is opting for old in exclusion of new. On 1/25/07, Greg KH [EMAIL PROTECTED] wrote: There is no such thing as a stable release update series

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread Greg KH
On Fri, Jan 26, 2007 at 12:40:31PM +0100, Takashi Iwai wrote: At Fri, 26 Jan 2007 05:53:36 -0500, [EMAIL PROTECTED] wrote: On 1/25/07, Greg KH [EMAIL PROTECTED] wrote: Is there anything else left to fix? Once that testing is done, no. But don't trust the two patches I sent

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread Takashi Iwai
At Fri, 26 Jan 2007 10:04:57 -0800, Greg KH wrote: On Fri, Jan 26, 2007 at 12:40:31PM +0100, Takashi Iwai wrote: At Fri, 26 Jan 2007 05:53:36 -0500, [EMAIL PROTECTED] wrote: On 1/25/07, Greg KH [EMAIL PROTECTED] wrote: Is there anything else left to fix? Once that

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread xiphmont
Yes, working on testing all cases here, takes a while, kernel builds are hella long on this machine. Monty - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread Greg KH
On Fri, Jan 26, 2007 at 01:03:41PM -0500, [EMAIL PROTECTED] wrote: Before I get to the less focused rant below, I wanted to mention that the HELP text for 'Create deprecated sysfs files' does not make it clear that one is opting for old in exclusion of new. Hm, can you think of some better

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread Greg KH
On Fri, Jan 26, 2007 at 07:25:34PM +0100, Takashi Iwai wrote: Greg, feel free to pick it up to your tree for pushing. Since this patch conflicts with the development tree of ALSA mm branch, it'd be even harder to push from ALSA tree, unfortuantely... Of course, it'd be safer after

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-26 Thread xiphmont
On 1/26/07, Greg KH [EMAIL PROTECTED] wrote: Ok, I'll do it through my trees, but I'll wait for Monty to finish building and testing. /me hands Monty a copy of distcc and ccache :) More like a disk that isn't strangely crippled. (This kernel isn't getting anywhere near the studly machines

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Greg KH
On Thu, Jan 25, 2007 at 03:40:06PM -0500, [EMAIL PROTECTED] wrote: > >Basically, new distros can disable that option if their userspace can > >handle the new structure of sysfs with the symlinks. Users of older > >distros with newer kernels can enable the option and (hopefully) not > >break

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread xiphmont
Basically, new distros can disable that option if their userspace can handle the new structure of sysfs with the symlinks. Users of older distros with newer kernels can enable the option and (hopefully) not break anything. I would like to register a general objection to a change of this size

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Greg KH
On Thu, Jan 25, 2007 at 01:51:42PM -0500, [EMAIL PROTECTED] wrote: > On 1/25/07, Takashi Iwai <[EMAIL PROTECTED]> wrote: > > >> [This does beg the question: Does the benefit of this complete > >> restructuring in a subminor release of an allegedly stable kernel > >> outweigh the fact that it

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread xiphmont
On 1/25/07, Takashi Iwai <[EMAIL PROTECTED]> wrote: > [This does beg the question: Does the benefit of this complete > restructuring in a subminor release of an allegedly stable kernel > outweigh the fact that it breaks all audio for any user running a > gnome desktop?] Well, that's not me who

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Takashi Iwai
At Thu, 25 Jan 2007 13:34:19 -0500, [EMAIL PROTECTED] wrote: > > On 1/25/07, Takashi Iwai <[EMAIL PROTECTED]> wrote: > > > The problem with your patch is that it breaks the structure newly > > introduced. In the new tree, card* contains the whole belonging > > devices, and each device points to

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread xiphmont
On 1/25/07, Takashi Iwai <[EMAIL PROTECTED]> wrote: The problem with your patch is that it breaks the structure newly introduced. In the new tree, card* contains the whole belonging devices, and each device points to the one in the card object. Passing dev->parent there cuts the relation

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Takashi Iwai
At Thu, 25 Jan 2007 13:07:04 -0500, [EMAIL PROTECTED] wrote: > > On 1/25/07, Takashi Iwai <[EMAIL PROTECTED]> wrote: > > At Thu, 25 Jan 2007 12:30:44 -0500, > > [EMAIL PROTECTED] wrote: > > > > > > > I'm working on this now and will doublecheck just in case my test was > > > > flawed first time.

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread xiphmont
On 1/25/07, Takashi Iwai <[EMAIL PROTECTED]> wrote: At Thu, 25 Jan 2007 12:30:44 -0500, [EMAIL PROTECTED] wrote: > > > I'm working on this now and will doublecheck just in case my test was > > flawed first time. > > Doublechecking indicates my initial test was wrong somehow; both >

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Christopher \"Monty\" Montgomery
Updated version of patch also taking into account feedback from Takashi is attached. I'm going to look at hald now. Monty diff -uprN -X linux-2.6.20-rc5/Documentation/dontdiff linux-2.6.20-rc5/sound/core/sound.c linux-2.6.20-rc5-monty/sound/core/sound.c --- linux-2.6.20-rc5/sound/core/sound.c

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Takashi Iwai
At Thu, 25 Jan 2007 12:30:44 -0500, [EMAIL PROTECTED] wrote: > > > I'm working on this now and will doublecheck just in case my test was > > flawed first time. > > Doublechecking indicates my initial test was wrong somehow; both > card->dev->parent and card->parent passed as arg 2 to the >

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread xiphmont
I'm working on this now and will doublecheck just in case my test was flawed first time. Doublechecking indicates my initial test was wrong somehow; both card->dev->parent and card->parent passed as arg 2 to the device_create call in snd_register_device result in correct device symlinks. Are

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Christopher \"Monty\" Montgomery
> What was there (plugging the old 'dev' arg into the new call's > 'parent' makes no sense) is clearly wrong. It makes sense because the meaning of card->dev was changed, too. Now it points the "card*" object that is the root of all belonging devices. The former card->dev is stored in

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Takashi Iwai
At Thu, 25 Jan 2007 10:57:25 -0500, Christopher "Monty" Montgomery wrote: > > On 1/25/07, Pierre Ossman <[EMAIL PROTECTED]> wrote: > > > There is some option about deprecated sysfs stuff. Perhaps this is the > > cause of your twisted tree. It's off here: > > > > # CONFIG_SYSFS_DEPRECATED is not

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Takashi Iwai
At Thu, 25 Jan 2007 10:57:25 -0500, Christopher Monty Montgomery wrote: On 1/25/07, Pierre Ossman [EMAIL PROTECTED] wrote: There is some option about deprecated sysfs stuff. Perhaps this is the cause of your twisted tree. It's off here: # CONFIG_SYSFS_DEPRECATED is not set It is

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Christopher \Monty\ Montgomery
What was there (plugging the old 'dev' arg into the new call's 'parent' makes no sense) is clearly wrong. It makes sense because the meaning of card-dev was changed, too. Now it points the card* object that is the root of all belonging devices. The former card-dev is stored in card-parent.

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread xiphmont
I'm working on this now and will doublecheck just in case my test was flawed first time. Doublechecking indicates my initial test was wrong somehow; both card-dev-parent and card-parent passed as arg 2 to the device_create call in snd_register_device result in correct device symlinks. Are these

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Takashi Iwai
At Thu, 25 Jan 2007 12:30:44 -0500, [EMAIL PROTECTED] wrote: I'm working on this now and will doublecheck just in case my test was flawed first time. Doublechecking indicates my initial test was wrong somehow; both card-dev-parent and card-parent passed as arg 2 to the device_create

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Christopher \Monty\ Montgomery
Updated version of patch also taking into account feedback from Takashi is attached. I'm going to look at hald now. Monty diff -uprN -X linux-2.6.20-rc5/Documentation/dontdiff linux-2.6.20-rc5/sound/core/sound.c linux-2.6.20-rc5-monty/sound/core/sound.c --- linux-2.6.20-rc5/sound/core/sound.c

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Takashi Iwai
At Thu, 25 Jan 2007 13:07:04 -0500, [EMAIL PROTECTED] wrote: On 1/25/07, Takashi Iwai [EMAIL PROTECTED] wrote: At Thu, 25 Jan 2007 12:30:44 -0500, [EMAIL PROTECTED] wrote: I'm working on this now and will doublecheck just in case my test was flawed first time.

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread xiphmont
On 1/25/07, Takashi Iwai [EMAIL PROTECTED] wrote: The problem with your patch is that it breaks the structure newly introduced. In the new tree, card* contains the whole belonging devices, and each device points to the one in the card object. Passing dev-parent there cuts the relation between

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Takashi Iwai
At Thu, 25 Jan 2007 13:34:19 -0500, [EMAIL PROTECTED] wrote: On 1/25/07, Takashi Iwai [EMAIL PROTECTED] wrote: The problem with your patch is that it breaks the structure newly introduced. In the new tree, card* contains the whole belonging devices, and each device points to the one in

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread xiphmont
On 1/25/07, Takashi Iwai [EMAIL PROTECTED] wrote: [This does beg the question: Does the benefit of this complete restructuring in a subminor release of an allegedly stable kernel outweigh the fact that it breaks all audio for any user running a gnome desktop?] Well, that's not me who

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Greg KH
On Thu, Jan 25, 2007 at 01:51:42PM -0500, [EMAIL PROTECTED] wrote: On 1/25/07, Takashi Iwai [EMAIL PROTECTED] wrote: [This does beg the question: Does the benefit of this complete restructuring in a subminor release of an allegedly stable kernel outweigh the fact that it breaks all audio

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread xiphmont
Basically, new distros can disable that option if their userspace can handle the new structure of sysfs with the symlinks. Users of older distros with newer kernels can enable the option and (hopefully) not break anything. I would like to register a general objection to a change of this size

Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

2007-01-25 Thread Greg KH
On Thu, Jan 25, 2007 at 03:40:06PM -0500, [EMAIL PROTECTED] wrote: Basically, new distros can disable that option if their userspace can handle the new structure of sysfs with the symlinks. Users of older distros with newer kernels can enable the option and (hopefully) not break anything.