Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-25 Thread Will Deacon
Hi Ivaylo, On Tue, Feb 25, 2014 at 07:56:11AM +, Ivaylo Dimitrov wrote: > On 14.02.2014 18:24, Will Deacon wrote: > > You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and > > commenting out the skb->len = desc->length - PLCP_HEADER_LENGTH; line > > above. > > > > the

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-25 Thread Will Deacon
On Tue, Feb 25, 2014 at 10:44:44AM +, Pavel Machek wrote: > > >>You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and > > >>commenting out the skb->len = desc->length - PLCP_HEADER_LENGTH; line > > >>above. > > > > > >This seems to fix the issue too, but I am afraid there

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-25 Thread Pavel Machek
Hi! > >>You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and > >>commenting out the skb->len = desc->length - PLCP_HEADER_LENGTH; line > >>above. > > > >This seems to fix the issue too, but I am afraid there is more to be > >done, as I see > > > >Feb 14 18:33:46 Nokia-N900

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-25 Thread Pavel Machek
Hi! You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and commenting out the skb-len = desc-length - PLCP_HEADER_LENGTH; line above. This seems to fix the issue too, but I am afraid there is more to be done, as I see Feb 14 18:33:46 Nokia-N900 kernel: [ 88.599853]

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-25 Thread Will Deacon
On Tue, Feb 25, 2014 at 10:44:44AM +, Pavel Machek wrote: You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and commenting out the skb-len = desc-length - PLCP_HEADER_LENGTH; line above. This seems to fix the issue too, but I am afraid there is more to be

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-25 Thread Will Deacon
Hi Ivaylo, On Tue, Feb 25, 2014 at 07:56:11AM +, Ivaylo Dimitrov wrote: On 14.02.2014 18:24, Will Deacon wrote: You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and commenting out the skb-len = desc-length - PLCP_HEADER_LENGTH; line above. the following patch

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-24 Thread Ivaylo Dimitrov
Hi, On 14.02.2014 18:24, Will Deacon wrote: You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and commenting out the skb->len = desc->length - PLCP_HEADER_LENGTH; line above. the following patch diff --git a/drivers/net/wireless/ti/wl1251/rx.c

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-24 Thread Kalle Valo
Will Deacon writes: > Well, we probably need a bit more to go on, because I doubt that this code > is to blame. More likely, the issue is in the caller. > Looking at drivers/net/wireless/ti/wl1251/rx.c:182 > > /* The actual length doesn't include the target's alignment */ >

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-24 Thread Kalle Valo
Will Deacon will.dea...@arm.com writes: Well, we probably need a bit more to go on, because I doubt that this code is to blame. More likely, the issue is in the caller. Looking at drivers/net/wireless/ti/wl1251/rx.c:182 /* The actual length doesn't include the target's alignment */

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-24 Thread Ivaylo Dimitrov
Hi, On 14.02.2014 18:24, Will Deacon wrote: You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and commenting out the skb-len = desc-length - PLCP_HEADER_LENGTH; line above. the following patch diff --git a/drivers/net/wireless/ti/wl1251/rx.c

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-23 Thread Ivaylo Dimitrov
On 14.02.2014 19:11, Ivaylo Dimitrov wrote: On 14.02.2014 18:24, Will Deacon wrote: You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and commenting out the skb->len = desc->length - PLCP_HEADER_LENGTH; line above. This seems to fix the issue too, but I am afraid

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-23 Thread Ivaylo Dimitrov
On 14.02.2014 19:11, Ivaylo Dimitrov wrote: On 14.02.2014 18:24, Will Deacon wrote: You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and commenting out the skb-len = desc-length - PLCP_HEADER_LENGTH; line above. This seems to fix the issue too, but I am afraid there

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-14 Thread Ivaylo Dimitrov
On 14.02.2014 18:24, Will Deacon wrote: You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and commenting out the skb->len = desc->length - PLCP_HEADER_LENGTH; line above. This seems to fix the issue too, but I am afraid there is more to be done, as I see Feb 14

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-14 Thread Will Deacon
On Fri, Feb 14, 2014 at 04:12:44PM +, Ivaylo Dimitrov wrote: > On 13.02.2014 21:29, Will Deacon wrote: > > > > Can you try hacking crypto/memneq.c so that it doesn't use > > CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS please? That would at least point the > > finger at net/mac80211/rx.c or similar.

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-14 Thread Ivaylo Dimitrov
On 13.02.2014 21:29, Will Deacon wrote: Can you try hacking crypto/memneq.c so that it doesn't use CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS please? That would at least point the finger at net/mac80211/rx.c or similar. Cheers, Will Well, I am lazy so I hacked net/mac80211/rx.c first: index

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-14 Thread Ivaylo Dimitrov
On 13.02.2014 21:29, Will Deacon wrote: Can you try hacking crypto/memneq.c so that it doesn't use CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS please? That would at least point the finger at net/mac80211/rx.c or similar. Cheers, Will Well, I am lazy so I hacked net/mac80211/rx.c first: index

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-14 Thread Will Deacon
On Fri, Feb 14, 2014 at 04:12:44PM +, Ivaylo Dimitrov wrote: On 13.02.2014 21:29, Will Deacon wrote: Can you try hacking crypto/memneq.c so that it doesn't use CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS please? That would at least point the finger at net/mac80211/rx.c or similar.

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-14 Thread Ivaylo Dimitrov
On 14.02.2014 18:24, Will Deacon wrote: You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and commenting out the skb-len = desc-length - PLCP_HEADER_LENGTH; line above. This seems to fix the issue too, but I am afraid there is more to be done, as I see Feb 14

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-13 Thread Will Deacon
On Thu, Feb 13, 2014 at 06:43:15PM +, Ivaylo Dimitrov wrote: > > > On 13.02.2014 20:21, Will Deacon wrote: > > > > That's certainly unexpected. The n900 has (iirc) a Cortex-A8, which as an > > ARMv7 core, can perform unaligned accesses to normal, cacheable memory in > > hardware. > > > >

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-13 Thread Ivaylo Dimitrov
On 13.02.2014 20:21, Will Deacon wrote: That's certainly unexpected. The n900 has (iirc) a Cortex-A8, which as an ARMv7 core, can perform unaligned accesses to normal, cacheable memory in hardware. Yep, Cortex-A8 and it has no problem to do unaligned memory accesses AFAIK. I suspect it is

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-13 Thread Will Deacon
Hi Ivo, Thanks for bisecting this. On Thu, Feb 13, 2014 at 06:02:57PM +, Ivaylo Dimitrov wrote: > Since next-21012014 I started to receive "Received disconnect from > x.x.x.x: 2: Bad packet length 3149594624" errors when trying to > establish ssh session over wifi to my N900, running Maemo

[BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-13 Thread Ivaylo Dimitrov
Since next-21012014 I started to receive "Received disconnect from x.x.x.x: 2: Bad packet length 3149594624" errors when trying to establish ssh session over wifi to my N900, running Maemo 5. I bisected and it turned out that commit dce5c9e35bc4085bd33eccdb8c9ec5a643507a14 "ARM: 7928/1:

[BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-13 Thread Ivaylo Dimitrov
Since next-21012014 I started to receive Received disconnect from x.x.x.x: 2: Bad packet length 3149594624 errors when trying to establish ssh session over wifi to my N900, running Maemo 5. I bisected and it turned out that commit dce5c9e35bc4085bd33eccdb8c9ec5a643507a14 ARM: 7928/1: kconfig:

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-13 Thread Will Deacon
Hi Ivo, Thanks for bisecting this. On Thu, Feb 13, 2014 at 06:02:57PM +, Ivaylo Dimitrov wrote: Since next-21012014 I started to receive Received disconnect from x.x.x.x: 2: Bad packet length 3149594624 errors when trying to establish ssh session over wifi to my N900, running Maemo 5. I

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-13 Thread Ivaylo Dimitrov
On 13.02.2014 20:21, Will Deacon wrote: That's certainly unexpected. The n900 has (iirc) a Cortex-A8, which as an ARMv7 core, can perform unaligned accesses to normal, cacheable memory in hardware. Yep, Cortex-A8 and it has no problem to do unaligned memory accesses AFAIK. I suspect it is

Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624

2014-02-13 Thread Will Deacon
On Thu, Feb 13, 2014 at 06:43:15PM +, Ivaylo Dimitrov wrote: On 13.02.2014 20:21, Will Deacon wrote: That's certainly unexpected. The n900 has (iirc) a Cortex-A8, which as an ARMv7 core, can perform unaligned accesses to normal, cacheable memory in hardware. Yep, Cortex-A8