Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes

2013-02-19 Thread Greg KH
On Tue, Feb 19, 2013 at 11:59:10AM +0200, Felipe Balbi wrote: > Hi, > > On Mon, Feb 18, 2013 at 09:20:10PM +0200, Felipe Balbi wrote: > > On Mon, Feb 18, 2013 at 11:17:19AM -0800, Greg KH wrote: > > > On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote: > > > > Whenever a struct device_at

Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes

2013-02-19 Thread Felipe Balbi
Hi, On Mon, Feb 18, 2013 at 09:20:10PM +0200, Felipe Balbi wrote: > On Mon, Feb 18, 2013 at 11:17:19AM -0800, Greg KH wrote: > > On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote: > > > Whenever a struct device_attribute is registered > > > with mismatched permissions - read permission

Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes

2013-02-18 Thread Felipe Balbi
On Mon, Feb 18, 2013 at 11:17:19AM -0800, Greg KH wrote: > On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote: > > Whenever a struct device_attribute is registered > > with mismatched permissions - read permission without > > a show routine or write permission without store > > routine -

Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes

2013-02-18 Thread Greg KH
On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote: > Whenever a struct device_attribute is registered > with mismatched permissions - read permission without > a show routine or write permission without store > routine - we will issue a big warning so we catch > those early enough. > >

[BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes

2013-02-18 Thread Felipe Balbi
Whenever a struct device_attribute is registered with mismatched permissions - read permission without a show routine or write permission without store routine - we will issue a big warning so we catch those early enough. Signed-off-by: Felipe Balbi --- This is completely untested. I have only c