Re: [BUG?] Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor]

2014-03-14 Thread Konrad Rzeszutek Wilk
On Wed, Feb 26, 2014 at 11:26:21AM +0100, Stanislaw Gruszka wrote: > On Mon, Feb 10, 2014 at 09:37:27AM -0500, Konrad Rzeszutek Wilk wrote: > > > > But I'm not sure if that is good solution. It crate some not necessery > > > > sysfs directories and files. Additionaly it can restore CPU C-states > >

Re: [BUG?] Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor]

2014-02-26 Thread Stanislaw Gruszka
On Mon, Feb 10, 2014 at 09:37:27AM -0500, Konrad Rzeszutek Wilk wrote: > > > But I'm not sure if that is good solution. It crate some not necessery > > > sysfs directories and files. Additionaly it can restore CPU C-states > > > after some other drivers resume, which prehaps require proper C-states

Re: [BUG?] Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor]

2014-02-10 Thread Konrad Rzeszutek Wilk
On Mon, Feb 03, 2014 at 09:14:29AM -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Feb 03, 2014 at 11:12:16AM +0100, Stanislaw Gruszka wrote: > > On Fri, Jan 31, 2014 at 11:01:40AM -0500, Konrad Rzeszutek Wilk wrote: > > > Perhaps by using 'subsys_system_register' and stick it there? > > > > This wi

Re: [BUG?] Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor]

2014-02-03 Thread Konrad Rzeszutek Wilk
On Mon, Feb 03, 2014 at 11:12:16AM +0100, Stanislaw Gruszka wrote: > On Fri, Jan 31, 2014 at 11:01:40AM -0500, Konrad Rzeszutek Wilk wrote: > > Perhaps by using 'subsys_system_register' and stick it there? > > This will not call ->resume callback as it is only called for > devices, so additional d

Re: [BUG?] Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor]

2014-02-03 Thread Stanislaw Gruszka
On Fri, Jan 31, 2014 at 11:01:40AM -0500, Konrad Rzeszutek Wilk wrote: > Perhaps by using 'subsys_system_register' and stick it there? This will not call ->resume callback as it is only called for devices, so additional dummy device is needed, for example: struct device xap_dev = { .init_

Re: [BUG?] Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor]

2014-01-31 Thread Konrad Rzeszutek Wilk
On Wed, Jan 29, 2014 at 09:25:22AM +0100, Stanislaw Gruszka wrote: > (Cc: correct Rafael email) > > On Tue, Jan 28, 2014 at 09:24:57PM -0800, David Rientjes wrote: > > On Tue, 28 Jan 2014, Konrad Rzeszutek Wilk wrote: > > > > > diff --git a/drivers/xen/xen-acpi-processor.c > > > b/drivers/xen/xe

Re: [BUG?] Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor]

2014-01-31 Thread Stanislaw Gruszka
On Wed, Jan 29, 2014 at 09:25:21AM +0100, Stanislaw Gruszka wrote: > > Looks incomplete, what about the kzalloc() in > > xen_upload_processor_pm_data() and kcalloc()s in check_acpi_ids()? > > Indeed and additionally from check_acpi_ids() we call > acpi_walk_namespace(), which also take mutexes. H

Re: [BUG?] Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor]

2014-01-29 Thread Stanislaw Gruszka
(Cc: correct Rafael email) On Tue, Jan 28, 2014 at 09:24:57PM -0800, David Rientjes wrote: > On Tue, 28 Jan 2014, Konrad Rzeszutek Wilk wrote: > > > diff --git a/drivers/xen/xen-acpi-processor.c > > b/drivers/xen/xen-acpi-processor.c > > index 7231859..7602229 100644 > > --- a/drivers/xen/xen-ac

Re: [BUG?] Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor]

2014-01-28 Thread David Rientjes
On Tue, 28 Jan 2014, Konrad Rzeszutek Wilk wrote: > diff --git a/drivers/xen/xen-acpi-processor.c > b/drivers/xen/xen-acpi-processor.c > index 7231859..7602229 100644 > --- a/drivers/xen/xen-acpi-processor.c > +++ b/drivers/xen/xen-acpi-processor.c > @@ -46,7 +46,7 @@ module_param_named(off, no_h

Re: [BUG?] Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor]

2014-01-28 Thread Konrad Rzeszutek Wilk
On Tue, Jan 28, 2014 at 04:08:49PM +0100, Stanislaw Gruszka wrote: > Hi, Hey! > > We have this bug report on our bugzilla: > https://bugzilla.redhat.com/show_bug.cgi?id=1058268 > > In short: > WARNING: CPU: 0 PID: 6733 at drivers/base/syscore.c:104 > syscore_resume+0x9a/0xe0() > Interrupts enab

[BUG?] Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor]

2014-01-28 Thread Stanislaw Gruszka
Hi, We have this bug report on our bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1058268 In short: WARNING: CPU: 0 PID: 6733 at drivers/base/syscore.c:104 syscore_resume+0x9a/0xe0() Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor] Perhaps I'm wrong, but I