Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-25 Thread Ingo Molnar
* Mikael Pettersson <[EMAIL PROTECTED]> wrote: > > yes, i already fixed that when i added Mikael's patch and it's all > > queued up. > > Ok. For reference and for LKML viewers, this is what the final patch > should be: below is the full commit - will send it to Linus later today.

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-25 Thread Mikael Pettersson
Ingo Molnar writes: > > * H. Peter Anvin <[EMAIL PROTECTED]> wrote: > > > Please fix it in both places. Using XOR instead of AND-NOT is a bug, > > plain and simple. > > yes, i already fixed that when i added Mikael's patch and it's all > queued up. Ok. For reference and for LKML

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-25 Thread Ingo Molnar
* H. Peter Anvin <[EMAIL PROTECTED]> wrote: > Please fix it in both places. Using XOR instead of AND-NOT is a bug, > plain and simple. yes, i already fixed that when i added Mikael's patch and it's all queued up. Ingo -- To unsubscribe from this list: send the line "unsubscribe

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-25 Thread Ingo Molnar
* H. Peter Anvin [EMAIL PROTECTED] wrote: Please fix it in both places. Using XOR instead of AND-NOT is a bug, plain and simple. yes, i already fixed that when i added Mikael's patch and it's all queued up. Ingo -- To unsubscribe from this list: send the line unsubscribe

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-25 Thread Mikael Pettersson
Ingo Molnar writes: * H. Peter Anvin [EMAIL PROTECTED] wrote: Please fix it in both places. Using XOR instead of AND-NOT is a bug, plain and simple. yes, i already fixed that when i added Mikael's patch and it's all queued up. Ok. For reference and for LKML viewers, this

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-25 Thread Ingo Molnar
* Mikael Pettersson [EMAIL PROTECTED] wrote: yes, i already fixed that when i added Mikael's patch and it's all queued up. Ok. For reference and for LKML viewers, this is what the final patch should be: below is the full commit - will send it to Linus later today. Ingo

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-24 Thread H. Peter Anvin
Mikael Pettersson wrote: Here's how the breakage occurs: 1. arch/x86/kernel/tsc_32.c:tsc_init() sees !cpu_has_tsc, so bails and calls setup_clear_cpu_cap(X86_FEATURE_TSC). 2. include/asm-x86/cpufeature.h:setup_clear_cpu_cap(bit) clears the bit in boot_cpu_data and sets it in

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-24 Thread Ingo Molnar
* Mikael Pettersson <[EMAIL PROTECTED]> wrote: > > That turned out to be very illuminating: > > --- dmesg-2.6.24-git7 2008-02-24 18:01:25.295851000 +0100 > +++ dmesg-2.6.24-git8 2008-02-24 18:01:25.530358000 +0100 > ... > CPU: After generic identify, caps: 0003

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-24 Thread Mikael Pettersson
Mikael Pettersson writes: > Ingo Molnar writes: > > > > * Mikael Pettersson <[EMAIL PROTECTED]> wrote: > > > > > The kernel for this 486 has CONFIG_M486=y and CONFIG_M586TSC=n, but > > > the 2.6.25 kernels still try to access the TSC. Here's the oops from > > > 2.6.25-rc2-git8: >

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-24 Thread Ingo Molnar
* Mikael Pettersson <[EMAIL PROTECTED]> wrote: > 2.6.24-git8 changed include/asm-x86/tsc.h:get_cycles() to call > rdtscll() even if CONFIG_X86_TSC isn't set. The call is protected by a > cpu_has_tsc test, but starting with 2.6.24-git8 cpu_has_tsc is > non-zero on this machine, which is very

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-24 Thread Mikael Pettersson
Ingo Molnar writes: > > * Mikael Pettersson <[EMAIL PROTECTED]> wrote: > > > The kernel for this 486 has CONFIG_M486=y and CONFIG_M586TSC=n, but > > the 2.6.25 kernels still try to access the TSC. Here's the oops from > > 2.6.25-rc2-git8: > > hm, could you send me the full .config you

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-24 Thread Ingo Molnar
* Mikael Pettersson <[EMAIL PROTECTED]> wrote: > The kernel for this 486 has CONFIG_M486=y and CONFIG_M586TSC=n, but > the 2.6.25 kernels still try to access the TSC. Here's the oops from > 2.6.25-rc2-git8: hm, could you send me the full .config you used? Ingo -- To unsubscribe from

[BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-24 Thread Mikael Pettersson
The kernel for this 486 has CONFIG_M486=y and CONFIG_M586TSC=n, but the 2.6.25 kernels still try to access the TSC. Here's the oops from 2.6.25-rc2-git8: Pid: 0, comm: swapper Not tainted (2.6.25-rc2-git8 #1) EIP: 0060:[] EFLAGS: 00010002 CPU: 0 EIP is at native_read_tsc+0x6/0x10 EAX: 8ce6

[BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-24 Thread Mikael Pettersson
The kernel for this 486 has CONFIG_M486=y and CONFIG_M586TSC=n, but the 2.6.25 kernels still try to access the TSC. Here's the oops from 2.6.25-rc2-git8: Pid: 0, comm: swapper Not tainted (2.6.25-rc2-git8 #1) EIP: 0060:[c0106216] EFLAGS: 00010002 CPU: 0 EIP is at native_read_tsc+0x6/0x10 EAX:

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-24 Thread Ingo Molnar
* Mikael Pettersson [EMAIL PROTECTED] wrote: The kernel for this 486 has CONFIG_M486=y and CONFIG_M586TSC=n, but the 2.6.25 kernels still try to access the TSC. Here's the oops from 2.6.25-rc2-git8: hm, could you send me the full .config you used? Ingo -- To unsubscribe from this

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-24 Thread Mikael Pettersson
Ingo Molnar writes: * Mikael Pettersson [EMAIL PROTECTED] wrote: The kernel for this 486 has CONFIG_M486=y and CONFIG_M586TSC=n, but the 2.6.25 kernels still try to access the TSC. Here's the oops from 2.6.25-rc2-git8: hm, could you send me the full .config you used? I've

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-24 Thread Ingo Molnar
* Mikael Pettersson [EMAIL PROTECTED] wrote: 2.6.24-git8 changed include/asm-x86/tsc.h:get_cycles() to call rdtscll() even if CONFIG_X86_TSC isn't set. The call is protected by a cpu_has_tsc test, but starting with 2.6.24-git8 cpu_has_tsc is non-zero on this machine, which is very very

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-24 Thread Mikael Pettersson
Mikael Pettersson writes: Ingo Molnar writes: * Mikael Pettersson [EMAIL PROTECTED] wrote: The kernel for this 486 has CONFIG_M486=y and CONFIG_M586TSC=n, but the 2.6.25 kernels still try to access the TSC. Here's the oops from 2.6.25-rc2-git8: hm, could

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-24 Thread Ingo Molnar
* Mikael Pettersson [EMAIL PROTECTED] wrote: That turned out to be very illuminating: --- dmesg-2.6.24-git7 2008-02-24 18:01:25.295851000 +0100 +++ dmesg-2.6.24-git8 2008-02-24 18:01:25.530358000 +0100 ... CPU: After generic identify, caps: 0003

Re: [BUG] 2.6.25-rc2-git8 fails to boot on 486 due to TSC breakage

2008-02-24 Thread H. Peter Anvin
Mikael Pettersson wrote: Here's how the breakage occurs: 1. arch/x86/kernel/tsc_32.c:tsc_init() sees !cpu_has_tsc, so bails and calls setup_clear_cpu_cap(X86_FEATURE_TSC). 2. include/asm-x86/cpufeature.h:setup_clear_cpu_cap(bit) clears the bit in boot_cpu_data and sets it in