Re: [BUG] Bug in netprio_cgroup and netcls_cgroup ?

2013-01-25 Thread Li Zefan
BTW, isn't this a similar to what should happen with the block io cgroup? What is the behavior with a fd writing to a file in the scenario you describe above? >>> >>> It forbids task moving in this case: >>> >>> /* >>> * We cannot support shared io contexts, as we have no mean

Re: [BUG] Bug in netprio_cgroup and netcls_cgroup ?

2013-01-23 Thread Daniel Wagner
On 23.01.2013 01:02, John Fastabend wrote: [...] OK, I guess we should do something similar in the netprio, netcls cgroups and yes document it as you noted in your last comment. Here is my attempt to add such a check. I really don't know if this is the correct way to do so. To test this I ha

Re: [BUG] Bug in netprio_cgroup and netcls_cgroup ?

2013-01-22 Thread John Fastabend
[...] OK, I guess we should do something similar in the netprio, netcls cgroups and yes document it as you noted in your last comment. Here is my attempt to add such a check. I really don't know if this is the correct way to do so. To test this I have written a test program, which seems to te

Re: [BUG] Bug in netprio_cgroup and netcls_cgroup ?

2013-01-22 Thread Daniel Wagner
On Mon, Jan 21, 2013 at 09:18:38AM -0800, John Fastabend wrote: > On 01/21/2013 01:57 AM, Li Zefan wrote: > > On 2013/1/21 17:27, Daniel Wagner wrote: > >> On 21.01.2013 10:01, Li Zefan wrote: > >>> On 2013/1/21 16:50, Daniel Wagner wrote: > Hi Li, > > On 21.01.2013 07:08, Li Zefan w

Re: [BUG] Bug in netprio_cgroup and netcls_cgroup ?

2013-01-21 Thread John Fastabend
On 01/21/2013 01:57 AM, Li Zefan wrote: > On 2013/1/21 17:27, Daniel Wagner wrote: >> On 21.01.2013 10:01, Li Zefan wrote: >>> On 2013/1/21 16:50, Daniel Wagner wrote: Hi Li, On 21.01.2013 07:08, Li Zefan wrote: > I'm not a network developer, so correct me if I'm wrong. > >>>

Re: [BUG] Bug in netprio_cgroup and netcls_cgroup ?

2013-01-21 Thread Li Zefan
On 2013/1/21 17:27, Daniel Wagner wrote: > On 21.01.2013 10:01, Li Zefan wrote: >> On 2013/1/21 16:50, Daniel Wagner wrote: >>> Hi Li, >>> >>> On 21.01.2013 07:08, Li Zefan wrote: I'm not a network developer, so correct me if I'm wrong. Since commit 7955490f732c2b8 ("net: netpri

Re: [BUG] Bug in netprio_cgroup and netcls_cgroup ?

2013-01-21 Thread Li Zefan
On 2013/1/21 17:21, John Fastabend wrote: > On 01/21/2013 01:01 AM, Li Zefan wrote: >> On 2013/1/21 16:50, Daniel Wagner wrote: >>> Hi Li, >>> >>> On 21.01.2013 07:08, Li Zefan wrote: I'm not a network developer, so correct me if I'm wrong. Since commit 7955490f732c2b8 ("net: ne

Re: [BUG] Bug in netprio_cgroup and netcls_cgroup ?

2013-01-21 Thread Daniel Wagner
On 21.01.2013 10:01, Li Zefan wrote: > On 2013/1/21 16:50, Daniel Wagner wrote: >> Hi Li, >> >> On 21.01.2013 07:08, Li Zefan wrote: >>> I'm not a network developer, so correct me if I'm wrong. >>> >>> Since commit 7955490f732c2b8 >>> ("net: netprio_cgroup: rework update socket logic"), >>> sock->

Re: [BUG] Bug in netprio_cgroup and netcls_cgroup ?

2013-01-21 Thread John Fastabend
On 01/21/2013 01:01 AM, Li Zefan wrote: > On 2013/1/21 16:50, Daniel Wagner wrote: >> Hi Li, >> >> On 21.01.2013 07:08, Li Zefan wrote: >>> I'm not a network developer, so correct me if I'm wrong. >>> >>> Since commit 7955490f732c2b8 >>> ("net: netprio_cgroup: rework update socket logic"), >>> soc

Re: [BUG] Bug in netprio_cgroup and netcls_cgroup ?

2013-01-21 Thread Li Zefan
On 2013/1/21 16:50, Daniel Wagner wrote: > Hi Li, > > On 21.01.2013 07:08, Li Zefan wrote: >> I'm not a network developer, so correct me if I'm wrong. >> >> Since commit 7955490f732c2b8 >> ("net: netprio_cgroup: rework update socket logic"), >> sock->sk->sk_cgrp_prioidx >> is set when the socket

Re: [BUG] Bug in netprio_cgroup and netcls_cgroup ?

2013-01-21 Thread Daniel Wagner
Hi Li, On 21.01.2013 07:08, Li Zefan wrote: > I'm not a network developer, so correct me if I'm wrong. > > Since commit 7955490f732c2b8 > ("net: netprio_cgroup: rework update socket logic"), sock->sk->sk_cgrp_prioidx > is set when the socket is created, and won't be updated unless the task is > m

[BUG] Bug in netprio_cgroup and netcls_cgroup ?

2013-01-20 Thread Li Zefan
I'm not a network developer, so correct me if I'm wrong. Since commit 406a3c638ce8b17d9704052c07955490f732c2b8 ("net: netprio_cgroup: rework update socket logic"), sock->sk->sk_cgrp_prioidx is set when the socket is created, and won't be updated unless the task is moved to another cgroup. Now the