Re: [BUG] Kernel crash on Allwinner H3 due to sound core changes

2018-03-09 Thread Mark Brown
On Thu, Mar 08, 2018 at 11:49:18PM +, Kuninori Morimoto wrote: > previous my patch used new flag (= .alloced_component), > but I think it is not good idea. > And I noticed that snd_soc_add_component() is > also calling kfree(component) (= has same bug). > So how about below one ? > I want to

Re: [alsa-devel] [BUG] Kernel crash on Allwinner H3 due to sound core changes

2018-03-08 Thread Jernej Škrabec
Hi, Dne petek, 09. marec 2018 ob 00:49:18 CET je Kuninori Morimoto napisal(a): > Hi Mark,Jernej > > > > Ahh.. indeed. Good catch ! > > > How about to add such flag ? > > > This is just idea. No tested, No compiled, but can help you ? > > > > I think this makes sense as a patch. We might want to

Re: [BUG] Kernel crash on Allwinner H3 due to sound core changes

2018-03-08 Thread Kuninori Morimoto
Hi Mark,Jernej > > Ahh.. indeed. Good catch ! > > How about to add such flag ? > > This is just idea. No tested, No compiled, but can help you ? > > I think this makes sense as a patch. We might want to disallow > allocating components as part of a bigger struct so everything is more > consiste

Re: [BUG] Kernel crash on Allwinner H3 due to sound core changes

2018-03-08 Thread Mark Brown
On Thu, Mar 08, 2018 at 01:21:02AM +, Kuninori Morimoto wrote: > Ahh.. indeed. Good catch ! > How about to add such flag ? > This is just idea. No tested, No compiled, but can help you ? I think this makes sense as a patch. We might want to disallow allocating components as part of a bigger

Re: [alsa-devel] [BUG] Kernel crash on Allwinner H3 due to sound core changes

2018-03-07 Thread Jernej Škrabec
Hi, Thank you for looking into it so quickly. Dne četrtek, 08. marec 2018 ob 02:21:02 CET je Kuninori Morimoto napisal(a): > Hi Jernej > > Thank you for your hard work > > > I found the issue. Commit be7ee5f32a9a ("ASoC: soc-generic-dmaengine-pcm: > > > > replace platform to component") change

Re: [BUG] Kernel crash on Allwinner H3 due to sound core changes

2018-03-07 Thread Kuninori Morimoto
Hi Jernej Thank you for your hard work > I found the issue. Commit be7ee5f32a9a ("ASoC: soc-generic-dmaengine-pcm: > replace platform to component") changes struct dmaengine_pcm: > > struct dmaengine_pcm { > struct dma_chan *chan[SNDRV_PCM_STREAM_LAST + 1]; > const struct snd_dmae

Re: [BUG] Kernel crash on Allwinner H3 due to sound core changes

2018-03-07 Thread Jernej Škrabec
Hi, Dne ponedeljek, 05. marec 2018 ob 22:30:23 CET je Jernej Škrabec napisal(a): > Hi, > > Dne petek, 02. marec 2018 ob 13:40:50 CET je Mark Brown napisal(a): > > On Thu, Mar 01, 2018 at 11:23:57PM +0100, Jernej Škrabec wrote: > > > I removed parts of the code from the sun4i codec driver and > >

Re: [BUG] Kernel crash on Allwinner H3 due to sound core changes

2018-03-05 Thread Jernej Škrabec
Hi, Dne petek, 02. marec 2018 ob 13:40:50 CET je Mark Brown napisal(a): > On Thu, Mar 01, 2018 at 11:23:57PM +0100, Jernej Škrabec wrote: > > I removed parts of the code from the sun4i codec driver and interestingly > > it doesn't crash if I remove following lines: > > > > ret = devm_snd_dmaengin

Re: [BUG] Kernel crash on Allwinner H3 due to sound core changes

2018-03-02 Thread Mark Brown
On Thu, Mar 01, 2018 at 11:23:57PM +0100, Jernej Škrabec wrote: > I removed parts of the code from the sun4i codec driver and interestingly it > doesn't crash if I remove following lines: > ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); > if (ret) { > dev_err(&pdev->dev, "Fail

Re: [BUG] Kernel crash on Allwinner H3 due to sound core changes

2018-03-01 Thread Jernej Škrabec
Hi Kuninori, I'm responding to my own mail, since I didn't received yours for some reason but I still saw your response in mailing list archive. Dne sreda, 28. februar 2018 ob 22:02:09 CET je Jernej Škrabec napisal(a): > Hi all, > > with todays linux-next (next-20180228), kernel on Allwinner H3

Re: [BUG] Kernel crash on Allwinner H3 due to sound core changes

2018-02-28 Thread Kuninori Morimoto
Hi Jernej Thank you for your report > with todays linux-next (next-20180228), kernel on Allwinner H3 SoC crashes > with dmesg like that: https://pastebin.com/raw/0D5JeaJ8 > > I bisected the kernel and first offending commit is: > be7ee5f32a9a ("ASoC: soc-generic-dmaengine-pcm: replace platform

[BUG] Kernel crash on Allwinner H3 due to sound core changes

2018-02-28 Thread Jernej Škrabec
Hi all, with todays linux-next (next-20180228), kernel on Allwinner H3 SoC crashes with dmesg like that: https://pastebin.com/raw/0D5JeaJ8 I bisected the kernel and first offending commit is: be7ee5f32a9a ("ASoC: soc-generic-dmaengine-pcm: replace platform to component") I know that crash mess