Re: [BUG] daemon.c blows up on OSX

2006-12-20 Thread Albert Cahalan
Linus Torvalds writes: So it would appear that for OS X, the #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */ #define _GNU_SOURCE #define _BSD_SOURCE sequence actually _disables_ those things. Yes, of course. The odd one here is glibc. Normal systems enable everyt

Re: [BUG] daemon.c blows up on OSX

2006-12-20 Thread Linus Torvalds
On Wed, 20 Dec 2006, Randal L. Schwartz wrote: > > What I do know is (a) it worked before the header changes and (b) > the patch I just gave you works. If the patch doesn't break others, > can we just leave it in? Well, at some point it probably _will_ break on other systems, exactly because

Re: [BUG] daemon.c blows up on OSX

2006-12-20 Thread Junio C Hamano
merlyn@stonehenge.com (Randal L. Schwartz) writes: > But yes, _XOPEN_SOURCE_EXTENDED definitely does some damage to > curses.h. However, I don't see how that's relevant to strings.h > or the others I need. There's no "config" for "compatibility". > Welcome to Linux vs Unix. :) > > What I do know

Re: [BUG] daemon.c blows up on OSX

2006-12-20 Thread Randal L. Schwartz
> "Linus" == Linus Torvalds <[EMAIL PROTECTED]> writes: Linus> #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */ Linus> #define _GNU_SOURCE Linus> #define _BSD_SOURCE Well, _GNU_SOURCE and _BSD_SOURCE only get defined, and only by some oddballs that aren't relevant here. Linus> s

Re: [BUG] daemon.c blows up on OSX

2006-12-20 Thread Linus Torvalds
On Wed, 20 Dec 2006, Randal L. Schwartz wrote: > > According to my headers, "strncasecmp" is defined in , > "NI_MAXSERV" is defined in , and "initgrps" is defined > in "unistd.h". So this patch works (just verified on OSX), but I > don't know what damage it does elsehwere: Look at "cache.h": t

Re: [BUG] daemon.c blows up on OSX

2006-12-20 Thread Randal L. Schwartz
> "Randal" == Randal L Schwartz writes: Randal> running "git version 1.4.4.3.g5485" on my openbsd box, but I can't get Randal> there on my OSX box. According to my headers, "strncasecmp" is defined in , "NI_MAXSERV" is defined in , and "initgrps" is defined in "unistd.h". So this patch work

Re: [BUG] daemon.c blows up on OSX

2006-12-20 Thread Junio C Hamano
merlyn@stonehenge.com (Randal L. Schwartz) writes: > Lemme see if it breaks on OpenBSD as well. > > Oddly enough - it didn't. :) Of course it didn't. I was a bit more careful than usual with this and fired up an OpenBSD bochs on my wife's machine to test it before pushing out. > running "git ve

Re: [BUG] daemon.c blows up on OSX

2006-12-20 Thread Randal L. Schwartz
> "Junio" == Junio C Hamano <[EMAIL PROTECTED]> writes: Junio> merlyn@stonehenge.com (Randal L. Schwartz) writes: >> Nope... can't compile: >> ... >> daemon.c:970: warning: implicit declaration of function 'initgroups' >> make: *** [daemon.o] Error 1 >> >> This smells like we've seen this bef

Re: [BUG] daemon.c blows up on OSX

2006-12-20 Thread Junio C Hamano
merlyn@stonehenge.com (Randal L. Schwartz) writes: > Nope... can't compile: > ... > daemon.c:970: warning: implicit declaration of function 'initgroups' > make: *** [daemon.o] Error 1 > > This smells like we've seen this before. Regression introduced with > some of the cleanup? Most like

[BUG] daemon.c blows up on OSX (was Re: What's in git.git (stable), and Announcing GIT 1.4.4.3)

2006-12-20 Thread Randal L. Schwartz
> "Linus" == Linus Torvalds <[EMAIL PROTECTED]> writes: >> Is this really in master? I'm still seeing one-hour times on >> my Mac, using 8336afa563fbeff35e531396273065161181f04c. Linus> Master right now is at 54851157ac. Yeah, 54 objects just pulled down. Here we go. Time for a test...