Re: [BUG] lseek on /proc/meminfo is broken in 4.19.59 maybe due to commit 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface")

2019-08-01 Thread Sergei Turchanov
Hello! Yes, your patch fixed this bug. Thank you very much! With best regards, Sergei. On 01.08.2019 19:14, NeilBrown wrote: On Thu, Aug 01 2019, Sergei Turchanov wrote: Hello! [ As suggested in previous discussion this behavior may be caused by your commit 1f4aace60b0e ("fs/seq_file.

Re: [BUG] lseek on /proc/meminfo is broken in 4.19.59 maybe due to commit 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface")

2019-08-01 Thread NeilBrown
On Thu, Aug 01 2019, Sergei Turchanov wrote: > Hello! > > [ > As suggested in previous discussion this behavior may be caused by your > commit 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and > interface") > ] Yes I think I can see what happened. removing: -

[BUG] lseek on /proc/meminfo is broken in 4.19.59 maybe due to commit 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface")

2019-08-01 Thread Sergei Turchanov
Hello! [ As suggested in previous discussion this behavior may be caused by your commit 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface") ] Original bug report: Seeking (to an offset within file size) in /proc/meminfo is broken in 4.19.59. It does seek to a desi

Re: [BUG] lseek on /proc/meminfo is broken in 4.19.59

2019-08-01 Thread Sergei Turchanov
Hi, Thank you very much for your suggestion. Will certainly do that. With best regards, Sergei. On 01.08.2019 17:11, Gao Xiang wrote: Hi, I just took a glance, maybe due to commit 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface") I simply reverted it just now an

Re: [BUG] lseek on /proc/meminfo is broken in 4.19.59

2019-08-01 Thread Gao Xiang
Hi, I just took a glance, maybe due to commit 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface") I simply reverted it just now and it seems fine... but I haven't digged into this commit. Maybe you could Cc NeilBrown for some more advice and I have no idea whether i

[BUG] lseek on /proc/meminfo is broken in 4.19.59

2019-07-31 Thread Sergei Turchanov
Hello! (I sent this e-mail two weeks ago with no feedback. Does anyone care? Wrong mailing list? Anything?) Seeking (to an offset within file size) in /proc/meminfo is broken in 4.19.59. It does seek to a desired position, but reading from that position returns the remainder of file and

[BUG] lseek on /proc/meminfo is broken in 4.19.59

2019-07-17 Thread Sergei Turchanov
Hello! Seeking (to an offset within file size) in /proc/meminfo is broken in 4.19.59. It does seek to a desired position, but reading from that position returns the remainder of file and then a whole copy of file. This doesn't happen with /proc/vmstat or /proc/self/maps for example. Seeking