Re: [PATCH] mm: hugetlb: fix copy_hugetlb_page_range() (Re: [BUG] new copy_hugetlb_page_range() causing crashes)

2014-07-17 Thread Hugh Dickins
On Thu, 17 Jul 2014, Naoya Horiguchi wrote: > # CCed Andrew, and linux-mm > > On Thu, Jul 17, 2014 at 11:59:36PM +0200, Guillaume Morin wrote: > > On 17 Jul 17:33, Naoya Horiguchi wrote: > ... > > > And it seems that this also happens on v3.16-rc5. > > > So it might be an upstream bug, not a sta

[PATCH] mm: hugetlb: fix copy_hugetlb_page_range() (Re: [BUG] new copy_hugetlb_page_range() causing crashes)

2014-07-17 Thread Naoya Horiguchi
# CCed Andrew, and linux-mm On Thu, Jul 17, 2014 at 11:59:36PM +0200, Guillaume Morin wrote: > On 17 Jul 17:33, Naoya Horiguchi wrote: ... > > And it seems that this also happens on v3.16-rc5. > > So it might be an upstream bug, not a stable-specific matter. > > That's my understanding as well.

Re: [BUG] new copy_hugetlb_page_range() causing crashes

2014-07-17 Thread Guillaume Morin
On 17 Jul 17:33, Naoya Horiguchi wrote: > In my environment (kernel-3.14.12, libhugetlbfs-utils-2.16-2.fc20.x86_64), > the crash looks like this: > > [root@test_140717-1333 hugetlbfs_test]# $ export HUGETLB_MORECORE=yes ; > export HUGETLB_NO_PREFAULT= ; hugectl --heap ./heap > bash: $: command no

Re: [BUG] new copy_hugetlb_page_range() causing crashes

2014-07-17 Thread Naoya Horiguchi
On Thu, Jul 17, 2014 at 10:12:04PM +0200, Guillaume Morin wrote: > Nayoa, > > Thanks for your answer. > > On 17 Jul 14:35, Horiguchi, Naoya wrote: > > I tried some simple operation (below) on 3.14.12, but not reproduced the > > crash, > > so some non-trivial condition seemed to trigger this. > >

Re: [BUG] new copy_hugetlb_page_range() causing crashes

2014-07-17 Thread Guillaume Morin
Nayoa, Thanks for your answer. On 17 Jul 14:35, Horiguchi, Naoya wrote: > I tried some simple operation (below) on 3.14.12, but not reproduced the > crash, > so some non-trivial condition seemed to trigger this. > Could you elaborate about how you reproduced the crash? Well, It's just a bunch o

[BUG] new copy_hugetlb_page_range() causing crashes

2014-07-17 Thread Guillaume Morin
Naoya, Hugh, I am seeing lots of crashes with the new copy_hugetlb_page_range() code added by 4a705fef986231a3e7a6b1a6d3c37025f021f49f for some set of programs. Specifically, I am running some test programs which use huge pages for malloc (through libhugetlbfs with HUGETLB_MORECORE=yes and HUGETL