Re: [BUG] perf tests: Test converting perf time to TSC

2013-10-03 Thread Peter Zijlstra
On Thu, Oct 03, 2013 at 02:49:09PM +0300, Adrian Hunter wrote: > You can boot with notsc and perf still seems to work > e.g. > > $ dmesg | grep -i tsc > [0.00] Command line: BOOT_IMAGE=/boot/vmlinuz-3.11.0+ > root=UUID=f1b4c71a-15aa-41a6-8898-cdde49966bce ro ignore_loglevel > earlyprintk

Re: [BUG] perf tests: Test converting perf time to TSC

2013-10-03 Thread Adrian Hunter
On 03/10/13 14:02, Peter Zijlstra wrote: > On Thu, Oct 03, 2013 at 01:13:45PM +0300, Adrian Hunter wrote: >>> Anyway; looking at this, why does time_zero have these different checks >>> from the other time bits? >>> >>> @@ -1897,6 +1898,11 @@ void arch_perf_update_userpage(struct >>> perf_event_mm

Re: [BUG] perf tests: Test converting perf time to TSC

2013-10-03 Thread Peter Zijlstra
On Thu, Oct 03, 2013 at 01:13:45PM +0300, Adrian Hunter wrote: > > Anyway; looking at this, why does time_zero have these different checks > > from the other time bits? > > > > @@ -1897,6 +1898,11 @@ void arch_perf_update_userpage(struct > > perf_event_mmap_page *userpg, u64 now) > > user

Re: [BUG] perf tests: Test converting perf time to TSC

2013-10-03 Thread Adrian Hunter
On 03/10/13 11:56, Peter Zijlstra wrote: > On Thu, Oct 03, 2013 at 11:42:46AM +0300, Adrian Hunter wrote: >> On 03/10/13 11:17, Jiri Olsa wrote: >>> On Wed, Oct 02, 2013 at 04:46:59PM +0300, Adrian Hunter wrote: On 02/10/13 16:23, Jiri Olsa wrote: > hi, > got a segfault in the tsc test

Re: [BUG] perf tests: Test converting perf time to TSC

2013-10-03 Thread Peter Zijlstra
On Thu, Oct 03, 2013 at 12:54:32PM +0300, Adrian Hunter wrote: > Where do you see that? my minds eye.. I should go back to sleep or so :-( Its going to be one of those days. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel

Re: [BUG] perf tests: Test converting perf time to TSC

2013-10-03 Thread Adrian Hunter
On 03/10/13 11:58, Peter Zijlstra wrote: > On Thu, Oct 03, 2013 at 10:56:25AM +0200, Peter Zijlstra wrote: >>> No the ABI is broken in that case - better to crash. >> >> No; neither case should crash. > > OK; previously we would report cap_usr_time = 1 even though we might not > have written stuff

Re: [BUG] perf tests: Test converting perf time to TSC

2013-10-03 Thread Peter Zijlstra
On Thu, Oct 03, 2013 at 10:56:25AM +0200, Peter Zijlstra wrote: > > No the ABI is broken in that case - better to crash. > > No; neither case should crash. OK; previously we would report cap_usr_time = 1 even though we might not have written stuff into the fields; which would indeed explain the c

Re: [BUG] perf tests: Test converting perf time to TSC

2013-10-03 Thread Peter Zijlstra
On Thu, Oct 03, 2013 at 11:42:46AM +0300, Adrian Hunter wrote: > On 03/10/13 11:17, Jiri Olsa wrote: > > On Wed, Oct 02, 2013 at 04:46:59PM +0300, Adrian Hunter wrote: > >> On 02/10/13 16:23, Jiri Olsa wrote: > >>> hi, > >>> got a segfault in the tsc test on latest acme's tree. > >>> > >>> I'm deal

Re: [BUG] perf tests: Test converting perf time to TSC

2013-10-03 Thread Adrian Hunter
On 03/10/13 11:17, Jiri Olsa wrote: > On Wed, Oct 02, 2013 at 04:46:59PM +0300, Adrian Hunter wrote: >> On 02/10/13 16:23, Jiri Olsa wrote: >>> hi, >>> got a segfault in the tsc test on latest acme's tree. >>> >>> I'm dealing with some other issues right now, so just reporting ;-) >> >> The capabil

Re: [BUG] perf tests: Test converting perf time to TSC

2013-10-03 Thread Jiri Olsa
On Wed, Oct 02, 2013 at 04:46:59PM +0300, Adrian Hunter wrote: > On 02/10/13 16:23, Jiri Olsa wrote: > > hi, > > got a segfault in the tsc test on latest acme's tree. > > > > I'm dealing with some other issues right now, so just reporting ;-) > > The capability bits have changed positions. You n

Re: [BUG] perf tests: Test converting perf time to TSC

2013-10-02 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 02, 2013 at 04:46:59PM +0300, Adrian Hunter escreveu: > On 02/10/13 16:23, Jiri Olsa wrote: > > hi, > > got a segfault in the tsc test on latest acme's tree. > > > > I'm dealing with some other issues right now, so just reporting ;-) > > The capability bits have changed positions. Yo

Re: [BUG] perf tests: Test converting perf time to TSC

2013-10-02 Thread Adrian Hunter
On 02/10/13 16:23, Jiri Olsa wrote: > hi, > got a segfault in the tsc test on latest acme's tree. > > I'm dealing with some other issues right now, so just reporting ;-) The capability bits have changed positions. You need to have: commit fa7315871046b9a4c48627905691dbde57e51033 Author: Peter Z

[BUG] perf tests: Test converting perf time to TSC

2013-10-02 Thread Jiri Olsa
hi, got a segfault in the tsc test on latest acme's tree. I'm dealing with some other issues right now, so just reporting ;-) thanks, jirka (gdb) r test 20 Starting program: /home/jolsa/linux-perf/tools/perf/perf test 20 [Thread debugging using libthread_db enabled] Using host libthread_db libra