Re: [BUG] problem with nfs_invalidate_page

2007-08-30 Thread Ryusuke Konishi
On Wed, 29 Aug 2007 11:49:22 -0400, Trond Myklebust wrote: >OK. I see your point... Basically, you are saying that the new >->invalidatepage() semantics do not allow us to rely on the dirty status >of the page in order to figure out if we need to clean up. Exactly. >Andrew, that was a fairly sign

Re: [BUG] problem with nfs_invalidate_page

2007-08-29 Thread Trond Myklebust
On Tue, 2007-08-28 at 17:32 +0900, Ryusuke Konishi wrote: > On Mon, 27 Aug 2007 09:30:12 -0400, Trond Myklebust wrote: > >It looks as if ecryptfs is dropping the page lock between the calls to > >prepare_write() and commit_write(). That would be a bug. > > No, ecryptfs is holding the page lock bet

Re: [BUG] problem with nfs_invalidate_page

2007-08-28 Thread Ryusuke Konishi
On Mon, 27 Aug 2007 09:30:12 -0400, Trond Myklebust wrote: >It looks as if ecryptfs is dropping the page lock between the calls to >prepare_write() and commit_write(). That would be a bug. No, ecryptfs is holding the page lock between the calls to nfs_prepare_write() and nfs_commit_write(). This