Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove

2017-12-13 Thread Jia-Ju Bai
On 2017/12/14 0:50, Stephen Hemminger wrote: On Wed, 13 Dec 2017 15:42:56 +0800 Jia-Ju Bai wrote: On 2017/12/13 13:18, Stephen Hemminger wrote: On Tue, 12 Dec 2017 20:57:01 -0500 (EST) David Miller wrote: From: Stephen Hemminger Date: Tue, 12 Dec 2017 10:22:40 -0800 On Tue, 12 Dec

Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove

2017-12-13 Thread Stephen Hemminger
On Wed, 13 Dec 2017 15:42:56 +0800 Jia-Ju Bai wrote: > On 2017/12/13 13:18, Stephen Hemminger wrote: > > On Tue, 12 Dec 2017 20:57:01 -0500 (EST) > > David Miller wrote: > > > >> From: Stephen Hemminger > >> Date: Tue, 12 Dec 2017 10:22:40 -0800 > >> > >>> On Tue, 12 Dec 2017 08:34:45 -0500

Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove

2017-12-12 Thread Jia-Ju Bai
On 2017/12/13 13:18, Stephen Hemminger wrote: On Tue, 12 Dec 2017 20:57:01 -0500 (EST) David Miller wrote: From: Stephen Hemminger Date: Tue, 12 Dec 2017 10:22:40 -0800 On Tue, 12 Dec 2017 08:34:45 -0500 (EST) David Miller wrote: From: Jia-Ju Bai Date: Tue, 12 Dec 2017 16:38:12 +080

Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove

2017-12-12 Thread Stephen Hemminger
On Tue, 12 Dec 2017 20:57:01 -0500 (EST) David Miller wrote: > From: Stephen Hemminger > Date: Tue, 12 Dec 2017 10:22:40 -0800 > > > On Tue, 12 Dec 2017 08:34:45 -0500 (EST) > > David Miller wrote: > > > >> From: Jia-Ju Bai > >> Date: Tue, 12 Dec 2017 16:38:12 +0800 > >> > >> > Accordin

Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove

2017-12-12 Thread David Miller
From: Stephen Hemminger Date: Tue, 12 Dec 2017 10:22:40 -0800 > On Tue, 12 Dec 2017 08:34:45 -0500 (EST) > David Miller wrote: > >> From: Jia-Ju Bai >> Date: Tue, 12 Dec 2017 16:38:12 +0800 >> >> > According to drivers/net/ethernet/marvell/skge.c, the driver may sleep >> > under a spinlock. >

Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove

2017-12-12 Thread Stephen Hemminger
On Tue, 12 Dec 2017 08:34:45 -0500 (EST) David Miller wrote: > From: Jia-Ju Bai > Date: Tue, 12 Dec 2017 16:38:12 +0800 > > > According to drivers/net/ethernet/marvell/skge.c, the driver may sleep > > under a spinlock. > > The function call path is: > > skge_remove (acquire the spinlock) > >

Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove

2017-12-12 Thread David Miller
From: Jia-Ju Bai Date: Tue, 12 Dec 2017 16:38:12 +0800 > According to drivers/net/ethernet/marvell/skge.c, the driver may sleep > under a spinlock. > The function call path is: > skge_remove (acquire the spinlock) > free_irq --> may sleep > > I do not find a good way to fix it, so I only repor

[BUG] skge: a possible sleep-in-atomic bug in skge_remove

2017-12-12 Thread Jia-Ju Bai
According to drivers/net/ethernet/marvell/skge.c, the driver may sleep under a spinlock. The function call path is: skge_remove (acquire the spinlock) free_irq --> may sleep I do not find a good way to fix it, so I only report. This possible bug is found by my static analysis tool (DSAC) and c