Re: [BUG -tip] kmemleak and stacktrace cause page faul

2019-10-23 Thread Cyrill Gorcunov
On Wed, Oct 23, 2019 at 03:47:57PM +0200, Thomas Gleixner wrote: > > So the fix is trivial. Works like a charm. Tested-by: Cyrill Gorcunov

Re: [BUG -tip] kmemleak and stacktrace cause page faul

2019-10-23 Thread Cyrill Gorcunov
On Wed, Oct 23, 2019 at 03:47:57PM +0200, Thomas Gleixner wrote: > > And you are right this happens because cea_exception_stacks is not yet > initialized which makes begin = 0 and therefore point into nirvana. > > So the fix is trivial. Great! Thanks a lot for sych detailed analysis! I'll test

Re: [BUG -tip] kmemleak and stacktrace cause page faul

2019-10-23 Thread Thomas Gleixner
On Wed, 23 Oct 2019, Thomas Gleixner wrote: > On Tue, 22 Oct 2019, Cyrill Gorcunov wrote: > Ergo ep must be a valid pointer pointing to the statically allocated and > statically initialized estack_pages array. > > /* Guard page? */ > if (!ep->size) > > How on earth can

Re: [BUG -tip] kmemleak and stacktrace cause page faul

2019-10-23 Thread Cyrill Gorcunov
On Wed, Oct 23, 2019 at 03:38:40PM +0200, Thomas Gleixner wrote: > > > > > > [0,2,4,5,6,8,10,12] are guard pages so 0 is not that crappy at all > > > > Wait, Thomas, I might be wrong, but per-cpu is initialized to the pointer, > > the memory for this estack_pages has not yet been allocated, no?

Re: [BUG -tip] kmemleak and stacktrace cause page faul

2019-10-23 Thread Thomas Gleixner
On Wed, 23 Oct 2019, Cyrill Gorcunov wrote: > On Wed, Oct 23, 2019 at 03:21:05PM +0200, Thomas Gleixner wrote: > > Errm. estack_pages is statically initialized and it's an array of:. > > > > struct estack_pages { > > u32 offs; > > u16 size; > > u16 type; > > };

Re: [BUG -tip] kmemleak and stacktrace cause page faul

2019-10-23 Thread Thomas Gleixner
On Tue, 22 Oct 2019, Cyrill Gorcunov wrote: > On Tue, Oct 22, 2019 at 05:23:25PM +0300, Cyrill Gorcunov wrote: > > > > I presume the kmemleak tries to save stack trace too early when > > estack_pages are not > > yet filled. > > Indeed, at this stage of boot the percpu_setup_exception_stacks has

Re: [BUG -tip] kmemleak and stacktrace cause page faul

2019-10-23 Thread Cyrill Gorcunov
On Wed, Oct 23, 2019 at 03:21:05PM +0200, Thomas Gleixner wrote: > On Tue, 22 Oct 2019, Cyrill Gorcunov wrote: > > On Tue, Oct 22, 2019 at 05:23:25PM +0300, Cyrill Gorcunov wrote: > > > > > > I presume the kmemleak tries to save stack trace too early when > > > estack_pages are not > > > yet

Re: [BUG -tip] kmemleak and stacktrace cause page faul

2019-10-22 Thread Cyrill Gorcunov
On Tue, Oct 22, 2019 at 05:23:25PM +0300, Cyrill Gorcunov wrote: > > I presume the kmemleak tries to save stack trace too early when estack_pages > are not > yet filled. Indeed, at this stage of boot the percpu_setup_exception_stacks has not been called yet and estack_pages full of crap [

Re: [BUG -tip] kmemleak and stacktrace cause page faul

2019-10-22 Thread Cyrill Gorcunov
On Sat, Oct 19, 2019 at 02:44:21PM +0300, Cyrill Gorcunov wrote: ... > > I nailed it down to the following kmemleak code > > create_object > ... > object->trace_len = __save_stack_trace(object->trace); > > if I drop this line out it boots fine. Just wanted to share the observation, >

[BUG -tip] kmemleak and stacktrace cause page faul

2019-10-19 Thread Cyrill Gorcunov
Hi! I'm not sure if I've CC'ed proper persons, so please sorry if I did. Anyway, today's -tip (07b4dbf1d830) refused to boot [0.024793] No NUMA configuration found [0.025406] Faking a node at [mem 0x-0x7ffdefff] [0.026462] NODE_DATA(0) allocated [mem