Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-15 Thread WU Fengguang
On Tue, Aug 14, 2007 at 10:10:58AM -0700, Andy Isaacson wrote: > On Sun, Aug 12, 2007 at 08:27:46PM +0800, WU Fengguang wrote: > > On Sun, Aug 12, 2007 at 05:27:52PM +0530, Balbir Singh wrote: > > > For some reason my mailer keeps removing you from the cc. > > > > Or maybe it's my SMTP server's

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-15 Thread WU Fengguang
On Tue, Aug 14, 2007 at 10:10:58AM -0700, Andy Isaacson wrote: On Sun, Aug 12, 2007 at 08:27:46PM +0800, WU Fengguang wrote: On Sun, Aug 12, 2007 at 05:27:52PM +0530, Balbir Singh wrote: For some reason my mailer keeps removing you from the cc. Or maybe it's my SMTP server's problem.

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-14 Thread Andy Isaacson
On Sun, Aug 12, 2007 at 08:27:46PM +0800, WU Fengguang wrote: > On Sun, Aug 12, 2007 at 05:27:52PM +0530, Balbir Singh wrote: > > For some reason my mailer keeps removing you from the cc. > > Or maybe it's my SMTP server's problem. Email systems are complex. It's the Mail-Followup-To header you

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-14 Thread Andy Isaacson
On Sun, Aug 12, 2007 at 08:27:46PM +0800, WU Fengguang wrote: On Sun, Aug 12, 2007 at 05:27:52PM +0530, Balbir Singh wrote: For some reason my mailer keeps removing you from the cc. Or maybe it's my SMTP server's problem. Email systems are complex. It's the Mail-Followup-To header you

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-13 Thread Cyrill Gorcunov
[Alan Cox - Mon, Aug 13, 2007 at 12:22:24PM +0100] | > Well, as I see, it seems the Alan's patch is correct. We pass | > newly created mm to security_vm_enough_memory_mm() and get no errors | > here even for overcommit = 2. But my question was that mm->total_vm | > = 0 for this case and that is

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-13 Thread Alan Cox
> Well, as I see, it seems the Alan's patch is correct. We pass > newly created mm to security_vm_enough_memory_mm() and get no errors > here even for overcommit = 2. But my question was that mm->total_vm > = 0 for this case and that is probably valid too I think. What about > the thing you

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-13 Thread Cyrill Gorcunov
[WU Fengguang - Mon, Aug 13, 2007 at 08:23:42AM +0800] | On Sun, Aug 12, 2007 at 08:21:43PM +0400, Cyrill Gorcunov wrote: | > [Alan Cox - Sun, Aug 12, 2007 at 04:17:44PM +0100] | > | Try this (it compiles but isnt tested). Its a weekend here, the sun is | > | shining, the beach is a short walk,

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-13 Thread WU Fengguang
On Sun, Aug 12, 2007 at 04:17:44PM +0100, Alan Cox wrote: > Try this (it compiles but isnt tested). Its a weekend here, the sun is > shining, the beach is a short walk, and I have more interesting things to > do right now 8) Have a nice day~~~ It works! > ---

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-13 Thread WU Fengguang
On Sun, Aug 12, 2007 at 04:17:44PM +0100, Alan Cox wrote: Try this (it compiles but isnt tested). Its a weekend here, the sun is shining, the beach is a short walk, and I have more interesting things to do right now 8) Have a nice day~~~ It works! --- linux.vanilla-2.6.23rc1-mm1/mm/mmap.c

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-13 Thread Cyrill Gorcunov
[WU Fengguang - Mon, Aug 13, 2007 at 08:23:42AM +0800] | On Sun, Aug 12, 2007 at 08:21:43PM +0400, Cyrill Gorcunov wrote: | [Alan Cox - Sun, Aug 12, 2007 at 04:17:44PM +0100] | | Try this (it compiles but isnt tested). Its a weekend here, the sun is | | shining, the beach is a short walk, and I

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-13 Thread Alan Cox
Well, as I see, it seems the Alan's patch is correct. We pass newly created mm to security_vm_enough_memory_mm() and get no errors here even for overcommit = 2. But my question was that mm-total_vm = 0 for this case and that is probably valid too I think. What about the thing you pointed

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-13 Thread Cyrill Gorcunov
[Alan Cox - Mon, Aug 13, 2007 at 12:22:24PM +0100] | Well, as I see, it seems the Alan's patch is correct. We pass | newly created mm to security_vm_enough_memory_mm() and get no errors | here even for overcommit = 2. But my question was that mm-total_vm | = 0 for this case and that is

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread WU Fengguang
On Sun, Aug 12, 2007 at 08:21:43PM +0400, Cyrill Gorcunov wrote: > [Alan Cox - Sun, Aug 12, 2007 at 04:17:44PM +0100] > | Try this (it compiles but isnt tested). Its a weekend here, the sun is > | shining, the beach is a short walk, and I have more interesting things to > | do right now 8) > | >

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread Rene Herman
On 08/12/2007 05:17 PM, Alan Cox wrote: Try this (it compiles but isnt tested). Its a weekend here, the sun is shining, the beach is a short walk, and I have more interesting things to do right now 8) Oh come on, you have a beard. You can't go to the beach. Rene. - To unsubscribe from this

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread Cyrill Gorcunov
[Alan Cox - Sun, Aug 12, 2007 at 04:17:44PM +0100] | Try this (it compiles but isnt tested). Its a weekend here, the sun is | shining, the beach is a short walk, and I have more interesting things to | do right now 8) | | | diff -u --new-file --recursive --exclude-from /usr/src/exclude

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread Alan Cox
Try this (it compiles but isnt tested). Its a weekend here, the sun is shining, the beach is a short walk, and I have more interesting things to do right now 8) diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/include/linux/mm.h

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread WU Fengguang
On Sun, Aug 12, 2007 at 02:19:05PM +0100, Alan Cox wrote: > > > Great! So the problem might have existed for some time, but we never > > > saw it due to default over commit values? Were you using these values > > > for over commit even before? > > > > No I changed it several weeks ago to stop my

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread Alan Cox
> > Great! So the problem might have existed for some time, but we never > > saw it due to default over commit values? Were you using these values > > for over commit even before? > > No I changed it several weeks ago to stop my desktop from freezing. > So yes, the bug may have been there for a

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread WU Fengguang
Hi Balbir, [add CC to LKML] On Sun, Aug 12, 2007 at 05:27:52PM +0530, Balbir Singh wrote: > For some reason my mailer keeps removing you from the cc. Or maybe it's my SMTP server's problem. Email systems are complex. > >>> Thats a valid point. It would be interesting to see what the overcommit

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread Cyrill Gorcunov
[Balbir Singh - Sun, Aug 12, 2007 at 02:55:32PM +0530] | WU Fengguang wrote: | > On Sun, Aug 12, 2007 at 01:48:31PM +0800, WU Fengguang wrote: | >> On Sat, Aug 11, 2007 at 11:31:09PM +0530, Balbir Singh wrote: | >>> Andrew Morton wrote: | On Sat, 11 Aug 2007 20:00:12 +0530 "Balbir Singh"

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread Balbir Singh
WU Fengguang wrote: > On Sun, Aug 12, 2007 at 01:48:31PM +0800, WU Fengguang wrote: >> On Sat, Aug 11, 2007 at 11:31:09PM +0530, Balbir Singh wrote: >>> Andrew Morton wrote: On Sat, 11 Aug 2007 20:00:12 +0530 "Balbir Singh" <[EMAIL PROTECTED]> wrote: > Shouldn't we just not stop vm

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread WU Fengguang
On Sun, Aug 12, 2007 at 01:48:31PM +0800, WU Fengguang wrote: > On Sat, Aug 11, 2007 at 11:31:09PM +0530, Balbir Singh wrote: > > Andrew Morton wrote: > > > On Sat, 11 Aug 2007 20:00:12 +0530 "Balbir Singh" <[EMAIL PROTECTED]> > > > wrote: > > >>> > > >> Shouldn't we just not stop vm accounting

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread WU Fengguang
On Sun, Aug 12, 2007 at 01:48:31PM +0800, WU Fengguang wrote: On Sat, Aug 11, 2007 at 11:31:09PM +0530, Balbir Singh wrote: Andrew Morton wrote: On Sat, 11 Aug 2007 20:00:12 +0530 Balbir Singh [EMAIL PROTECTED] wrote: Shouldn't we just not stop vm accounting for kernel threads?

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread Balbir Singh
WU Fengguang wrote: On Sun, Aug 12, 2007 at 01:48:31PM +0800, WU Fengguang wrote: On Sat, Aug 11, 2007 at 11:31:09PM +0530, Balbir Singh wrote: Andrew Morton wrote: On Sat, 11 Aug 2007 20:00:12 +0530 Balbir Singh [EMAIL PROTECTED] wrote: Shouldn't we just not stop vm accounting for kernel

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread Cyrill Gorcunov
[Balbir Singh - Sun, Aug 12, 2007 at 02:55:32PM +0530] | WU Fengguang wrote: | On Sun, Aug 12, 2007 at 01:48:31PM +0800, WU Fengguang wrote: | On Sat, Aug 11, 2007 at 11:31:09PM +0530, Balbir Singh wrote: | Andrew Morton wrote: | On Sat, 11 Aug 2007 20:00:12 +0530 Balbir Singh [EMAIL

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread WU Fengguang
Hi Balbir, [add CC to LKML] On Sun, Aug 12, 2007 at 05:27:52PM +0530, Balbir Singh wrote: For some reason my mailer keeps removing you from the cc. Or maybe it's my SMTP server's problem. Email systems are complex. Thats a valid point. It would be interesting to see what the overcommit

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread Alan Cox
Great! So the problem might have existed for some time, but we never saw it due to default over commit values? Were you using these values for over commit even before? No I changed it several weeks ago to stop my desktop from freezing. So yes, the bug may have been there for a while.

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread WU Fengguang
On Sun, Aug 12, 2007 at 02:19:05PM +0100, Alan Cox wrote: Great! So the problem might have existed for some time, but we never saw it due to default over commit values? Were you using these values for over commit even before? No I changed it several weeks ago to stop my desktop from

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread Alan Cox
Try this (it compiles but isnt tested). Its a weekend here, the sun is shining, the beach is a short walk, and I have more interesting things to do right now 8) diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/include/linux/mm.h

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread Cyrill Gorcunov
[Alan Cox - Sun, Aug 12, 2007 at 04:17:44PM +0100] | Try this (it compiles but isnt tested). Its a weekend here, the sun is | shining, the beach is a short walk, and I have more interesting things to | do right now 8) | | | diff -u --new-file --recursive --exclude-from /usr/src/exclude

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread Rene Herman
On 08/12/2007 05:17 PM, Alan Cox wrote: Try this (it compiles but isnt tested). Its a weekend here, the sun is shining, the beach is a short walk, and I have more interesting things to do right now 8) Oh come on, you have a beard. You can't go to the beach. Rene. - To unsubscribe from this

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-12 Thread WU Fengguang
On Sun, Aug 12, 2007 at 08:21:43PM +0400, Cyrill Gorcunov wrote: [Alan Cox - Sun, Aug 12, 2007 at 04:17:44PM +0100] | Try this (it compiles but isnt tested). Its a weekend here, the sun is | shining, the beach is a short walk, and I have more interesting things to | do right now 8) | |

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread WU Fengguang
On Sat, Aug 11, 2007 at 11:31:09PM +0530, Balbir Singh wrote: > Andrew Morton wrote: > > On Sat, 11 Aug 2007 20:00:12 +0530 "Balbir Singh" <[EMAIL PROTECTED]> wrote: > >>> > >> Shouldn't we just not stop vm accounting for kernel threads? > >> > > > > Could be. It'd help heaps if we knew which

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread WU Fengguang
On Sat, Aug 11, 2007 at 10:00:15AM -0700, Andrew Morton wrote: > On Sat, 11 Aug 2007 20:00:12 +0530 "Balbir Singh" <[EMAIL PROTECTED]> wrote: > > > On 8/11/07, Fengguang Wu <[EMAIL PROTECTED]> wrote: > > hm, both people who replied to this removed Fengguang from cc. Disagreement > between

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Cyrill Gorcunov
[Fengguang Wu - Sun, Aug 12, 2007 at 01:29:15PM +0800] | On Sat, Aug 11, 2007 at 06:17:14PM +0400, Cyrill Gorcunov wrote: | > [Fengguang Wu - Sat, Aug 11, 2007 at 09:21:31PM +0800] | > | Andrew, | > | | > | I'm not sure if this patch is the right fix for the bug. But it do | > | stops the oops

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Fengguang Wu
On Sat, Aug 11, 2007 at 06:17:14PM +0400, Cyrill Gorcunov wrote: > [Fengguang Wu - Sat, Aug 11, 2007 at 09:21:31PM +0800] > | Andrew, > | > | I'm not sure if this patch is the right fix for the bug. But it do > | stops the oops message. The bug also happens in > 2.6.23-rc1-mm2/2.6.23-rc2-mm2. >

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Cyrill Gorcunov
[Balbir Singh - Sat, Aug 11, 2007 at 11:31:09PM +0530] | Andrew Morton wrote: | > On Sat, 11 Aug 2007 20:00:12 +0530 "Balbir Singh" <[EMAIL PROTECTED]> wrote: | > | >> On 8/11/07, Fengguang Wu <[EMAIL PROTECTED]> wrote: | > | > hm, both people who replied to this removed Fengguang from cc.

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Balbir Singh
Andrew Morton wrote: > On Sat, 11 Aug 2007 20:00:12 +0530 "Balbir Singh" <[EMAIL PROTECTED]> wrote: > >> On 8/11/07, Fengguang Wu <[EMAIL PROTECTED]> wrote: > > hm, both people who replied to this removed Fengguang from cc. Disagreement > between headers and MUAs, perhaps? > Oops... Not sure

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Andrew Morton
On Sat, 11 Aug 2007 20:00:12 +0530 "Balbir Singh" <[EMAIL PROTECTED]> wrote: > On 8/11/07, Fengguang Wu <[EMAIL PROTECTED]> wrote: hm, both people who replied to this removed Fengguang from cc. Disagreement between headers and MUAs, perhaps? > > Andrew, > > > > I'm not sure if this patch is

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Balbir Singh
On 8/11/07, Fengguang Wu <[EMAIL PROTECTED]> wrote: > Andrew, > > I'm not sure if this patch is the right fix for the bug. But it do > stops the oops message. The bug also happens in 2.6.23-rc1-mm2/2.6.23-rc2-mm2. > I'm running debian/sid. The .config is attached. > > > Unable to handle kernel

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Cyrill Gorcunov
[Fengguang Wu - Sat, Aug 11, 2007 at 09:21:31PM +0800] | Andrew, | | I'm not sure if this patch is the right fix for the bug. But it do | stops the oops message. The bug also happens in 2.6.23-rc1-mm2/2.6.23-rc2-mm2. | I'm running debian/sid. The .config is attached. | | [...snip...] Even if

[BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Fengguang Wu
Andrew, I'm not sure if this patch is the right fix for the bug. But it do stops the oops message. The bug also happens in 2.6.23-rc1-mm2/2.6.23-rc2-mm2. I'm running debian/sid. The .config is attached. Unable to handle kernel NULL pointer dereference at 0138 RIP []

[BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Fengguang Wu
Andrew, I'm not sure if this patch is the right fix for the bug. But it do stops the oops message. The bug also happens in 2.6.23-rc1-mm2/2.6.23-rc2-mm2. I'm running debian/sid. The .config is attached. Unable to handle kernel NULL pointer dereference at 0138 RIP

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Cyrill Gorcunov
[Fengguang Wu - Sat, Aug 11, 2007 at 09:21:31PM +0800] | Andrew, | | I'm not sure if this patch is the right fix for the bug. But it do | stops the oops message. The bug also happens in 2.6.23-rc1-mm2/2.6.23-rc2-mm2. | I'm running debian/sid. The .config is attached. | | [...snip...] Even if

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Balbir Singh
On 8/11/07, Fengguang Wu [EMAIL PROTECTED] wrote: Andrew, I'm not sure if this patch is the right fix for the bug. But it do stops the oops message. The bug also happens in 2.6.23-rc1-mm2/2.6.23-rc2-mm2. I'm running debian/sid. The .config is attached. Unable to handle kernel NULL pointer

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Andrew Morton
On Sat, 11 Aug 2007 20:00:12 +0530 Balbir Singh [EMAIL PROTECTED] wrote: On 8/11/07, Fengguang Wu [EMAIL PROTECTED] wrote: hm, both people who replied to this removed Fengguang from cc. Disagreement between headers and MUAs, perhaps? Andrew, I'm not sure if this patch is the right fix

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Balbir Singh
Andrew Morton wrote: On Sat, 11 Aug 2007 20:00:12 +0530 Balbir Singh [EMAIL PROTECTED] wrote: On 8/11/07, Fengguang Wu [EMAIL PROTECTED] wrote: hm, both people who replied to this removed Fengguang from cc. Disagreement between headers and MUAs, perhaps? Oops... Not sure how that

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Cyrill Gorcunov
[Balbir Singh - Sat, Aug 11, 2007 at 11:31:09PM +0530] | Andrew Morton wrote: | On Sat, 11 Aug 2007 20:00:12 +0530 Balbir Singh [EMAIL PROTECTED] wrote: | | On 8/11/07, Fengguang Wu [EMAIL PROTECTED] wrote: | | hm, both people who replied to this removed Fengguang from cc. Disagreement |

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Fengguang Wu
On Sat, Aug 11, 2007 at 06:17:14PM +0400, Cyrill Gorcunov wrote: [Fengguang Wu - Sat, Aug 11, 2007 at 09:21:31PM +0800] | Andrew, | | I'm not sure if this patch is the right fix for the bug. But it do | stops the oops message. The bug also happens in 2.6.23-rc1-mm2/2.6.23-rc2-mm2. | I'm

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Cyrill Gorcunov
[Fengguang Wu - Sun, Aug 12, 2007 at 01:29:15PM +0800] | On Sat, Aug 11, 2007 at 06:17:14PM +0400, Cyrill Gorcunov wrote: | [Fengguang Wu - Sat, Aug 11, 2007 at 09:21:31PM +0800] | | Andrew, | | | | I'm not sure if this patch is the right fix for the bug. But it do | | stops the oops

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread WU Fengguang
On Sat, Aug 11, 2007 at 10:00:15AM -0700, Andrew Morton wrote: On Sat, 11 Aug 2007 20:00:12 +0530 Balbir Singh [EMAIL PROTECTED] wrote: On 8/11/07, Fengguang Wu [EMAIL PROTECTED] wrote: hm, both people who replied to this removed Fengguang from cc. Disagreement between headers and MUAs,

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread WU Fengguang
On Sat, Aug 11, 2007 at 11:31:09PM +0530, Balbir Singh wrote: Andrew Morton wrote: On Sat, 11 Aug 2007 20:00:12 +0530 Balbir Singh [EMAIL PROTECTED] wrote: Shouldn't we just not stop vm accounting for kernel threads? Could be. It'd help heaps if we knew which patch in -mm caused